Repository navigation
fix: preserve completed chat responses after stream retry - #6302
ironloopai[bot] wants to merge 2 commits into
Conversation
🔎 IronLoop Review StatusHead: Current reviewers:
Reviewer summaries
Recent activity
Available commands
Run metadataAdmission: webhook accepted the request and IronLoop persisted reviewer state before this projection. |
There was a problem hiding this comment.
✅ IronLoop Review: reviewer
Review at a glance
| Verdict | Blocking | Notes | Inline | Head |
|---|---|---|---|---|
| ✅ Approved | 0 | 0 | 0 | dbf1a3485208 |
Head: dbf1a34852082673a7f1c25a18887ee0984c7401
Next: No reviewer action needed.
Run details
Status: Current
Needs human: no
Needs validation: no
Summary
Approved. Focused two-file frontend state-handling change correctly treats final replies as successful terminal completion and covers the trailing retryable replay-error regression.
Findings
None.
Developer follow-up
After fixing this feedback:
- Push the fix to this PR branch.
- Re-run this reviewer with
@ironloopai review --agent reviewerif you only changed this reviewer's findings. - Re-run all reviewers with
@ironloopai reviewwhen the fix may affect multiple areas.
|
🚅 Deployed to the ironclaw-pr-6302 environment in ironclaw-ci-preview
|
Coverage ratchetReborn integration-tier coverageLine coverage (Reborn crates): 86.33% — 320358 / 371078 lines Per-crate breakdown (65 crates, lowest-covered first)
This table itself is informational and never gates the PR on its own — not the percentage, not the per-crate holes, not the 0-coverage callout. A separate coverage ratchet (dry-run until enforce=true; see tests/integration/coverage-floor.toml) can fail the build on specific configured floors. Exemptions (3 entry/entries excluded from the accounting above)
|
|
@ironloopai resolve |
🔧 IronLoop Resolve StatusIssue: #6302 Current resolve:
Recent activityEach row is one developer job. Phase details below belong to that job.
Phase log: ironloop/small-fix-resolver (
ironloop/small-fix-resolver (
ironloop/small-fix-resolver (
ironloop/small-fix-resolver (
Available commands
Run metadataAdmission: webhook accepted the request and IronLoop persisted developer state before this projection. |
There was a problem hiding this comment.
✅ IronLoop Review: reviewer
Review at a glance
| Verdict | Blocking | Notes | Inline | Head |
|---|---|---|---|---|
| ✅ Approved | 0 | 0 | 0 | 2783c1296c34 |
Head: 2783c1296c348755eca53ee524e4088ff31ac3f2
Next: No reviewer action needed.
Run details
Status: Current
Needs human: no
Needs validation: no
Summary
Focused 48-line frontend change correctly settles a received final reply, preserving it through a retryable replay error and triggering the existing durable timeline refresh.
Findings
None.
Developer follow-up
After fixing this feedback:
- Push the fix to this PR branch.
- Re-run this reviewer with
@ironloopai review --agent reviewerif you only changed this reviewer's findings. - Re-run all reviewers with
@ironloopai reviewwhen the fix may affect multiple areas.
Summary
final_replyfollowed byreplay_unavailable.Validation
corepack pnpm lintcorepack pnpm testcorepack pnpm buildscripts/pre-commit-safety.shRust crate tests were attempted but the environment has no
cclinker. This is a frontend-only state-handling change; reverting the commit restores prior behavior.Closes #6189.
Opened by IronLoop after verifying the local implementation branch.