Repository navigation
refactor(reborn): delivered-gate-route store over RootFilesystem, delete InMemoryDeliveredGateRouteStore (§4.3) - #6214
Merged
ilblackdragon merged 2 commits intoJul 18, 2026
Conversation
Contributor
🔎 IronLoop Review StatusHead: Current reviewers:
Reviewer summaries
Recent activity
Available commands
Run metadataAdmission: webhook accepted the request and IronLoop persisted reviewer state before this projection. |
railway-app
Bot
temporarily deployed
to
ironclaw-ci-preview / ironclaw-pr-6214
July 18, 2026 00:16
Destroyed
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
size: L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the InMemoryDeliveredGateRouteStore and replaces it with a stateless NoopDeliveredGateRouteStore for surfaces that do not route delivered gates. Test suites across multiple crates have been updated to use the in_memory_backed_outbound_state_store() helper instead of the deleted in-memory store. The feedback suggests deriving Clone and Copy on the new NoopDeliveredGateRouteStore struct to make it more flexible and easier to pass around.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+169
to
+170
| #[derive(Debug, Default)] | ||
| pub struct NoopDeliveredGateRouteStore; |
Contributor
There was a problem hiding this comment.
Since NoopDeliveredGateRouteStore is a stateless unit struct, it is highly recommended to derive Clone and Copy in addition to Debug and Default. This makes the null object much more flexible to use and pass around in various contexts (e.g., when stored in structures that require these bounds) without needing to wrap it in an Arc or reference.
Suggested change
| #[derive(Debug, Default)] | |
| pub struct NoopDeliveredGateRouteStore; | |
| #[derive(Debug, Clone, Copy, Default)] | |
| pub struct NoopDeliveredGateRouteStore; |
Member
Author
There was a problem hiding this comment.
Applied in the follow-up commit on this branch: NoopDeliveredGateRouteStore now derives Clone and Copy alongside Debug/Default.
![ironloopai[bot]](https://avatars.githubusercontent.com/in/4116490?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ IronLoop Review: reviewer
Review at a glance
| Verdict | Blocking | Notes | Inline | Head |
|---|---|---|---|---|
| ✅ Approved | 0 | 0 | 0 | 9f230ee8e9e5 |
Head: 9f230ee8e9e533e3b0ad1f410c03fa1b66090cc8
Next: No reviewer action needed.
Run details
Status: Current
Needs human: no
Needs validation: no
Summary
Reviewed the complete, bounded stack-layer delta (8 files, 123 additions/299 deletions). The no-op workflow default preserves the prior empty-store behavior, while the Slack production path continues to inject the shared filesystem-backed route store. No concrete correctness, security, or data-loss issue was found.
Findings
None.
Developer follow-up
After fixing this feedback:
- Push the fix to this PR branch.
- Re-run this reviewer with
@ironloopai review --agent reviewerif you only changed this reviewer's findings. - Re-run all reviewers with
@ironloopai reviewwhen the fix may affect multiple areas.
ilblackdragon
force-pushed
the
refactor/reborn-consolidate-triggered-run-delivery-store
branch
from
July 18, 2026 00:20
cf3ad9a to
699ce05
Compare
ilblackdragon
force-pushed
the
refactor/reborn-consolidate-delivered-gate-route-store
branch
from
July 18, 2026 00:20
9f230ee to
66d7cf2
Compare
railway-app
Bot
temporarily deployed
to
ironclaw-ci-preview / ironclaw-pr-6214
July 18, 2026 00:20
Destroyed
|
🚅 Deployed to the ironclaw-pr-6214 environment in ironclaw-ci-preview
|
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…moryOutboundStateStore Semantic rebase conflict: #6159 landed the new ironclaw_channel_delivery crate on main with tests built against InMemoryOutboundStateStore, which this slice deletes. Repointed to the test-support helper / FilesystemOutboundStateStore<InMemoryBackend> (dev-dep feature added); InMemoryTriggeredRunDeliveryStore / InMemoryDeliveredGateRouteStore refs stay — their slices (#6213/#6214) own those repoints. 92 tests green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ilblackdragon
force-pushed
the
refactor/reborn-consolidate-triggered-run-delivery-store
branch
2 times, most recently
from
July 18, 2026 01:07
dff3188 to
5a9134c
Compare
ilblackdragon
force-pushed
the
refactor/reborn-consolidate-delivered-gate-route-store
branch
from
July 18, 2026 01:07
66d7cf2 to
154913a
Compare
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…evable-floor status The mechanical §4.3 store consolidations are complete (A1–A8: approvals, authorization, processes, run-state, budget-gate, and the whole outbound family — OutboundState/TriggeredRunDelivery/DeliveredGateRoute). Every entry still in `FROZEN_INMEMORY_STORES` is blocked on non-mechanical work OR is a justified keep, so the §10 "shrink to empty" goal is not reachable by a swap. This annotates each remaining allowlist entry with its VERIFIED status so the next contributor picks up a scoped task instead of re-deriving the blocker (comments are stripped by the scanner — documentation only, the enforced string set is unchanged; entries reordered to group the justified keeps): - turns cluster — DEFERRED (production `inmemory-turn-state` authority; needs a no-livelock concurrency proof + a built filesystem variant, some cross-crate). - `InMemoryBoundedSubagentGoalStore`, `InMemoryOpenAiCompatRefStore` — JUSTIFIED bounded CACHES (capacity-bounded evict-oldest / bounded-LRU + filesystem-free contract boundary), NOT persistence debt; a durable variant would be wrong. - `InMemoryExtensionInstallationStore` — BLOCKED cross-crate (the Filesystem variant in composition depends on a composition-internal contract registry; can't move down to `ironclaw_extensions`). - `InMemorySecretStore` — security-sensitive. - `InMemorySessionStore` — BUILD-FIRST (no filesystem variant; auth-adjacent). Also reconciles the module-doc "definition of done" to note the two justified caches. No production code changes; ratchet self-tests + the frozen-set contract still pass (4 tests). Stacked on #6214. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
railway-app
Bot
temporarily deployed
to
ironclaw-ci-preview / ironclaw-pr-6214
July 18, 2026 01:07
Destroyed
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…harness doc Gemini note on #6214 (stateless unit-struct null object derives Copy) and the harness doc no longer describes the deleted store as the default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ilblackdragon
force-pushed
the
refactor/reborn-consolidate-delivered-gate-route-store
branch
from
July 18, 2026 01:10
154913a to
b375388
Compare
railway-app
Bot
temporarily deployed
to
ironclaw-ci-preview / ironclaw-pr-6214
July 18, 2026 01:10
Destroyed
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…evable-floor status The mechanical §4.3 store consolidations are complete (A1–A8: approvals, authorization, processes, run-state, budget-gate, and the whole outbound family — OutboundState/TriggeredRunDelivery/DeliveredGateRoute). Every entry still in `FROZEN_INMEMORY_STORES` is blocked on non-mechanical work OR is a justified keep, so the §10 "shrink to empty" goal is not reachable by a swap. This annotates each remaining allowlist entry with its VERIFIED status so the next contributor picks up a scoped task instead of re-deriving the blocker (comments are stripped by the scanner — documentation only, the enforced string set is unchanged; entries reordered to group the justified keeps): - turns cluster — DEFERRED (production `inmemory-turn-state` authority; needs a no-livelock concurrency proof + a built filesystem variant, some cross-crate). - `InMemoryBoundedSubagentGoalStore`, `InMemoryOpenAiCompatRefStore` — JUSTIFIED bounded CACHES (capacity-bounded evict-oldest / bounded-LRU + filesystem-free contract boundary), NOT persistence debt; a durable variant would be wrong. - `InMemoryExtensionInstallationStore` — BLOCKED cross-crate (the Filesystem variant in composition depends on a composition-internal contract registry; can't move down to `ironclaw_extensions`). - `InMemorySecretStore` — security-sensitive. - `InMemorySessionStore` — BUILD-FIRST (no filesystem variant; auth-adjacent). Also reconciles the module-doc "definition of done" to note the two justified caches. No production code changes; ratchet self-tests + the frozen-set contract still pass (4 tests). Stacked on #6214. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ete InMemoryDeliveredGateRouteStore (§4.3) Completes the §4.3 outbound-store consolidation (last of the outbound family after A6 OutboundState + A7 TriggeredRunDelivery). Deletes the hand-written `InMemoryDeliveredGateRouteStore` — a ~200-line HashMap store that `FilesystemOutboundStateStore` already duplicates via its `DeliveredGateRouteStore` impl. The blocker (recorded in the worklog) was a load-bearing PRODUCTION default: `DefaultProductWorkflow::new` (79 callers) set `InMemoryDeliveredGateRouteStore::default()`, relied on by the OpenAI-compat surface — which never routes gates (never produces approval/auth resolution payloads), so the store is only ever READ (returns empty) there. Rather than a 79-caller DI refactor OR pulling a mandatory `ironclaw_filesystem` dep into `product_workflow` (its filesystem dep is deliberately optional), the default becomes a new filesystem-free **`NoopDeliveredGateRouteStore`** null object: reads return empty, best-effort `remove`/`sweep` are no-ops, and `record` fails **loud** (the workflow never records — verified: no `record_delivered_gate_route` call in `product_workflow/src`; recording happens in the composition slack-delivery path via a setter-injected real store). This is behavior-identical to the old empty-in-memory default for the non-routing surface, with no fail-silent hazard. Changes: - `ironclaw_outbound`: delete `InMemoryDeliveredGateRouteStore` struct+impl + its now-orphaned `RouteKey`/`ConversationIndexKey` helpers and `HashMap`/`Mutex`/`BTreeSet` imports; add `NoopDeliveredGateRouteStore` (null object next to the trait); own tests use the `crate::test_support` filesystem helper. - `DefaultProductWorkflow::new` default → `NoopDeliveredGateRouteStore` (field type + signature + 79 callers all UNCHANGED — only the default value). - Test doubles (composition slack_delivery/e2e_tests/delivered_gate_routing, product_workflow_contract) → the A6 `in_memory_backed_outbound_state_store()` helper (real storage, impls the trait). - R1 ratchet: drop `InMemoryDeliveredGateRouteStore` from the frozen allowlist — the outbound family is now fully consolidated. Net -178 lines. Verified: outbound 110, product_workflow 114, composition slack 387 + delivered_gate_routing 7 — all pass; `cargo build -p ironclaw_reborn_composition` default (the Noop production-default path) clean; clippy -D warnings clean on outbound + product_workflow + composition; ratchet 4; fmt + pre-commit clean. Stacked on #6213. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…harness doc Gemini note on #6214 (stateless unit-struct null object derives Copy) and the harness doc no longer describes the deleted store as the default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ilblackdragon
force-pushed
the
refactor/reborn-consolidate-triggered-run-delivery-store
branch
from
July 18, 2026 01:20
baa5deb to
0979acf
Compare
ilblackdragon
force-pushed
the
refactor/reborn-consolidate-delivered-gate-route-store
branch
from
July 18, 2026 01:20
b375388 to
8d453ff
Compare
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…evable-floor status The mechanical §4.3 store consolidations are complete (A1–A8: approvals, authorization, processes, run-state, budget-gate, and the whole outbound family — OutboundState/TriggeredRunDelivery/DeliveredGateRoute). Every entry still in `FROZEN_INMEMORY_STORES` is blocked on non-mechanical work OR is a justified keep, so the §10 "shrink to empty" goal is not reachable by a swap. This annotates each remaining allowlist entry with its VERIFIED status so the next contributor picks up a scoped task instead of re-deriving the blocker (comments are stripped by the scanner — documentation only, the enforced string set is unchanged; entries reordered to group the justified keeps): - turns cluster — DEFERRED (production `inmemory-turn-state` authority; needs a no-livelock concurrency proof + a built filesystem variant, some cross-crate). - `InMemoryBoundedSubagentGoalStore`, `InMemoryOpenAiCompatRefStore` — JUSTIFIED bounded CACHES (capacity-bounded evict-oldest / bounded-LRU + filesystem-free contract boundary), NOT persistence debt; a durable variant would be wrong. - `InMemoryExtensionInstallationStore` — BLOCKED cross-crate (the Filesystem variant in composition depends on a composition-internal contract registry; can't move down to `ironclaw_extensions`). - `InMemorySecretStore` — security-sensitive. - `InMemorySessionStore` — BUILD-FIRST (no filesystem variant; auth-adjacent). Also reconciles the module-doc "definition of done" to note the two justified caches. No production code changes; ratchet self-tests + the frozen-set contract still pass (4 tests). Stacked on #6214. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
railway-app
Bot
temporarily deployed
to
ironclaw-ci-preview / ironclaw-pr-6214
July 18, 2026 01:20
Destroyed
Member
Author
✅ Ready for mergeCI green (18 pass / 0 fail) on the restacked head. Stacked on #6213.
🤖 Generated with Claude Code |
ilblackdragon
merged commit Jul 18, 2026
fb2bc20
into
refactor/reborn-consolidate-triggered-run-delivery-store
20 checks passed
ilblackdragon
deleted the
refactor/reborn-consolidate-delivered-gate-route-store
branch
July 18, 2026 03:03
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…ete InMemoryDeliveredGateRouteStore (§4.3) (#6214) * refactor(reborn): delivered-gate-route store over RootFilesystem, delete InMemoryDeliveredGateRouteStore (§4.3) Completes the §4.3 outbound-store consolidation (last of the outbound family after A6 OutboundState + A7 TriggeredRunDelivery). Deletes the hand-written `InMemoryDeliveredGateRouteStore` — a ~200-line HashMap store that `FilesystemOutboundStateStore` already duplicates via its `DeliveredGateRouteStore` impl. The blocker (recorded in the worklog) was a load-bearing PRODUCTION default: `DefaultProductWorkflow::new` (79 callers) set `InMemoryDeliveredGateRouteStore::default()`, relied on by the OpenAI-compat surface — which never routes gates (never produces approval/auth resolution payloads), so the store is only ever READ (returns empty) there. Rather than a 79-caller DI refactor OR pulling a mandatory `ironclaw_filesystem` dep into `product_workflow` (its filesystem dep is deliberately optional), the default becomes a new filesystem-free **`NoopDeliveredGateRouteStore`** null object: reads return empty, best-effort `remove`/`sweep` are no-ops, and `record` fails **loud** (the workflow never records — verified: no `record_delivered_gate_route` call in `product_workflow/src`; recording happens in the composition slack-delivery path via a setter-injected real store). This is behavior-identical to the old empty-in-memory default for the non-routing surface, with no fail-silent hazard. Changes: - `ironclaw_outbound`: delete `InMemoryDeliveredGateRouteStore` struct+impl + its now-orphaned `RouteKey`/`ConversationIndexKey` helpers and `HashMap`/`Mutex`/`BTreeSet` imports; add `NoopDeliveredGateRouteStore` (null object next to the trait); own tests use the `crate::test_support` filesystem helper. - `DefaultProductWorkflow::new` default → `NoopDeliveredGateRouteStore` (field type + signature + 79 callers all UNCHANGED — only the default value). - Test doubles (composition slack_delivery/e2e_tests/delivered_gate_routing, product_workflow_contract) → the A6 `in_memory_backed_outbound_state_store()` helper (real storage, impls the trait). - R1 ratchet: drop `InMemoryDeliveredGateRouteStore` from the frozen allowlist — the outbound family is now fully consolidated. Net -178 lines. Verified: outbound 110, product_workflow 114, composition slack 387 + delivered_gate_routing 7 — all pass; `cargo build -p ironclaw_reborn_composition` default (the Noop production-default path) clean; clippy -D warnings clean on outbound + product_workflow + composition; ratchet 4; fmt + pre-commit clean. Stacked on #6213. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(reborn): Clone/Copy the Noop route store; refresh stale e2e harness doc Gemini note on #6214 (stateless unit-struct null object derives Copy) and the harness doc no longer describes the deleted store as the default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…evable-floor status The mechanical §4.3 store consolidations are complete (A1–A8: approvals, authorization, processes, run-state, budget-gate, and the whole outbound family — OutboundState/TriggeredRunDelivery/DeliveredGateRoute). Every entry still in `FROZEN_INMEMORY_STORES` is blocked on non-mechanical work OR is a justified keep, so the §10 "shrink to empty" goal is not reachable by a swap. This annotates each remaining allowlist entry with its VERIFIED status so the next contributor picks up a scoped task instead of re-deriving the blocker (comments are stripped by the scanner — documentation only, the enforced string set is unchanged; entries reordered to group the justified keeps): - turns cluster — DEFERRED (production `inmemory-turn-state` authority; needs a no-livelock concurrency proof + a built filesystem variant, some cross-crate). - `InMemoryBoundedSubagentGoalStore`, `InMemoryOpenAiCompatRefStore` — JUSTIFIED bounded CACHES (capacity-bounded evict-oldest / bounded-LRU + filesystem-free contract boundary), NOT persistence debt; a durable variant would be wrong. - `InMemoryExtensionInstallationStore` — BLOCKED cross-crate (the Filesystem variant in composition depends on a composition-internal contract registry; can't move down to `ironclaw_extensions`). - `InMemorySecretStore` — security-sensitive. - `InMemorySessionStore` — BUILD-FIRST (no filesystem variant; auth-adjacent). Also reconciles the module-doc "definition of done" to note the two justified caches. No production code changes; ratchet self-tests + the frozen-set contract still pass (4 tests). Stacked on #6214. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 18, 2026
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…elete InMemoryTriggeredRunDeliveryStore (§4.3) (#6213) * refactor(reborn): triggered-run-delivery store over RootFilesystem, delete InMemoryTriggeredRunDeliveryStore (§4.3) Continues the §4.3 store consolidation and builds directly on the A6 outbound work: delete the hand-written `InMemoryTriggeredRunDeliveryStore` and use the one production `FilesystemOutboundStateStore` — which already implements `TriggeredRunDeliveryStore` (filesystem_store.rs) — over an in-memory backend. `InMemoryTriggeredRunDeliveryStore` is entirely test-only (unlike its sibling `InMemoryDeliveredGateRouteStore`, which has a production default in `DefaultProductWorkflow::new` blocked on a DI refactor — deferred). After A6 closed the no-durable outbound gap, the production factory already uses `FilesystemOutboundStateStore` for the triggered-run-delivery role; only test doubles remained. Changes: - `ironclaw_outbound`: delete the `InMemoryTriggeredRunDeliveryStore` struct+impl from `triggered_run_delivery.rs` (keep the trait/record/enum) + its `pub use`; remove now-unused `HashMap`/`Mutex` imports. Own tests use the `crate::test_support` helper. - Test doubles (composition `slack_delivery.rs`, `slack_serve/e2e_tests.rs`, root `tests/integration/triggered_delivery_outcome.rs`) repointed to the A6 `in_memory_backed_outbound_state_store()` helper (impls the trait). Composition dev-dep already had `ironclaw_outbound/test-support` from A6; added it to the root crate's dev-dep for the integration test. - R1 ratchet: drop `InMemoryTriggeredRunDeliveryStore` from the frozen allowlist. Net -40 lines. Verified: ratchet 4, outbound 110, composition slack 387, `reborn_integration_triggered_delivery_outcome` 1 (the caller-supplied-store seam now injects the filesystem-backed store) — all pass; clippy -D warnings clean on outbound + composition; fmt + pre-commit clean. Stacked on #6212. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(reborn): dev-dep comment names the test-support helper, not the deleted store Addresses the IronLoop finding on #6213. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(reborn): delivered-gate-route store over RootFilesystem, delete InMemoryDeliveredGateRouteStore (§4.3) (#6214) * refactor(reborn): delivered-gate-route store over RootFilesystem, delete InMemoryDeliveredGateRouteStore (§4.3) Completes the §4.3 outbound-store consolidation (last of the outbound family after A6 OutboundState + A7 TriggeredRunDelivery). Deletes the hand-written `InMemoryDeliveredGateRouteStore` — a ~200-line HashMap store that `FilesystemOutboundStateStore` already duplicates via its `DeliveredGateRouteStore` impl. The blocker (recorded in the worklog) was a load-bearing PRODUCTION default: `DefaultProductWorkflow::new` (79 callers) set `InMemoryDeliveredGateRouteStore::default()`, relied on by the OpenAI-compat surface — which never routes gates (never produces approval/auth resolution payloads), so the store is only ever READ (returns empty) there. Rather than a 79-caller DI refactor OR pulling a mandatory `ironclaw_filesystem` dep into `product_workflow` (its filesystem dep is deliberately optional), the default becomes a new filesystem-free **`NoopDeliveredGateRouteStore`** null object: reads return empty, best-effort `remove`/`sweep` are no-ops, and `record` fails **loud** (the workflow never records — verified: no `record_delivered_gate_route` call in `product_workflow/src`; recording happens in the composition slack-delivery path via a setter-injected real store). This is behavior-identical to the old empty-in-memory default for the non-routing surface, with no fail-silent hazard. Changes: - `ironclaw_outbound`: delete `InMemoryDeliveredGateRouteStore` struct+impl + its now-orphaned `RouteKey`/`ConversationIndexKey` helpers and `HashMap`/`Mutex`/`BTreeSet` imports; add `NoopDeliveredGateRouteStore` (null object next to the trait); own tests use the `crate::test_support` filesystem helper. - `DefaultProductWorkflow::new` default → `NoopDeliveredGateRouteStore` (field type + signature + 79 callers all UNCHANGED — only the default value). - Test doubles (composition slack_delivery/e2e_tests/delivered_gate_routing, product_workflow_contract) → the A6 `in_memory_backed_outbound_state_store()` helper (real storage, impls the trait). - R1 ratchet: drop `InMemoryDeliveredGateRouteStore` from the frozen allowlist — the outbound family is now fully consolidated. Net -178 lines. Verified: outbound 110, product_workflow 114, composition slack 387 + delivered_gate_routing 7 — all pass; `cargo build -p ironclaw_reborn_composition` default (the Noop production-default path) clean; clippy -D warnings clean on outbound + product_workflow + composition; ratchet 4; fmt + pre-commit clean. Stacked on #6213. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(reborn): Clone/Copy the Noop route store; refresh stale e2e harness doc Gemini note on #6214 (stateless unit-struct null object derives Copy) and the harness doc no longer describes the deleted store as the default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…evable-floor status The mechanical §4.3 store consolidations are complete (A1–A8: approvals, authorization, processes, run-state, budget-gate, and the whole outbound family — OutboundState/TriggeredRunDelivery/DeliveredGateRoute). Every entry still in `FROZEN_INMEMORY_STORES` is blocked on non-mechanical work OR is a justified keep, so the §10 "shrink to empty" goal is not reachable by a swap. This annotates each remaining allowlist entry with its VERIFIED status so the next contributor picks up a scoped task instead of re-deriving the blocker (comments are stripped by the scanner — documentation only, the enforced string set is unchanged; entries reordered to group the justified keeps): - turns cluster — DEFERRED (production `inmemory-turn-state` authority; needs a no-livelock concurrency proof + a built filesystem variant, some cross-crate). - `InMemoryBoundedSubagentGoalStore`, `InMemoryOpenAiCompatRefStore` — JUSTIFIED bounded CACHES (capacity-bounded evict-oldest / bounded-LRU + filesystem-free contract boundary), NOT persistence debt; a durable variant would be wrong. - `InMemoryExtensionInstallationStore` — BLOCKED cross-crate (the Filesystem variant in composition depends on a composition-internal contract registry; can't move down to `ironclaw_extensions`). - `InMemorySecretStore` — security-sensitive. - `InMemorySessionStore` — BUILD-FIRST (no filesystem variant; auth-adjacent). Also reconciles the module-doc "definition of done" to note the two justified caches. No production code changes; ratchet self-tests + the frozen-set contract still pass (4 tests). Stacked on #6214. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…le-floor status (#6216) * test(reborn): annotate the §4.3 store ratchet with the per-entry achievable-floor status The mechanical §4.3 store consolidations are complete (A1–A8: approvals, authorization, processes, run-state, budget-gate, and the whole outbound family — OutboundState/TriggeredRunDelivery/DeliveredGateRoute). Every entry still in `FROZEN_INMEMORY_STORES` is blocked on non-mechanical work OR is a justified keep, so the §10 "shrink to empty" goal is not reachable by a swap. This annotates each remaining allowlist entry with its VERIFIED status so the next contributor picks up a scoped task instead of re-deriving the blocker (comments are stripped by the scanner — documentation only, the enforced string set is unchanged; entries reordered to group the justified keeps): - turns cluster — DEFERRED (production `inmemory-turn-state` authority; needs a no-livelock concurrency proof + a built filesystem variant, some cross-crate). - `InMemoryBoundedSubagentGoalStore`, `InMemoryOpenAiCompatRefStore` — JUSTIFIED bounded CACHES (capacity-bounded evict-oldest / bounded-LRU + filesystem-free contract boundary), NOT persistence debt; a durable variant would be wrong. - `InMemoryExtensionInstallationStore` — BLOCKED cross-crate (the Filesystem variant in composition depends on a composition-internal contract registry; can't move down to `ironclaw_extensions`). - `InMemorySecretStore` — security-sensitive. - `InMemorySessionStore` — BUILD-FIRST (no filesystem variant; auth-adjacent). Also reconciles the module-doc "definition of done" to note the two justified caches. No production code changes; ratchet self-tests + the frozen-set contract still pass (4 tests). Stacked on #6214. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(reborn): correct the ratchet per-entry annotations (IronLoop findings on #6216) - Drop the reference to a worklog not present in the tree. - InMemoryCheckpointStateStore: FilesystemCheckpointStateStore already exists in ironclaw_loop_host (contract-tested, composition-wired) — the entry needs a test-seam swap, not a store built; LoopCheckpoint/ InstructionMaterialization still need variants built. - Justified-keeps section acknowledges the production filesystem variants that already exist and are wired (FilesystemSubagentGoalStore, FilesystemOpenAiCompatRefStore) — the in-memory types are the bounded volatile role beside them, not missing consolidations. - OpenAiCompatRef eviction described as oldest-created (min created_at, reads do not refresh recency), not LRU. - Completeness claim softened: the pub(crate) trio is explicitly untriaged rather than claimed verified. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ilblackdragon
added a commit
that referenced
this pull request
Jul 18, 2026
…> CompositeRootFilesystem (§4.4.1) (#6218) * test(reborn): annotate the §4.3 store ratchet with the per-entry achievable-floor status The mechanical §4.3 store consolidations are complete (A1–A8: approvals, authorization, processes, run-state, budget-gate, and the whole outbound family — OutboundState/TriggeredRunDelivery/DeliveredGateRoute). Every entry still in `FROZEN_INMEMORY_STORES` is blocked on non-mechanical work OR is a justified keep, so the §10 "shrink to empty" goal is not reachable by a swap. This annotates each remaining allowlist entry with its VERIFIED status so the next contributor picks up a scoped task instead of re-deriving the blocker (comments are stripped by the scanner — documentation only, the enforced string set is unchanged; entries reordered to group the justified keeps): - turns cluster — DEFERRED (production `inmemory-turn-state` authority; needs a no-livelock concurrency proof + a built filesystem variant, some cross-crate). - `InMemoryBoundedSubagentGoalStore`, `InMemoryOpenAiCompatRefStore` — JUSTIFIED bounded CACHES (capacity-bounded evict-oldest / bounded-LRU + filesystem-free contract boundary), NOT persistence debt; a durable variant would be wrong. - `InMemoryExtensionInstallationStore` — BLOCKED cross-crate (the Filesystem variant in composition depends on a composition-internal contract registry; can't move down to `ironclaw_extensions`). - `InMemorySecretStore` — security-sensitive. - `InMemorySessionStore` — BUILD-FIRST (no filesystem variant; auth-adjacent). Also reconciles the module-doc "definition of done" to note the two justified caches. No production code changes; ratchet self-tests + the frozen-set contract still pass (4 tests). Stacked on #6214. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(reborn): correct the ratchet per-entry annotations (IronLoop findings on #6216) - Drop the reference to a worklog not present in the tree. - InMemoryCheckpointStateStore: FilesystemCheckpointStateStore already exists in ironclaw_loop_host (contract-tested, composition-wired) — the entry needs a test-seam swap, not a store built; LoopCheckpoint/ InstructionMaterialization still need variants built. - Justified-keeps section acknowledges the production filesystem variants that already exist and are wired (FilesystemSubagentGoalStore, FilesystemOpenAiCompatRefStore) — the in-memory types are the bounded volatile role beside them, not missing consolidations. - OpenAiCompatRef eviction described as oldest-created (min created_at, reads do not refresh recency), not LRU. - Completeness claim softened: the pub(crate) trio is explicitly untriaged rather than claimed verified. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(reborn): inline the redundant LocalDevRootFilesystem alias -> CompositeRootFilesystem (§4.4.1) First §4.4.1 slice (deployment-mode-as-type cleanup), on a fresh axis now that the mechanical §4.3 store family is complete. `LocalDevRootFilesystem` was a `pub(crate) type LocalDevRootFilesystem = CompositeRootFilesystem;` alias — a pure redundant indirection whose `LocalDev` prefix falsely read as a deployment tier when it is just the composition's `CompositeRootFilesystem` (the same type factory.rs already used directly, interchangeably, in dozens of places). This is the doc's §4.4.1 bucket-(b): mis-prefixed shared substrate → de-prefix to the honest type. Inlined the alias to `ironclaw_filesystem::CompositeRootFilesystem` across the 4 composition files that used it (factory/runtime/openai_compat_serve/turn_run_snapshot, ~54 sites), deleted the alias, and repointed the imports (the alias was exported from `crate::factory`; consumers now import the real type from `ironclaw_filesystem`). The private, genuinely-local-dev `LocalDevRootFilesystemBundle` struct keeps its name (word-boundary rename left it untouched; it is not on the ratchet — visibility-aware scanner skips private types). R2 ratchet (`reborn_localdev_typename`): drop `LocalDevRootFilesystem` from the frozen allowlist — one fewer deployment-mode-as-type leak. Pure type-alias inline, semantically identical. Verified: `cargo build -p ironclaw_reborn_composition` (default + libsql+slack) clean; localdev ratchet 4; clippy -D warnings clean; local_dev composition tests 233 pass; fmt + pre-commit clean. Stacked on #6216. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Aug 5, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes the §4.3 outbound-store consolidation (last of the family after A6 OutboundState + A7 TriggeredRunDelivery). Deletes the hand-written
InMemoryDeliveredGateRouteStore— a ~200-line HashMap storeFilesystemOutboundStateStorealready duplicates via itsDeliveredGateRouteStoreimpl.The blocker + resolution
DefaultProductWorkflow::new(79 callers) set a load-bearing production defaultInMemoryDeliveredGateRouteStore::default(), relied on by the OpenAI-compat surface — which never routes gates (never produces approval/auth resolution payloads), so the store is only ever read (returns empty) there.Rather than a 79-caller DI refactor OR a mandatory
ironclaw_filesystemdep onproduct_workflow(its filesystem dep is deliberately optional), the default becomes a new filesystem-freeNoopDeliveredGateRouteStorenull object: reads empty, best-effortremove/sweepno-op,recordfails loud. The workflow never records (verified: norecord_delivered_gate_routecall inproduct_workflow/src— recording is in the composition slack-delivery path via a setter-injected real store), so this is behavior-identical to the old empty-in-memory default with no fail-silent hazard.Changes
ironclaw_outbound: deleteInMemoryDeliveredGateRouteStorestruct+impl + orphanedRouteKey/ConversationIndexKey+ unused imports; addNoopDeliveredGateRouteStore. Own tests →crate::test_supportfilesystem helper.DefaultProductWorkflow::newdefault →NoopDeliveredGateRouteStore(field type +new()signature + 79 callers all unchanged — only the default value).in_memory_backed_outbound_state_store()helper.InMemoryDeliveredGateRouteStore— the outbound family is now fully consolidated.Net −178 lines.
Verification
cargo build -p ironclaw_reborn_compositiondefault (the Noop production-default path) clean-D warningsclean on outbound + product_workflow + composition; ratchet 4; fmt + pre-commit cleanStack
Stacked on #6213.
🤖 Generated with Claude Code