fix: hide trigger creation internals - #5909
ironloopai[bot] wants to merge 4 commits into
Conversation
🔎 IronLoop Review StatusHead: Current reviewers:
Reviewer summaries
Recent activity
Available commands
Run metadataAdmission: webhook accepted the request and IronLoop persisted reviewer state before this projection. |
github-actions
Bot
added
size: M
![ironloopai[bot]](https://avatars.githubusercontent.com/in/4116490?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ IronLoop Review: reviewer
Review at a glance
| Verdict | Blocking | Notes | Inline | Head |
|---|---|---|---|---|
| ❌ Changes requested | 1 | 0 | 1 | e91b8db6236e |
Head: e91b8db6236e36003ad317176d8e92d100b51ea2
Next: Fix the blocking findings, push the PR branch, then re-run this reviewer.
Run details
Status: Current
Needs human: no
Needs validation: no
Summary
Found one trigger-create preview redaction gap that should be fixed before merge.
Findings
Blocking: 1 / Notes: 0
Blocking findings
1. ❌ [MEDIUM] Trigger-create input can still fall back to raw JSON preview
Location: crates/ironclaw_reborn_composition/src/projection/display_preview.rs:591-594
The new trigger_create redaction only applies when trigger_create_input_summary returns Some. If the model sends an invalid but expected malformed shape, such as the parser-style {"operation":"parse","data":{...}} wrapper that the trigger schema explicitly rejects, there is no top-level name or schedule, so this branch falls through to the generic JSON summary. That generic fallback will expose nested routine configuration such as prompt or cron expression in the display preview/failure card, undermining the new guarantee that trigger creation hides internal configuration. For matched trigger_create capability IDs, return a safe generic routine summary instead of falling through when the specialized summary is empty, and add a regression test for a malformed/wrapped trigger_create input.
Developer follow-up
After fixing this feedback:
- Push the fix to this PR branch.
- Re-run this reviewer with
@ironloopai review --agent reviewerif you only changed this reviewer's findings. - Re-run all reviewers with
@ironloopai reviewwhen the fix may affect multiple areas. - Use
@ironloopai statusto check queued/running/completed/failed/superseded state while reviewers run.
|
🚅 Deployed to the ironclaw-pr-5909 environment in ironclaw-ci-preview
|
🔧 IronLoop Resolve StatusIssue: #5909 Current resolve:
Recent activityEach row is one developer job. Phase details below belong to that job.
Phase log: ironloop/small-fix-resolver (
Available commands
Run metadataAdmission: webhook accepted the request and IronLoop persisted developer state before this projection. |
|
@ironloopai resolve Address all unresolved review feedback and fix the current failing CI checks. |
|
@ironloopai resolve Address all unresolved review feedback and fix the current failing CI checks after the base update. |
Coverage ratchetReborn integration-tier coverageLine coverage (Reborn crates): 85.27% — 292934 / 343552 lines Per-crate breakdown (63 crates, lowest-covered first)
This table itself is informational and never gates the PR on its own — not the percentage, not the per-crate holes, not the 0-coverage callout. A separate coverage ratchet (dry-run until enforce=true; see tests/integration/coverage-floor.toml) can fail the build on specific configured floors. Exemptions (3 entry/entries excluded from the accounting above)
|
|
@ironloopai review |
There was a problem hiding this comment.
✅ IronLoop Review: reviewer
Review at a glance
| Verdict | Blocking | Notes | Inline | Head |
|---|---|---|---|---|
| ✅ Approved | 0 | 0 | 0 | a6f2563f15e3 |
Head: a6f2563f15e3fe25a80a7ebd43f626475160e415
Next: No reviewer action needed.
Run details
Status: Current
Needs human: no
Needs validation: no
Summary
No concrete blocking issues found. The change scopes trigger_create display-preview formatting to redacted routine-focused fields and adds focused regression coverage for canonical and wrapped inputs.
Findings
None.
Developer follow-up
After fixing this feedback:
- Push the fix to this PR branch.
- Re-run this reviewer with
@ironloopai review --agent reviewerif you only changed this reviewer's findings. - Re-run all reviewers with
@ironloopai reviewwhen the fix may affect multiple areas. - Use
@ironloopai statusto check queued/running/completed/failed/superseded state while reviewers run.
It still seems like there are problems. |
italic-jinxin
added
human-verified
|
PR #5909 did not fully resolve the issue because it addressed only the open pr #6038 to resolve it. |
This branch was successfully deployed
3 participants
Summary
Validation
git diff --checkgit diff --check HEAD~1 HEADcargo fmt --checkand targeted cargo test becausecargois not installed in this runtime.Closes #5707.
Opened by IronLoop after verifying the local implementation branch.