-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(reborn): Slack delivery routing + tool-surface overhaul (identity, status, errors, threads, membership) #5898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6f973f6
fix(reborn): make Slack automations deliver to the right place, with …
BenKurrek 46ba560
fix(reborn): update stale description pins in CI contract tests; cap …
BenKurrek f414ec2
fix(reborn): address CodeRabbit review — carry error causes, canonica…
BenKurrek 558b581
fix(triggers): forbid laundering self-sends behind pinned conversatio…
BenKurrek e05cf62
Merge remote-tracking branch 'origin/main' into salty-produce
BenKurrek 9eb0c47
test(composition): CI-load headroom for trigger-delivery hook e2e waits
BenKurrek 0151f2e
fix(slack): tool overhaul — identity, status, structured errors, thre…
BenKurrek 836483e
Merge remote-tracking branch 'origin/main' into salty-produce
BenKurrek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...ronclaw_first_party_extensions/assets/slack/prompts/slack/get_thread_replies.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Read the replies of one Slack thread via conversations.replies (channel + the parent message's thread_ts). Conversation history only carries thread parents; use this to read the thread content itself. | ||
|
|
||
| The host selects this operation from the capability id. Provide only the parameters described by the input schema; do not include an action field. |
2 changes: 2 additions & 0 deletions
2
crates/ironclaw_first_party_extensions/assets/slack/prompts/slack/send_message.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| Send a message as you to a channel or DM. The message appears to come from your account. | ||
|
|
||
| Use it when messaging someone or posting somewhere is the task the user asked for. The run's final reply (including routine/trigger results) is delivered to the requesting user automatically; do not use this capability to deliver your reply or a routine/trigger result back to them — it would arrive twice. | ||
|
|
||
| The host selects this operation from the capability id. Provide only the parameters described by the input schema; do not include an action field. |
3 changes: 3 additions & 0 deletions
3
crates/ironclaw_first_party_extensions/assets/slack/prompts/slack/whoami.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Resolve who the connected Slack account is (auth.test plus a best-effort users.info display-name lookup). | ||
|
|
||
| The host selects this operation from the capability id. Provide only the parameters described by the input schema; do not include an action field. |
6 changes: 3 additions & 3 deletions
6
..._first_party_extensions/assets/slack/schemas/slack/get_conversation_history.input.v1.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Cover populated WASM summaries at the conversion boundary.
Line 155 is the new forwarding path, but the tests only exercise
safe_summary: None. Assert that a populated sanitized WASM summary reachesCapabilityInvocationError::Dispatch; otherwise this model-visible contract can regress unnoticed.Proposed test
As per path instructions, “Test through the caller,” so cover the populated value at this conversion boundary.
🤖 Prompt for AI Agents
Source: Path instructions