fix: enable libsql remote + tls features for Turso cloud sync - #587
Conversation
The onboard wizard offers Turso cloud sync, but the libsql dependency is compiled without the `remote` and `tls` features, causing a panic at runtime when LIBSQL_URL is set: "The `tls` feature is disabled, you must provide your own http connector" This adds the missing features to the libsql dependency.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue preventing Turso cloud synchronization from functioning correctly. By enabling the necessary Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly resolves a runtime panic that occurs when using the Turso cloud sync feature. The issue was caused by the libsql dependency missing the remote and tls features required for remote database connections. By adding these features in Cargo.toml, the change directly enables the intended functionality. The fix is accurate and well-contained.
Note: Security Review has been skipped due to the limited scope of the PR.
…#587) The onboard wizard offers Turso cloud sync, but the libsql dependency is compiled without the `remote` and `tls` features, causing a panic at runtime when LIBSQL_URL is set: "The `tls` feature is disabled, you must provide your own http connector" This adds the missing features to the libsql dependency.
…#587) The onboard wizard offers Turso cloud sync, but the libsql dependency is compiled without the `remote` and `tls` features, causing a panic at runtime when LIBSQL_URL is set: "The `tls` feature is disabled, you must provide your own http connector" This adds the missing features to the libsql dependency.
Summary
The onboard wizard offers Turso cloud sync (
Enable Turso cloud sync (remote replica)?), but the libsql dependency is compiled without theremoteandtlsfeatures.This causes a panic at runtime when
LIBSQL_URLis set:Fix