Skip to content

docs: require IronLoop agents to validate fixability - #5862

Merged
hanakannzashi merged 2 commits into
mainfrom
codex/ironloop-preflight-fixability
Jul 9, 2026
Merged

hanakannzashi merged 2 commits into
mainfrom
codex/ironloop-preflight-fixability

Conversation

@hanakannzashi

Copy link
Copy Markdown
Contributor

Summary

  • Require the small-fix implementer to check whether an issue is valid, reproducible, and safely fixable before editing.
  • Require the small-fix resolver to check whether review feedback is valid, still applicable, and safely fixable before editing.
  • Explicitly allow both agents to refuse speculative fixes and explain when an issue or feedback may be wrong, expected behavior, already fixed, stale, or unclear.

Validation

  • git diff --check

Closes #5861

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@ironloopai

ironloopai Bot commented Jul 9, 2026 •

Copy link
Copy Markdown
Contributor

🔎 IronLoop Review Status

Head: b72e0b382299d983939281e1d03ce979a879eef1
Result: One or more review results were superseded by a newer PR head.
Next: Run @ironloopai review on the latest PR head.
Updated: 2026-07-09T06:28:41.362Z

Current reviewers:

Reviewer State Verdict Findings Last update
ironloop/common-reviewer (reviewer) Superseded N/A N/A 2026-07-09T06:28:41.355Z
Reviewer summaries
Reviewer Detail
ironloop/common-reviewer (reviewer) Superseded by a newer PR head. New head: b72e0b3. Previous verdict: Approved.
Recent activity
Time Reviewer State Detail
2026-07-09T06:16:23.663Z ironloop/common-reviewer (reviewer) Queued Waiting for this reviewer lane to become available.
2026-07-09T06:16:23.666Z ironloop/common-reviewer (reviewer) Queued Added to the local review work handoff.
2026-07-09T06:16:24.450Z ironloop/common-reviewer (reviewer) Started Reviewer worker started attempt 1.
2026-07-09T06:16:35.807Z ironloop/common-reviewer (reviewer) Workspace ready Prepared isolated checkout (merge_ref) at 5adf91e.
2026-07-09T06:17:40.441Z ironloop/common-reviewer (reviewer) Superseded Old-head reviewer is still running after newer head b72e0b3 replaced it. Codex is reviewing; process live; elapsed 1m 15s; timeout in 18m 45s; last heartbeat 2026-07-09T06:17:40.441Z. Codex emitted stderr output at 2026-07-09T06:17:33.001Z.
2026-07-09T06:17:49.137Z ironloop/common-reviewer (reviewer) Result captured Approved; 0 blocking findings.
2026-07-09T06:17:49.137Z ironloop/common-reviewer (reviewer) Completed Review completed and terminal status was persisted.
2026-07-09T06:28:41.355Z ironloop/common-reviewer (reviewer) Superseded A newer PR head replaced this review (b72e0b3).
Available commands
  • @ironloopai help
  • @ironloopai agents
  • @ironloopai review
  • @ironloopai review --agent <agent>
  • @ironloopai status
Run metadata

Admission: webhook accepted the request and IronLoop persisted reviewer state before this projection.

@railway-app
railway-app Bot temporarily deployed to ironclaw-ci-preview / ironclaw-pr-5862 July 9, 2026 06:16 Destroyed
@github-actions github-actions Bot added scope: docs Documentation size: XS < 10 changed lines (excluding docs) risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e32c63ed-bcfa-4fa8-828b-400c68afe8c3

📥 Commits

Reviewing files that changed from the base of the PR and between e605f78 and b72e0b3.

📒 Files selected for processing (1)
  • .ironloop/agents/small-fix-resolver/AGENTS.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated agent instructions to add explicit pre-edit checks for whether feedback is valid, still applicable, reproducible, and safely fixable.
    • Strengthened criteria for accepting an automated repair, including safeguards against ambiguity, risky scope, secret/production access, migrations, broad architecture changes, and policy-breaking updates.
    • Clarified that speculative or partially understood work must be refused, with human clarification requested when issues are stale, unclear, non-reproducible, or likely require a larger, multi-step effort.

Walkthrough

Two .ironloop agent instruction files are updated to require pre-edit validation before making changes and to broaden the criteria for refusing speculative, ambiguous, stale, or risky issue repairs.

Changes

Agent instruction updates

Layer / File(s) Summary
Small-fix implementer instructions
.ironloop/agents/small-fix-implementer/AGENTS.md
Adds a pre-edit check for issue validity, reproducibility, and fixability, then replaces acceptance logic with a stricter checklist that rejects ambiguous, broad, or risky changes.
Small-fix resolver instructions
.ironloop/agents/small-fix-resolver/AGENTS.md
Adds a pre-edit check for whether each review thread is still applicable and safely fixable, and expands the repair checklist plus stop guidance for broad, stale, invalid, or risky feedback.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • nearai/ironclaw#5580: Prior update to the same .ironloop/agents/small-fix-implementer/AGENTS.md and .ironloop/agents/small-fix-resolver/AGENTS.md playbooks tightening pre-edit and acceptance criteria.
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description has a summary and validation, but omits required template sections like Change Type, Security Impact, and Rollback Plan. Fill in the missing template sections, especially Change Type, Linked Issue, Security Impact, Blast Radius, and Rollback Plan.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the agent fixability validation change and uses Conventional Commits style.
Linked Issues check ✅ Passed The changes update both small-fix agent prompts to require pre-edit validity, applicability, reproducibility, and safe-fixability checks.
Out of Scope Changes check ✅ Passed No unrelated code or instruction changes appear beyond the .ironloop small-fix agent prompt updates requested by #5861.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ironloopai ironloopai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ IronLoop Review: reviewer

Review at a glance

Verdict Blocking Notes Inline Head
✅ Approved 0 0 0 e605f78e140e

Head: e605f78e140e1421a23a5c58061dbaade9b66da2
Next: No reviewer action needed.

Run details

Status: Current
Needs human: no
Needs validation: no

Summary

No blocking issues found. The PR only tightens the small-fix implementer/resolver agent instructions to validate issue/review feedback validity and fixability before editing.

Findings

None.

Developer follow-up

After fixing this feedback:

  1. Push the fix to this PR branch.
  2. Re-run this reviewer with @ironloopai review --agent reviewer if you only changed this reviewer's findings.
  3. Re-run all reviewers with @ironloopai review when the fix may affect multiple areas.
  4. Use @ironloopai status to check queued/running/completed/failed/superseded state while reviewers run.

@railway-app
railway-app Bot temporarily deployed to ironclaw-ci-preview / ironclaw-pr-5862 July 9, 2026 06:28 Destroyed
@railway-app

railway-app Bot commented Jul 9, 2026

Copy link
Copy Markdown

🚅 Deployed to the ironclaw-pr-5862 environment in ironclaw-ci-preview

Service Status Web Updated (UTC)
ironclaw ✅ Success (View Logs) Web Jul 9, 2026 at 6:28 am

@hanakannzashi
hanakannzashi added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit b96713f Jul 9, 2026
42 checks passed
@hanakannzashi
hanakannzashi deleted the codex/ironloop-preflight-fixability branch July 9, 2026 11:46

This branch was successfully deployed

No deployments
ironclaw-ci-preview / ironclaw-pr-5862 — b72e0b38 Deployed Jul 9, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules scope: docs Documentation size: XS < 10 changed lines (excluding docs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require IronLoop fix agents to validate issue fixability before editing

2 participants