Repository navigation
feat(traces): Trace Commons instance enrollment CLI + hosted-user account login links #5858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9ff23b6
feat(traces): ironclaw-reborn traces enroll-instance — admin instance…
zmanian 1b94f15
feat(webui): Open Trace Commons account from the WebUI — hosted-user …
zmanian ee60b3a
Address automated review: absolutize login-link URL, fix noopener han…
zmanian f911ae9
Address local Codex review: pin login-link URL to issuer origin, sink…
zmanian c6466d6
Client-side defense in depth: refuse non-http(s) minted login URLs
zmanian b056928
Scoped-only user opt-out: never disable the instance enrollment for o…
zmanian adffaa5
Align enroll-instance clap help with scoped-only opt-out semantics
zmanian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
ironclaw-reborn traces enroll-instanceis run withIRONCLAW_REBORN_HOMEset or the default Reborn home (~/.ironclaw/reborn) differs from the legacy base, this line still writes the policy and device key underironclaw_base_dir()(IRONCLAW_BASE_DIR/~/.ironclaw). That ignores the Reborn CLI state root and violates the crate contract incrates/ironclaw_reborn_cli/AGENTS.mdto useIRONCLAW_REBORN_HOME, so an admin can enroll the wrong/legacy state tree instead of the intended Reborn instance.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified against the runtime and keeping
ironclaw_base_dir()deliberately — this one's a false positive at the behavior level. The ENTIRE trace-commons subsystem lives underIRONCLAW_BASE_DIR/~/.ironclaw/trace_contributions: the runtime resolver the serve loop uses (resolve_trace_credentials→ironclaw_common::paths::ironclaw_base_dir()), the capture gate and flush worker inironclaw_reborn_composition, the existingtraces opt-in/opt-out/status/queue commands, and the agent capabilities. Ifenroll-instancewrote underIRONCLAW_REBORN_HOMEinstead, the enrollment would land where the resolver never reads and the feature would silently not work.IRONCLAW_REBORN_HOMEcurrently scopes providers.json and extension state, not trace contributions — the AGENTS.md line guards against writing v1 state, andtrace_contributions/is the shared trace-commons state root the Reborn runtime itself consumes. If the subsystem migrates to the Reborn home it must migrate wholesale (resolver + all commands + worker) in one change, not one command at a time; happy to file that as a tracked follow-up if the migration is wanted.