Skip to content

[codex] Update Reborn nightly tests for pairing flow #5714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serrrfirat merged 1 commit into from
Jul 6, 2026
Merged

[codex] Update Reborn nightly tests for pairing flow #5714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 46 additions & 31 deletions tests/e2e/scenarios/test_reborn_webui_v2_legacy_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ async def test_reborn_legacy_extensions_install_auth_url_requires_https(
await harness["context"].close()


async def test_reborn_legacy_install_setup_required_channel_opens_configure_modal(
async def test_reborn_legacy_install_setup_required_channel_opens_pairing_modal(
reborn_v2_server, reborn_v2_browser
):
setup_channel = {
Expand Down Expand Up @@ -785,9 +785,12 @@ async def test_reborn_legacy_install_setup_required_channel_opens_configure_moda
await expect(
page.get_by_role("heading", name="Configure Slack Channel")
).to_be_visible(timeout=5000)
await expect(page.get_by_text("Enter the Slack channel token.")).to_be_visible()
await expect(page.get_by_text("Slack bot token")).to_be_visible()
await expect(page.locator('input[type="password"]')).to_have_count(1)
modal = page.get_by_label("Configure Slack Channel")
await expect(page.get_by_text("Enter the code from the channel")).to_be_visible()
await expect(modal.get_by_label("Enter pairing code…")).to_be_visible()
await expect(modal.get_by_role("button", name="Connect")).to_be_disabled()
await expect(page.get_by_text("Slack bot token")).to_have_count(0)
await expect(page.locator('input[type="password"]')).to_have_count(0)
assert harness["setup_submit_requests"] == []
finally:
await harness["context"].close()
Expand Down Expand Up @@ -1196,7 +1199,7 @@ async def test_reborn_legacy_activate_auth_url_accepts_uppercase_https(
await harness["context"].close()


async def test_reborn_legacy_channel_config_label_depends_on_authentication(
async def test_reborn_legacy_channel_connect_label_depends_on_authentication(
reborn_v2_server, reborn_v2_browser
):
harness = await _open_mocked_extensions_page(
Expand Down Expand Up @@ -1225,27 +1228,27 @@ async def test_reborn_legacy_channel_config_label_depends_on_authentication(
await expect(unauthenticated).to_be_visible(timeout=5000)
await _open_card_menu(unauthenticated)
await expect(
page.get_by_role("menuitem", name="Configure", exact=True)
page.get_by_role("menuitem", name="Connect", exact=True)
).to_have_count(1)
await expect(
page.get_by_role("menuitem", name="Reconfigure", exact=True)
page.get_by_role("menuitem", name="Reconnect", exact=True)
).to_have_count(0)

await page.mouse.click(8, 8)
authenticated = _card_by_title(page, "Authenticated Label Channel")
await expect(authenticated).to_be_visible(timeout=5000)
await _open_card_menu(authenticated)
await expect(
page.get_by_role("menuitem", name="Reconfigure", exact=True)
page.get_by_role("menuitem", name="Reconnect", exact=True)
).to_have_count(1)
await expect(
page.get_by_role("menuitem", name="Configure", exact=True)
page.get_by_role("menuitem", name="Connect", exact=True)
).to_have_count(0)
finally:
await harness["context"].close()


async def test_reborn_legacy_channel_setup_required_has_single_configure_action(
async def test_reborn_legacy_channel_setup_required_has_single_connect_action(
reborn_v2_server, reborn_v2_browser
):
harness = await _open_mocked_extensions_page(
Expand All @@ -1265,19 +1268,20 @@ async def test_reborn_legacy_channel_setup_required_has_single_configure_action(
card = _card_by_title(page, "Label Channel")
await expect(card).to_be_visible(timeout=5000)

await expect(card.get_by_role("button", name="Configure")).to_have_count(1)
await expect(card.get_by_role("button", name="Connect")).to_have_count(1)
await _open_card_menu(card)
await expect(page.get_by_role("menuitem", name="Setup", exact=True)).to_have_count(
0
)
await expect(
page.get_by_role("menuitem", name="Configure", exact=True)
).to_have_count(0)
await expect(page.get_by_role("menuitem", name="Connect", exact=True)).to_have_count(0)
finally:
await harness["context"].close()


async def test_reborn_legacy_channel_reconfigure_opens_modal_without_activate(
async def test_reborn_legacy_channel_reconnect_opens_pairing_modal_without_activate(
reborn_v2_server, reborn_v2_browser
):
harness = await _open_mocked_extensions_page(
Expand Down Expand Up @@ -1318,11 +1322,13 @@ async def test_reborn_legacy_channel_reconfigure_opens_modal_without_activate(
await expect(card).to_be_visible(timeout=5000)

await _open_card_menu(card)
await page.get_by_role("menuitem", name="Reconfigure", exact=True).click()
await page.get_by_role("menuitem", name="Reconnect", exact=True).click()
await expect(page.get_by_role("heading", name="Configure Label Channel")).to_be_visible(
timeout=5000
)
await expect(page.get_by_text("Bot token")).to_be_visible()
await expect(page.get_by_text("Enter the code from the channel")).to_be_visible()
await expect(page.get_by_label("Enter pairing code…")).to_be_visible()
await expect(page.get_by_text("Bot token")).to_have_count(0)
assert harness["activate_requests"] == []
finally:
await harness["context"].close()
Expand Down Expand Up @@ -2043,7 +2049,7 @@ async def test_reborn_legacy_configure_modal_enter_key_submits(
await harness["context"].close()


async def test_reborn_legacy_telegram_token_configure_preserves_token_characters(
async def test_reborn_legacy_telegram_pairing_code_preserves_token_characters(
reborn_v2_server, reborn_v2_browser
):
token = "123456789:ABCdef_GHI-jkl_mnop-QRSTuvwxyz"
Expand Down Expand Up @@ -2072,32 +2078,41 @@ async def test_reborn_legacy_telegram_token_configure_preserves_token_characters
)
try:
page = harness["page"]
redeem_requests: list[dict] = []

async def handle_redeem(route):
redeem_requests.append(json.loads(route.request.post_data or "{}"))
await route.fulfill(
status=200,
content_type="application/json",
body=json.dumps(
{
"provider": "telegram",
"provider_user_id": "123456789",
}
),
)

await page.route("**/api/webchat/v2/extensions/pairing/redeem", handle_redeem)

card = _card_by_title(page, "Telegram")
await expect(card).to_be_visible(timeout=5000)
await card.get_by_role("button", name="Configure").click()
await card.get_by_role("button", name="Connect").click()

await expect(
page.get_by_role("heading", name="Configure Telegram")
).to_be_visible(timeout=5000)
await expect(page.get_by_text("Telegram Bot Token")).to_be_visible()
await page.locator('input[type="password"]').first.fill(token)
await page.get_by_role("button", name="Save").click()
modal = page.get_by_label("Configure Telegram")
await expect(page.get_by_text("Enter the code from the channel")).to_be_visible()
await modal.get_by_label("Enter pairing code…").fill(token)
await modal.get_by_role("button", name="Connect").click()

await expect(
page.get_by_role("heading", name="Configure Telegram")
).to_have_count(0)
assert harness["setup_submit_requests"] == [
{
"package_id": "telegram",
"body": {
"action": "submit",
"payload": {
"secrets": {"telegram_bot_token": token},
"fields": {},
},
},
}
]
assert redeem_requests == [{"channel": "telegram", "code": token}]
assert harness["activate_requests"] == ["telegram"]
assert harness["setup_submit_requests"] == []
finally:
await harness["context"].close()

Expand Down
13 changes: 8 additions & 5 deletions tests/e2e/scenarios/test_reborn_webui_v2_legacy_pending_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ async def handle_delayed_send(route, _payload, fulfill_json):
await harness["context"].close()


async def test_reborn_legacy_sidebar_refresh_keeps_active_thread_outside_summary_window(
async def test_reborn_legacy_sidebar_cache_keeps_active_thread_outside_summary_window(
reborn_v2_server, reborn_v2_browser
):
async def handle_successful_send(route, _payload, fulfill_json):
Expand Down Expand Up @@ -519,10 +519,6 @@ async def handle_successful_send(route, _payload, fulfill_json):
has_text="Summary refresh should keep this Reborn thread"
)
).to_have_count(1, timeout=5000)
await _wait_for_request_count(
harness["thread_requests"],
before_refresh_requests,
)

assert len(harness["send_requests"]) == 1
assert (
Expand All @@ -531,11 +527,18 @@ async def handle_successful_send(route, _payload, fulfill_json):
)
assert await page.evaluate("() => location.pathname") == f"/v2/chat/{THREAD_ID}"
await expect(composer).to_be_visible(timeout=5000)
await expect(
page.locator(SEL_V2["sidebar"]).get_by_role("button").filter(
has_text="Summary refresh should keep this Reborn thread"
)
).to_be_visible(timeout=5000)
await expect(
page.locator(SEL_V2["sidebar"]).get_by_role("button").filter(
has_text="Newest summary thread"
)
).to_be_visible(timeout=5000)
await page.wait_for_timeout(250)
assert len(harness["thread_requests"]) == before_refresh_requests
finally:
await harness["context"].close()

Expand Down
Loading