Repository navigation
fix(reborn): clear chat sidebar highlight off chat routes - #5592
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds ChangesRoute-aware sidebar active thread
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant Router
participant GatewayLayout
participant activeRouteThreadIdFromPath
participant routeSynchronizedThreadsState
participant Sidebar
Router->>GatewayLayout: location.pathname
GatewayLayout->>activeRouteThreadIdFromPath: parse(pathname)
activeRouteThreadIdFromPath-->>GatewayLayout: threadId or null
GatewayLayout->>routeSynchronizedThreadsState: (threadsState, pathname)
routeSynchronizedThreadsState-->>GatewayLayout: routeThreadsState
GatewayLayout->>Sidebar: threadsState=routeThreadsState
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a utility function activeSidebarThreadIdFromPath to extract the active thread ID from the current location pathname, updating the Sidebar component to use it. Feedback suggests robustifying this utility by stripping query parameters and hash fragments from the path before parsing, along with adding corresponding test cases to verify this behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@claude review |
This comment was marked as resolved.
This comment was marked as resolved.
|
🚅 Deployed to the ironclaw-pr-5592 environment in ironclaw-ci-preview
|
Reborn integration-tier coverageLine coverage (Reborn crates): 16.85% — 10833 / 64279 lines Per-crate breakdown (11 crates, lowest-covered first)
This signal is informational: coverage never gates the PR — not the percentage, not the per-crate holes, not the 0-coverage callout. |
IronLoop Review StatusHead: Current reviewers:
Recent activity:
Commands:
|
Summary
/chat/:threadId.Linked Issue
Closes #5556
Validation
node --check crates/ironclaw_webui_v2/static/js/lib/sidebar-active-thread.jsnode --check crates/ironclaw_webui_v2/static/js/components/sidebar.jsnode --test crates/ironclaw_webui_v2/static/js/lib/sidebar-active-thread.test.mjsnode --test crates/ironclaw_webui_v2/static/js/hooks/useSidebar.test.mjs crates/ironclaw_webui_v2/static/js/app/routes.test.mjsIRONCLAW_WEBUI_V2_DIST_DIR=/tmp/ironclaw-webui-v2-dist-check npm run buildgit diff --check HEAD^ HEADSecurity Impact
No security-sensitive behavior changes. UI selection state only.
Database Impact
No schema or migration changes.
Blast Radius
Limited to WebChat v2 sidebar presentation and a small route parsing helper.
Rollback Plan
Revert this PR to restore the previous sidebar selection behavior.