test(reborn): int-tier coverage for trigger-management verbs (T0-TRIGGERS)

[henrypark133]

What

Adds reborn_group_triggers, a group integration test driving the five
trigger-management verbs (trigger_create/list/pause/resume/remove)
through the real agent-loop turn → capability dispatch path (product
workflow → agent loop → real ironclaw_llm chain → first-party handler →
trigger repo). This is the only int-tier coverage of the pause/resume/
remove/list handlers — pause/resume are dispatched through the real
capability path nowhere else in the repo (only repo-level unit tests in
repository_contract.rs and input-parse unit tests in trigger_management.rs).

Scenario

• Thread A: create a one-shot Once{at} trigger + list it; read back the
  server-minted trigger_id (a static script can't know it ahead of time).
• Thread B (different conversation, same trigger scope over the shared repo):
  pause → resume → remove by that id, then list to confirm removal —
  which also proves cross-thread trigger persistence.

Consolidate, don't proliferate

Deliberately does not re-cover work already owned elsewhere:

• one-shot Once fire → Completed derivation → crates/ironclaw_reborn_composition/tests/trigger_poller_e2e.rs (real poller) + crates/ironclaw_triggers/tests/repository_contract.rs.
• trigger → Slack outbound delivery → the trigger-delivery-hook tests in crates/ironclaw_reborn_composition/src/slack_host_beta.rs.

TODO blocks in main.rs record the deferred triggered-turn coverage
(approval gate mid-fire, ScheduledTrigger origin propagation, outbound sink),
which needs a not-yet-existing harness seam to submit a turn on the
TrustedTriggerFireSubmitter path — do not hand-roll a weaker stand-in.

Seams (test-support only — no production-crate changes)

• HostRuntimeCapabilityHarness::trigger_management_tools() → pub(crate).
• RebornIntegrationGroup::triggers() mirroring extension_lifecycle().
• RebornIntegrationHarness::tool_result_output(capability_id) — returns the
  parsed JSON of the most-recent recorded capability result, to read a
  server-minted field a static script can't reference.

Verification

• cargo test --features libsql --test reborn_group_triggers → green.
• cargo clippy --all-features --tests → 0 warnings.
• Mutation-verified (each turns the relevant assertion RED for the right
  reason, then reverted): resume dispatch arm Scheduled→Paused; libsql
  remove_scoped_trigger made a no-op.
• Plan + post-impl reviewed via Sonnet review lenses (approach / local-patterns /
  maintainability / bugs); findings addressed.

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b25be39b-af3d-42f3-ad30-bd1ca69858a8

📥 Commits

Reviewing files that changed from the base of the PR and between 430cd95 and eab194e.

📒 Files selected for processing (7)

• Cargo.toml
• tests/reborn_group_triggers/main.rs
• tests/reborn_group_triggers/scenario_verbs_lifecycle.rs
• tests/support/reborn/CLAUDE.md
• tests/support/reborn/assertions.rs
• tests/support/reborn/group.rs
• tests/support/reborn/harness.rs

---

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • Added triggers as a new integration-test group constructor to enable trigger-management capabilities for end-to-end runs.
• Tests
  • Added a new integration test target and scenario exercising the trigger verb lifecycle (create/list/pause/resume/remove) concurrently against a shared trigger repository.
• Documentation
  • Updated integration test documentation with the new triggers constructor and a helper to read the most recent capability result output for a given capability id.

Walkthrough

Adds a new reborn_group_triggers integration test target, trigger-group harness support, capability-output lookup, and an end-to-end trigger lifecycle scenario.

Changes

Trigger group test suite

Layer / File(s)	Summary
Harness support tests/support/reborn/group.rs, tests/support/reborn/harness.rs, tests/support/reborn/assertions.rs, tests/support/reborn/CLAUDE.md	Adds RebornIntegrationGroup::triggers(), wires trigger_management_tools(), exposes tool_result_output, and updates the Reborn test docs.
Trigger lifecycle test Cargo.toml, tests/reborn_group_triggers/main.rs, tests/reborn_group_triggers/scenario_verbs_lifecycle.rs	Registers the new test binary and implements the Tokio scenario that runs create/list/pause/resume/remove against the shared trigger scope.

Estimated code review effort: 2 (Simple) | ~15 minutes

Sequence Diagram(s)

sequenceDiagram
  participant TokioTest
  participant RebornIntegrationGroup
  participant ScenarioVerbsLifecycle
  participant TriggerCapabilities

  TokioTest->>RebornIntegrationGroup: triggers()
  TokioTest->>ScenarioVerbsLifecycle: run(&g)
  ScenarioVerbsLifecycle->>TriggerCapabilities: builtin.trigger_create
  ScenarioVerbsLifecycle->>TriggerCapabilities: builtin.trigger_list
  ScenarioVerbsLifecycle->>TriggerCapabilities: builtin.trigger_pause
  ScenarioVerbsLifecycle->>TriggerCapabilities: builtin.trigger_resume
  ScenarioVerbsLifecycle->>TriggerCapabilities: builtin.trigger_remove
  ScenarioVerbsLifecycle->>TriggerCapabilities: builtin.trigger_list
  ScenarioVerbsLifecycle-->>TokioTest: ScenarioReport::assert_all_passed()

Loading

Possibly related PRs

• nearai/ironclaw#5131: Introduces trigger pause/resume behavior exercised by the new lifecycle scenario.
• nearai/ironclaw#5432: Updates test discovery to pick up the new tests/reborn_group_triggers/main.rs target.

Suggested reviewers: think-in-universe

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers scope and verification, but it omits most required template sections such as Change Type, Linked Issue, Security, DB, and Rollback.	Rewrite the PR body to match the template and fill in the missing sections: Change Type, Linked Issue, Validation, Security Impact, Trust-Boundary Checklist, Database Impact, Blast Radius, Rollback Plan, Review Follow-Through, and Review track.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses Conventional Commits style and accurately describes the trigger-management test coverage added here.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request introduces a new integration test suite for trigger-management verbs, including trigger_create, trigger_list, trigger_pause, trigger_resume, and trigger_remove. It adds the reborn_group_triggers test binary, implements the verbs_lifecycle scenario to verify cross-thread persistence and management of triggers, and exposes the necessary harness and group builders (RebornIntegrationGroup::triggers()) along with a new assertion helper tool_result_output to fetch the output of the most recent capability result. I have no feedback to provide as there are no review comments and the implementation is clean and well-documented.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[Copilot]

Pull request overview

Adds an int-tier “group” integration test that exercises the full trigger-management verb lifecycle through the real agent-loop turn → capability dispatch path, and introduces small test-support seams to enable that coverage (shared runtime, auto-approve, and reading server-minted outputs like trigger_id).

Changes:

• Add reborn_group_triggers group integration test (two threads sharing one trigger repo) covering trigger_create/list/pause/resume/remove.
• Expose a trigger-management harness constructor (trigger_management_tools) and wire a new RebornIntegrationGroup::triggers() builder path.
• Add RebornIntegrationHarness::tool_result_output(capability_id) to return parsed JSON output of the most recent recorded capability result.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/support/reborn/harness.rs	Makes trigger-management harness constructor pub(crate) so group builder can reuse it.
tests/support/reborn/group.rs	Adds RebornIntegrationGroup::triggers() and builder support for trigger-management capabilities.
tests/support/reborn/CLAUDE.md	Documents the new group type in the test-support guide.
tests/support/reborn/assertions.rs	Adds tool_result_output helper to return recorded tool output JSON.
tests/reborn_group_triggers/main.rs	New group test binary orchestrating the trigger lifecycle scenario(s).
tests/reborn_group_triggers/scenario_verbs_lifecycle.rs	Scenario implementing create/list in thread A and pause/resume/remove/list in thread B.
Cargo.toml	Registers the new reborn_group_triggers test target.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[railway-app]

🚅 Deployed to the ironclaw-pr-5482 environment in ironclaw-ci-preview

Service	Status	Web	Updated (UTC)
ironclaw	✅ Success (View Logs)	Web	Jul 1, 2026 at 8:51 pm

[github-actions]

⚠️ 5 Reborn crate(s) have 0 int-tier coverage (target: 0) — ironclaw_reborn_config, ironclaw_reborn_identity, ironclaw_reborn_traces, ironclaw_webui_v2, ironclaw_webui_v2_static

Reborn integration-tier coverage

Line coverage (Reborn crates): 14.87% — 9155 / 61547 lines

Per-crate breakdown (12 crates, lowest-covered first)

Crate	Line %	Covered / Total
ironclaw_reborn_config	0%	0 / 1142
ironclaw_reborn_identity	0%	0 / 237
ironclaw_reborn_traces	0%	0 / 6662
ironclaw_webui_v2	0%	0 / 2675
ironclaw_webui_v2_static	0%	0 / 110
ironclaw_reborn_event_store	0.73%	6 / 825
ironclaw_product_adapter_registry	5.62%	25 / 445
ironclaw_product_workflow	6.06%	562 / 9272
ironclaw_product_adapters	12.71%	283 / 2227
ironclaw_reborn_composition	20.89%	6414 / 30709
ironclaw_reborn	25.66%	1855 / 7229
ironclaw_product_context	71.43%	10 / 14

This signal is informational: coverage never gates the PR — not the percentage, not the per-crate holes, not the 0-coverage callout.

[henrypark133]

Code Review (multi-agent)

Intent: Add Reborn integration coverage for trigger-management verbs through the real agent-loop and capability-dispatch path.

Stats: 2 findings (from 3 raw, 2 after validation/filtering) across 2 files. Reviewers run: security, bugs, performance, tests, conventions, local-patterns, maintainability, approach. Reviewers failed: none. Body-only: 0.

Local Patterns

1. Low New assertion accessor is missing from the harness docs index (tests/support/reborn/assertions.rs:144-147, confidence 75) — anchor: tests/support/reborn/CLAUDE.md:146
tests/support/reborn/CLAUDE.md keeps a navigable list of the richer assertions.rs APIs, but the new tool_result_output helper is not added there. Future group-test authors following that local doc will still only see assert_tool_result_contains, even though this PR adds the value-returning accessor specifically for server-minted fields.

2. Nit Group test entrypoint drops the local _e2e suffix (tests/reborn_group_triggers/main.rs:31, confidence 75) — anchor: tests/reborn_group_memory/main.rs:25 and tests/reborn_group_extensions/main.rs:31
   The existing Reborn group binaries name their top-level tokio tests with the <domain>_group_e2e shape, but this new binary uses triggers_group. That makes it the only group binary missed by normal _group_e2e search or cargo-test filtering patterns.

Note: I did not duplicate the existing unresolved Copilot thread on trigger_id ownership in scenario_verbs_lifecycle.rs; that issue is already open on the current PR head.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

[henrypark133]

Code Review (multi-agent)

Intent: Add integration-tier Reborn trigger-management verb coverage through the agent-loop to capability dispatch path.

Stats: 0 findings (from 0 raw, 0 after dedup) across 0 files. Reviewers run: security, bugs, performance, tests, conventions, local-patterns, maintainability, approach. Reviewers failed: none. Body-only: 0.

No new actionable findings from this forced pass.

Live unresolved threads were checked before posting and not duplicated here, including the existing trigger_id move concern with the author's rebuttal and the existing harness-docs/index comment.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/support/reborn/assertions.rs`:
- Around line 140-199: `assert_tool_error` currently scans the entire thread
history instead of the per-thread baseline delta, which can produce stale or
cross-turn matches. Update `assert_tool_error` in `assertions.rs` to use the
same `[baseline..]` scoping pattern as the other assertion helpers, threading
the baseline history length through the harness if needed, and keep the
`ToolResultReferenceEnvelope`/`safe_summary` matching logic intact. Use the
existing `assert_tool_result_contains` and egress assertion patterns as the
reference for locating the baseline-sliced history handling.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4a897c23-99b9-4b5c-a112-863a775588b9

📥 Commits

Reviewing files that changed from the base of the PR and between 1ee59f8 and 6129395.

📒 Files selected for processing (7)

• Cargo.toml
• tests/reborn_group_triggers/main.rs
• tests/reborn_group_triggers/scenario_verbs_lifecycle.rs
• tests/support/reborn/CLAUDE.md
• tests/support/reborn/assertions.rs
• tests/support/reborn/group.rs
• tests/support/reborn/harness.rs

[coderabbitai]

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/support/reborn/assertions.rs`:
- Around line 140-199: `assert_tool_error` currently scans the entire thread
history instead of the per-thread baseline delta, which can produce stale or
cross-turn matches. Update `assert_tool_error` in `assertions.rs` to use the
same `[baseline..]` scoping pattern as the other assertion helpers, threading
the baseline history length through the harness if needed, and keep the
`ToolResultReferenceEnvelope`/`safe_summary` matching logic intact. Use the
existing `assert_tool_result_contains` and egress assertion patterns as the
reference for locating the baseline-sliced history handling.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4a897c23-99b9-4b5c-a112-863a775588b9

📥 Commits

Reviewing files that changed from the base of the PR and between 1ee59f8 and 6129395.

📒 Files selected for processing (7)

• Cargo.toml
• tests/reborn_group_triggers/main.rs
• tests/reborn_group_triggers/scenario_verbs_lifecycle.rs
• tests/support/reborn/CLAUDE.md
• tests/support/reborn/assertions.rs
• tests/support/reborn/group.rs
• tests/support/reborn/harness.rs

🛑 Comments failed to post (1)

tests/support/reborn/assertions.rs (1)

140-199: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

assert_tool_error scans full thread history, not the per-thread baseline delta.

The richer assertions.rs helpers are documented to operate on the [baseline..] delta per thread; this one deliberately doesn't, with an extensive comment flagging it as safe only for single-turn/single-tool-call harnesses and requiring baseline scoping before any multi-turn/group reuse. Since no caller in this PR (or visible elsewhere) exercises it from a multi-turn/group context yet, this is currently inert risk, but flagging since the two-thread trigger scenario in this same PR is exactly the kind of group-test surface that could accidentally reach for this helper next and hit stale/false-positive matches from thread A's history.

Based on path instructions: "The richer egress and tool-result assertions ... belong in assertions.rs and should operate on the per-thread baseline delta."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/support/reborn/assertions.rs` around lines 140 - 199,
`assert_tool_error` currently scans the entire thread history instead of the
per-thread baseline delta, which can produce stale or cross-turn matches. Update
`assert_tool_error` in `assertions.rs` to use the same `[baseline..]` scoping
pattern as the other assertion helpers, threading the baseline history length
through the harness if needed, and keep the
`ToolResultReferenceEnvelope`/`safe_summary` matching logic intact. Use the
existing `assert_tool_result_contains` and egress assertion patterns as the
reference for locating the baseline-sliced history handling.

Source: Path instructions

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.