Skip to content

ci(reborn): share one Rust cache across the closure (fix per-crate cache LRU eviction) #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serrrfirat merged 1 commit into from
Jun 21, 2026
Merged

ci(reborn): share one Rust cache across the closure (fix per-crate cache LRU eviction) #5118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/reborn-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,15 @@ jobs:
- name: Restore Rust cache
uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
with:
key: reborn-tests-${{ matrix.package }}
# ONE shared cache for all ~60 crate-test jobs instead of a per-crate
# key. Per-crate keys produced ~60 caches (registry + target each,
# ~0.4-0.7 GB), which blew far past GitHub's ~10 GB repo cache LRU and
# evicted each other — so most jobs hit "No cache found", re-downloaded
# the crates.io registry from cold, and were exposed to transient
# download flakes (mitigated separately by CARGO_NET_RETRY). A single
# shared key keeps the registry + shared-dep build in one small,
# always-resident entry, so the registry is downloaded once, not ~60x.
shared-key: reborn-tests-crates
# Keep saves to protected-branch and merge_group runs so the ~10 GB
# repo cache LRU is seeded by shared states, not arbitrary PR branches.
save-if: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event_name == 'merge_group' }}
Expand Down Expand Up @@ -285,7 +293,12 @@ jobs:
- name: Restore Rust cache
uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
with:
key: reborn-tests-root-${{ matrix.partition }}
# All 4 root partitions compile the *same* root-package build (they
# only run different test partitions), so one shared cache is strictly
# better than 4 per-partition copies (~1 GB each) — the cached target
# is fully valid for every partition, and it stops the 4 copies from
# crowding the shared LRU.
shared-key: reborn-tests-root
# Keep saves to protected-branch and merge_group runs so the ~10 GB
# repo cache LRU is seeded by shared states, not arbitrary PR branches.
save-if: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event_name == 'merge_group' }}
Expand Down
Loading