test(workspace): regression test for document_path in search results

[zmanian]

Summary

• Adds a regression test for the bug fixed in fix(workspace): thread document path through search results #503 / bug: memory search results link to chunk UUID instead of source file path #481: search results must carry the source document's file path through the RRF fusion pipeline, not the document UUID
• Tests FTS, vector, and hybrid match paths all preserve document_path
• Uses explicit file paths (notes/todo.md, journal/2024-01-15.md) and asserts they appear in the output

Test plan

• cargo test workspace::search::tests::test_rrf_propagates_document_path passes

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial regression test to safeguard against a previously identified bug in the search functionality. The test ensures that the system consistently propagates the correct file paths for documents through the reciprocal rank fusion (RRF) process, preventing a scenario where internal document identifiers (UUIDs) might erroneously replace user-friendly file paths in search results. This enhancement improves the robustness of the search system by validating the integrity of document metadata.

Highlights

• Regression Test Added: A new regression test has been introduced to address a bug (fixed in fix(workspace): thread document path through search results #503 / bug: memory search results link to chunk UUID instead of source file path #481) where search results incorrectly carried document UUIDs instead of file paths through the RRF fusion pipeline.
• Path Propagation Verification: The test specifically verifies that Full-Text Search (FTS), vector, and hybrid match paths all correctly preserve the document_path.
• Explicit Path Assertions: The test uses explicit file paths (e.g., notes/todo.md, journal/2024-01-15.md) and asserts their presence and correctness in the search output.

Changelog

• src/workspace/search.rs
  • Added a new test function test_rrf_propagates_document_path to verify correct document_path propagation in search results.
  • Introduced a helper function make_result_with_path for creating RankedResult instances with specified paths.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a valuable regression test to ensure that document_path is correctly propagated through the reciprocal rank fusion pipeline. The test covers full-text, vector, and hybrid search scenarios, and correctly asserts that file paths are preserved instead of being replaced by document UUIDs. The implementation is solid, and I've provided a suggestion to improve the clarity and robustness of an assertion in the new test, aligning with best practices for simpler, more reliable checks.