fix(reborn): clean Web Access setup copy - #4948
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Changesweb-access Onboarding Copy
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the onboarding next-step text for the 'web-access' extension in available_extensions.rs to remove the redundant installation instruction, simplifying it to only mention activation. A corresponding unit test was also added to verify this updated text. There are no review comments, and the changes look correct, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: Robert Yan <mstr.raphael@gmail.com>
…ivery (#5222) Triggered-run Slack delivery recorded `Failed` for runs that park in `BlockedApproval` / `BlockedAuth` awaiting the user's approval or re-auth and never resolve. After delivering the actionable gate/auth prompt, the delivery loop re-enters `wait_for_actionable_triggered` to handle the eventual transition to `Completed` (deliver the final reply, delete the stale OAuth prompt). When the user never acts — the common case — that re-wait polled to the 30-minute backstop and the wait-error arm recorded a generic `Failed`, clobbering the `Delivered` it had already earned (the outcome store overwrites blindly via `CasExpectation::Any`). Production evidence (logs.1782348290172): 23× "did not finish before Slack delivery timeout" in ~1.5h, all `outcome=Failed`; 21× `BlockedApproval`, 3× `BlockedAuth` (from `secret expired` → `AuthRequired` on google-calendar.list_events). Two runs traced exactly: `BlockedApproval` at 23:15:39 → timeout at 23:45:45 (30m06s); `BlockedAuth` at 23:30:24 → timeout at 00:00:29 (30m05s). Fix: in `deliver_triggered_run`, when the wait times out AND a blocked prompt was already delivered (`delivered_blocked_marker.is_some()`), the run is parked awaiting the user — a successful, terminal-for-delivery outcome. Record `Delivered` and return instead of polling on and recording `Failed`. This mirrors the live-run path's existing `RunWaitTimedOutAfterNotification` quiet- success semantics. The 30-minute backstop is preserved as the failure signal only for runs that never reach an actionable state (still running / stuck). Not a regression: the blocked-delivery machinery (wait_for_actionable_triggered, the 30-min backstop) shipped together in #4948; this is a latent design defect that never handled the never-resolved case. Reuses the existing `Delivered` outcome (documented as "final reply or gate prompt was delivered") — no new outcome variant, no new config, no new state machine. Regression tests (gated --features slack-v2-host-beta), all proven red on the unpatched arm and green after the fix: - triggered_persistent_blocked_approval_records_delivered_not_failed - triggered_running_then_blocked_approval_records_delivered_not_failed - triggered_persistent_blocked_oauth_auth_records_delivered_not_failed - triggered_never_actionable_run_times_out_failed (backstop preserved: zero posts, Failed) Adds a `ScriptedTurnCoordinator::with_states_clamped` helper (sticky final state) and folds the one-off test coordinator into it. Invariant captured as a doc comment on `deliver_triggered_run`. Follow-up (separate track): converge the local parked-state check onto the canonical `TurnStatus::wait_class()` classifier once it lands. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Summary
Validation
Security Impact
None.
Database Impact
None.
Blast Radius
Limited to bundled Web Access onboarding copy in the Reborn extension catalog.
Rollback Plan
Revert this PR to restore the previous Web Access onboarding copy.