Repository navigation
arch(ws-14): register planned driver default path - #3651
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a factory for the planned driver, centralizing its configuration and registration. It adds a new planned_driver_factory module, updates PlannedDriver to support descriptor-based initialization, and enhances the InMemoryRunProfileResolver to allow for configurable implicit default profiles. New end-to-end tests and unit tests verify the registration and resolution logic. I have no feedback to provide.
Review notes — WS14 planned default registrationGenuine opt-in for the planned path: default Text-only registration tagged Production + all-optional
Two options:
Either is fine; the current shape promises Production-ready behavior the type doesn't actually require.
|
SummaryReviewed WS14 PR #3651 only. No unintended cutover found, but actual default planned-driver registration is not wired into production/default coordinator path. Validation:
Findings
Security/data-flow notes
Correctness/invariant notes
Missing tests
|
Squash of #3651 (1 commit) onto reborn-integration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Squash of nearai#3651 (1 commit) onto reborn-integration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Squash of nearai#3651 (1 commit) onto reborn-integration. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Context
Default planned-driver registration branch. It adds the registry/profile helpers that let Reborn select the planned default path while keeping live production cutover deferred.
Master spec:
docs/reborn/agent-loop-skeleton.mdWorkstream brief:
docs/reborn/agent-loop-briefs/planned-driver-registration.mdStack base:
arch/ws-14-parentLatest stack maintenance on 2026-05-14:
origin/reborn-integrationthrough WS17 before publishing the PR descriptions.What landed
reborn-planned-defaultrun-profile selection support.Reviewer focus
Non-goals / deferred work
Validation
cargo test -p ironclaw_reborn planned_driver_factory --features ironclaw_agent_loop/test-supportcargo test -p ironclaw_reborn --test planned_driver_e2e --features ironclaw_agent_loop/test-supportcargo test -p ironclaw_turns --test run_profile_contractcargo check -p ironclaw_turns -p ironclaw_loop_support -p ironclaw_agent_loop -p ironclaw_reborn --features ironclaw_agent_loop/test-supportgit diff --checkStack position