-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(reborn): add ironclaw_hooks framework foundation (#3524) #3573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+19,871
−185
Merged
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
cdf173d
feat(reborn): add ironclaw_hooks framework foundation (#3524)
zmanian 1d7eb01
feat(reborn): wire HookDispatcher into LoopCapabilityPort/LoopPromptPort
zmanian 118f130
feat(reborn): add HookedLoopModelPort/TranscriptPort/CheckpointPort o…
zmanian 844a43e
test(reborn): end-to-end hooks integration through RebornLoopDriverHo…
zmanian 9febe83
feat(reborn): add pass() + HookRegistrar + self-authored hooks scaffo…
zmanian 7e677fa
Merge hooks-bia: pass() + HookRegistrar + self-authored hooks scaffol…
zmanian cc69f44
Merge hooks-observer-f: HookedLoopModelPort/TranscriptPort/Checkpoint…
zmanian 1b2a15a
Merge hooks-reborn-test-h: end-to-end hooks integration through Rebor…
zmanian 0e5c757
feat(reborn): real gate-ref plumbing for hook PauseApproval/PauseAuth…
zmanian 9b1297f
feat(reborn): add NumericSum predicate evaluation with capability arg…
zmanian e7487de
fix(reborn): seal hook registration trust boundary + dispatcher harde…
zmanian 44f154b
feat(reborn): emit hook telemetry milestones for audit/SSE observers
zmanian bbb8c1f
feat(reborn): extract shared prompt envelope; inject hook patches int…
zmanian 5479aa7
Merge hooks-codex-fixes: address C1+C2+C5+C6 audit blockers
zmanian 5bf4cbd
Merge hooks-e-numeric: NumericSum predicate evaluation with arg extra…
zmanian 8c7f638
fix: align tenant-counter test with SanitizedArguments-extended conte…
zmanian 9f05a8f
Merge hooks-d-gate-ref: real gate-ref plumbing for PauseApproval/Paus…
zmanian a391246
Merge hooks-c-telemetry: hook telemetry milestones
zmanian 8d01555
Merge hooks-g-envelope: shared prompt envelope + hook patch injection
zmanian 504d4ff
docs(reborn): document loader contract; pin HookId hex format
zmanian c485954
test(reborn): pin hook milestone JSON schema + assert pairing invariants
zmanian 4003426
test(reborn): integration tests for observer middleware through Rebor…
zmanian 38c7d6c
refactor(reborn): introduce HookDispatcherBuilder for type-enforced s…
zmanian 2744aed
feat(reborn): production CapabilityInputResolver for NumericSum predi…
zmanian 894d361
feat(reborn): per-build HookDispatcher for full per-run isolation (C2)
zmanian ecd0d46
feat(reborn): project hook telemetry milestones into RuntimeEvent for…
zmanian f42d0f2
feat(reborn): enforce manifest-declared hook scope at dispatch time (C3)
zmanian 0479697
Merge hooks-fu2-loader-test: loader contract doc + HookId format pin
zmanian 84bc76f
Merge hooks-fu4-snapshots: milestone schema snapshots + pairing matrix
zmanian 359673e
Merge hooks-fu3-runtime-events: project hook telemetry into RuntimeEvent
zmanian 709eb40
Merge hooks-fu6-input-resolver: observer middleware factory wiring + …
zmanian 80e90c4
Merge hooks-fu5-pairing-id: production CapabilityInputResolver for Nu…
zmanian 91f9e9c
Merge hooks-fu7-observer-integration: HookDispatcherBuilder for type-…
zmanian adcf167
Merge hooks-fu8-per-build: per-build HookDispatcher for full per-run …
zmanian 3c66006
Merge hooks-fu1-c3-scope: manifest scope enforcement + provider in ho…
zmanian 664f461
style: rustfmt dispatch.rs after FU1 merge
zmanian b0cae2e
docs(hooks): prior-art comparison against LSM/eBPF/Envoy/K8s/OPA/CRX/…
zmanian 2d176d2
docs(hooks): STRIDE threat model for v1 framework
zmanian 7350756
feat(hooks): close threat-model gaps S1 (gate-ref entropy) and D3/D4 …
zmanian f2555e8
test(hooks): three real hooks built against the public API + ergonomi…
zmanian 434b547
feat(hooks): close all remaining threat-model and ergonomics gaps
zmanian d9b2000
merge: resolve conflicts with reborn-integration + address bot reviews
zmanian e6288a5
merge: integrate reborn-integration + address Firat's review findings
zmanian a49d558
fix(ci): collapse nested match in hooks_integration test for clippy -…
zmanian c991f30
feat(hooks): address henrypark133 review — Critical #1/#2/#3/#5, Conc…
zmanian 7d714dd
feat(hooks): address remaining henrypark133 review — Critical #4, Con…
zmanian 5793e4d
merge: integrate origin/reborn-integration
zmanian ac4c109
docs(hooks): scope DenyReasonCode closed-vocabulary enum (successor #6)
zmanian 251ae78
feat(hooks): DenyReasonCode + PauseReasonCode closed-vocabulary enums
zmanian c4705aa
test(hooks): address codex review on #3636
zmanian 829601c
fix(hooks): attenuate Installed-tier prompt patches to user role
zmanian 61e6e80
fix(hooks): enforce scope filter on observer dispatch + reject incomp…
zmanian 5c33c74
fix(hooks): preserve free-form audit reason alongside closed-vocab mo…
zmanian c5526e8
Merge remote-tracking branch 'origin/reborn-integration' into hooks-f…
zmanian 4035822
fix(hooks): remove unused model_request helper (CI clippy fix)
zmanian 564ff9c
Merge remote-tracking branch 'origin/reborn-integration' into hooks-f…
zmanian b911223
Merge remote-tracking branch 'origin/reborn-integration' into hooks-f…
zmanian 496d0ac
fix(hooks): address serrrfirat P1/P2 findings on PR #3573
zmanian e9038f9
Merge remote-tracking branch 'origin/reborn-integration' into hooks-f…
zmanian 86d411d
fix(hooks): address serrrfirat 3573-2026-05-15 review findings
zmanian d6c4d79
Merge remote-tracking branch 'origin/reborn-integration' into hooks-f…
zmanian 8809814
Merge pull request #3636 from nearai/hooks-fu-deny-reason-code
zmanian 106a409
Merge remote-tracking branch 'origin/reborn-integration' into hooks-f…
zmanian 05a1355
fix(hooks): address PR #3573 review feedback round 3
zmanian 427a2fd
test(hooks): batch deferred test coverage from #3573 review (#3914)
zmanian a233c55
perf(hooks): defer capability input resolution until a predicate need…
zmanian ea78d4e
fix(rebase): adapt hooks tests + middleware to upstream API additions
zmanian 30378d1
perf(hooks): restore batched capability dispatch when hooks active (#…
zmanian 19599ed
fix(rebase): add StaticTurnStateStore to hooks_integration tests
zmanian f07aa37
refactor(hooks): enforce identity newtype validation at construction …
zmanian ae8b25a
style: rustfmt after #3911 / #3912 cherry-picks
zmanian ae245c5
fix(rebase): use ExtensionId::new / HookLocalId::new after #3912
zmanian 69b31b7
Merge remote-tracking branch 'origin/reborn-integration' into hooks-f…
zmanian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Medium] Hook events run-status behavior is untested
run_status_for_event now treats hook telemetry as non-terminal and preserves the current run status, defaulting to Running when hook telemetry is first. Adjacent replay tests assert hook metadata projection but do not assert run status for hook-only streams or hook events after terminal events.
Fix: tests::replay_projection_contract::hook_runtime_events_do_not_change_run_status covering hook-only and post-terminal status preservation
Reviewer:
tests; confidence: 100.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferred.
run_status_for_eventis inironclaw_event_projections, outside the surface I touched for the install/dispatch hardening in 57a6429. Adding the requestedhook_runtime_events_do_not_change_run_statustest is straightforward but scoped to the projections review pass.