feat(reborn/product-workflow): finish dispatch arms, hooks, and ack taxonomy (#3280)

[nickpismenkov]

Waiting on PR #3542 to merge first

This PR provides the ProjectionSubscriptionAuthority port trait that production wiring will satisfy by wrapping ironclaw_outbound::OutboundPolicyService::authorize_subscription. OutboundPolicyService itself lives in PR #3542 (currently CHANGES_REQUESTED; the seal-types fix is already pushed at a5819c50 and CI is green). This PR's source has no compile-time dependency on #3542 — the port is a pure abstraction with a FakeProjectionSubscriptionAuthority impl for tests — but the production wiring that satisfies the port (in step 4 of the rollout plan) requires #3542 to merge first. Please review and approve, but hold the merge button until #3542 lands.

Summary

Closes the remaining 8 acceptance criteria of issue #3280 (ProductWorkflow facade). Builds on PR #3428's first slice.

Adds eight new port traits, two new payload variants, five new ack variants, a BeforeInbound hook seam, and 38 new contract tests including the critical regression test that closes the v1 mission auto-attach bug shape.

What lands in this PR

New port traits (crates/ironclaw_product_workflow/src/services.rs)

Implementor-side facades that production wiring will satisfy by wrapping host-layer services. Names align with the contract sketches in #3094, #3278, #3280, and #3286.

Trait	Closes AC	Wrapped by (production wiring, this PR ships the port only)
BeforeInboundPolicy	#8, #9	v1 HookPoint::BeforeInbound ported
ProductCommandRouter	#14	#3286's AgentCommandService (full matrix)
ApprovalInteractionService	#15	ironclaw_approvals::ApprovalResolver (#3094)
AuthInteractionService	#15	ironclaw_authorization::CapabilityDispatchAuthorizer (#3094)
LinkedThreadActionService	new dispatch arm	TBD per-product handler
MissionService	#16	MissionFireRequest/Outcome per #3278
SystemActionService	#20	TBD typed system handlers
ProjectionSubscriptionAuthority	#19	OutboundPolicyService::authorize_subscription (#3542)

DefaultProductWorkflow::new(inbound_turn_service, idempotency_ledger) stays a 2-arg constructor for back-compat with #3428's tests; with_* builder methods plug in the new ports. When a port is unset, the corresponding arm returns a redacted permanent Rejected ack via the existing terminal_ack_for_error taxonomy.

New payload variants (crates/ironclaw_product_adapters/src/inbound.rs)

• MissionActionPayload { mission_intent, mission_id_hint, data } — explicit intent only.
• SystemActionPayload { system_actor_ref, kind, scope_thread_id, data } — typed system action with mandatory accountable actor/kind. No is_internal bypass (AC feat: Support direct API key auth and cheap model routing #20).

Plus five wire-stable typed wrappers used by the new ack variants (MissionFireRef, MissionFireSuppressionReason, LoopGateRef, ProductCommandName, LinkedThreadActionId). They live in the adapter crate so acks serialize without the workflow crate appearing in the wire surface.

New ack variants (ProductInboundAck)

• CommandRouted { command }
• GateHandled { gate_ref } — used by both approval and auth resolutions (auth_request_ref projects into the wire-stable LoopGateRef container)
• LinkedThreadActionRouted { action_id }
• MissionSubmitted { mission_fire_ref, submitted_run_id }
• MissionSuppressed { mission_fire_ref, reason }

All five are durable outcomes; none are retryable.

BeforeInbound integration (inbound_turn.rs)

DefaultInboundTurnService gains an optional Arc<dyn BeforeInboundPolicy> field via with_before_inbound_policy. The hook fires only on the genuine new-message path (after the replay-check, before binding resolution). Rewrite replaces the staged content; rejection short-circuits before any accept_inbound_message or submit_turn call so rejected input never becomes accepted transcript content.

Subscription read-path bypass

accept_inbound short-circuits SubscriptionRequest before any idempotency-ledger touch — read paths never take a ProductInboundAction row (AC #19). Adapters must use resolve_projection_subscription for the read path; that method now reaches the ProjectionSubscriptionAuthority port and returns the canonical adapter-facing ProjectionSubscriptionRequest.

No mission auto-attach guarantee

ordinary_user_message_text_never_reaches_mission_service is the regression closure for AC #17 / the v1 src/bridge/router.rs::fire_event_missions_for_message bug shape where MissionCadence::OnEvent { event_pattern } pattern-matched inbound text and side-fired missions in parallel to the turn.

The test drives four mission-keyword UserMessage envelopes through a fully-wired workflow (every port configured) and asserts MissionService::fire_count() == 0 after each. Missions only fire via explicit MissionActionPayload from the adapter.

Acceptance criteria coverage (#3280)

AC	Status
#1 UserMessage → InboundTurnService	unchanged from #3428
#2 Adapter-supplied internal refs non-authoritative	unchanged from #3428
#3 Ledger row before staging	unchanged from #3428
#4 Duplicate replays prior outcome	unchanged from #3428
#5 No duplicate message/run on replay	unchanged from #3428
#6 Crash recovery uses same accepted message ref	unchanged from #3428
#7 Pre-side-effect transient failure stays retryable	unchanged from #3428
#8 BeforeInbound rewrite stages rewritten content	NEW
#9 BeforeInbound rejection creates no transcript content	NEW
#10 Refs-only TurnCoordinator submit	unchanged from #3428
#11 ThreadBusy → DeferredBusy	unchanged from #3428
#12 Pipeline acknowledgement only	unchanged from #3428
#13 Adapter-supplied internal user/thread/scope ignored	unchanged from #3428
#14 Slash-command via ProductCommandRouter seam	NEW
#15 Gate/auth via interaction services, no direct resume_turn	NEW
#16 Mission via MissionService, explicit intent only	NEW
#17 Ordinary chat never auto-attaches to a mission	NEW (regression test)
#18 Product-safe rejection taxonomy redacts internals	extended for new arms
#19 Subscription dispatch creates no ledger row	NEW
#20 Typed system actions require accountable actor/scope	NEW
#21 Architecture boundary tests	confirmed intact

Test surface

File	Before	After	New
tests/inbound_turn_contract.rs	9	12	+3 BeforeInbound
tests/product_workflow_contract.rs	15	48	+33 across all new arms + projection auth + no-auto-attach guard
src/error.rs unit tests	2	2	unchanged
Total in ironclaw_product_workflow --features test-support	24 → 62		+38 tests, all pass, 0 fail

In ironclaw_product_adapters: 11 → 16 tests (+5 covering the new payload variants and wire-stable wrappers).

Out of scope (by design)

• Production wiring of any service into the running binary — that's Step 4 of the rollout plan.
• MissionService real implementation — issue [Reborn] Define MissionService integration with TurnCoordinator #3278 owns it; this PR ships the port shape only.
• AgentCommandService full command compatibility matrix — issue [Reborn] Preserve agent command behavior through Reborn loops and services #3286 owns it; this PR ships the ProductCommandRouter seam only.
• Telegram v2 / Slack v2 / Web v2 / TUI v2 adapter wiring — Step 5.
• Daemon API / OpenAPI / WIT — Step 3.

Verification

• cargo fmt --all -- --check: clean
• cargo clippy -p ironclaw_product_workflow --features test-support --all-targets -- -D warnings: clean
• cargo clippy -p ironclaw_product_adapters --all-targets --all-features -- -D warnings: clean
• cargo test -p ironclaw_product_workflow --features test-support: 62 pass, 0 fail
• cargo test -p ironclaw_product_adapters: 16 pass
• cargo test -p ironclaw_architecture: 13 boundary tests pass; reborn_crate_dependency_boundaries_hold confirms ironclaw_product_workflow still has no normal-build dependency on ironclaw_dispatcher, ironclaw_extensions, ironclaw_host_runtime, ironclaw_mcp, ironclaw_wasm, ironclaw_scripts, ironclaw_network, ironclaw_engine, or ironclaw_gateway
• cargo build --workspace: clean

Test plan

• Reviewer confirms the ordinary_user_message_text_never_reaches_mission_service regression test really exercises all the v1 bug-shape patterns
• Reviewer confirms subscription_request_via_accept_inbound_is_rejected_without_ledger_row correctly asserts the read-path bypass (no ledger lock, no authority call)
• Reviewer confirms the new ProductInboundAck variants are wire-stable and serialise round-trip
• Reviewer confirms the trait shapes match the spec sketches in [Reborn] Add approval/auth interaction services #3094, [Reborn] Define MissionService integration with TurnCoordinator #3278, [Reborn] Preserve agent command behavior through Reborn loops and services #3286 closely enough that downstream issues don't need contract revisions

🤖 Generated with Claude Code

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[serrrfirat]

how did we end up implementing missions here?

[serrrfirat]

This PR has too many assumptions about things that don't exist. We should be first implementing things that do exist.

Please review this PR and come back with a slice instead of implementing a solution that depends on non existing parts of the architecture.