fix(common): clarify crate-level doc wording - #3370
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
|
lol |
Closed
2 tasks
This was referenced May 7, 2026
Closed
Merged
Merged
theredspoon
pushed a commit
to theredspoon/ironclaw
that referenced
this pull request
Jun 21, 2026
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tiny wording tweak in the
ironclaw_commoncrate-level doc comment:for the IronClaw workspace→used across the IronClaw workspace.Why
This is a deliberate one-word change to give release-plz a leaf-crate source change to detect. Since
ironclaw-v0.27.0(Apr 29), zero commits have touchedcrates/ironclaw_common/,crates/ironclaw_safety/, orcrates/ironclaw_skills/— and release-plz only proposes a release PR when at least one leaf crate has source-path changes since its last tag (the rootironclawpackage is suppressed by thelocal > registryguard atrelease_plz_core/src/command/update/updater.rs:688).Every prior release window happened to have leaf-crate churn (v0.24→25: 6/6/6 commits, v0.25→26: 14/0/6, v0.26→27: 6/2/3). v0.27→HEAD is the first window with 0/0/0 — all ~100 commits since v0.27.0 have been in
src/or workspace plumbing.After this merges, release-plz will detect the leaf change, propose a patch bump for
ironclaw_common, and cascade the rootironclawpackage to0.28.0. From there the standard release flow takes over (review the bot's chore PR → merge → tag → cargo-dist).A more durable fix (e.g.
release_always = trueon theironclaw[[package]]inrelease-plz.toml) is a separate conversation; this PR only unblocks the v0.28.0 cut.Test plan
chore: releasePR appears fromapp/ironclaw-ciproposingironclaw 0.27.0 → 0.28.0