test(db): serialize postgres migration fixup tests - #3307
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a static mutex, POSTGRES_MIGRATION_FIXUP_TEST_LOCK, to synchronize integration tests within src/db/migration_fixup.rs. This change ensures that tests requiring the integration feature do not run concurrently, preventing potential race conditions during database migrations. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refinery_schema_historytableCREATE TABLE IF NOT EXISTS refinery_schema_historycan fail with a duplicatepg_type_typname_nsp_indexerrorWhy
Main's Coverage (all-features) job failed on commit
576eb3bb7d6f01db6a92371243f838f059db11f1indb::migration_fixup::tests::rejects_canonical_in_known_bad_checksums, not in the libSQL decimal parser test. The panic was:duplicate key value violates unique constraint "pg_type_typname_nsp_index" ... refinery_schema_historyThat points to an existing parallel Postgres DDL race, not a product-code regression.
Verification
cargo fmt --checkcargo test --lib --all-features db::migration_fixup::tests::rejects_canonical_in_known_bad_checksums -- --nocapturecargo check --all-features -qgit diff --check