Skip to content

ci(e2e): replace deleted preflight test with tool_activate surface - #3234

Merged
ilblackdragon merged 1 commit into
mainfrom
ci/fix-v2-engine-e2e-list
May 3, 2026
Merged

ilblackdragon merged 1 commit into
mainfrom
ci/fix-v2-engine-e2e-list

Conversation

@ilblackdragon

Copy link
Copy Markdown
Member

Summary

The v2-engine E2E group in .github/workflows/e2e.yml still listed tests/e2e/scenarios/test_v2_kernel_auth_preflight.py, but that file was removed in #2868 ("engine-v2: make available_actions callable-only for blocked providers", merged 2026-04-25). Per that PR's description, the test was replaced with test_v2_tool_activate_surface.py to cover the new tool_activate / Activatable Integrations contract — the workflow file just wasn't updated alongside it.

Web E2E Full is skipped at the PR level and only runs in the merge queue, so the broken path filter went unnoticed for ~10 days. Both #3197 and #3203 were dequeued with:

ERROR: file or directory not found: tests/e2e/scenarios/test_v2_kernel_auth_preflight.py

This swaps the missing file for its successor.

Test plan

The v2-engine E2E group still listed test_v2_kernel_auth_preflight.py,
but that file was removed in #2868 (engine-v2: callable-only available
actions) and replaced with test_v2_tool_activate_surface.py for the new
tool_activate / Activatable Integrations contract.

The Web E2E Full job is skipped on PR-level CI but runs in the merge
queue, so the bad path filter dequeued #3197 and #3203 with
"file or directory not found: test_v2_kernel_auth_preflight.py".
Copilot AI review requested due to automatic review settings May 3, 2026 15:50
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added scope: ci CI/CD workflows size: XS < 10 changed lines (excluding docs) risk: medium Business logic, config, or moderate-risk modules contributor: core 20+ merged PRs labels May 3, 2026
@ilblackdragon
ilblackdragon merged commit eeeb294 into main May 3, 2026
31 checks passed
@ilblackdragon
ilblackdragon deleted the ci/fix-v2-engine-e2e-list branch May 3, 2026 15:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the E2E workflow’s v2-engine test matrix after an earlier test file was removed and replaced. It keeps the CI configuration aligned with the current engine-v2 auth/activation surface so merge-queue runs execute the intended browser coverage.

Changes:

  • Replaces the deleted test_v2_kernel_auth_preflight.py entry in .github/workflows/e2e.yml.
  • Adds the current successor test, test_v2_tool_activate_surface.py, to the v2-engine E2E group.
  • Restores the workflow’s ability to run the full v2-engine E2E slice without failing on a missing file path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

theredspoon pushed a commit to theredspoon/ironclaw that referenced this pull request Jun 21, 2026
…earai#3234)

The v2-engine E2E group still listed test_v2_kernel_auth_preflight.py,
but that file was removed in nearai#2868 (engine-v2: callable-only available
actions) and replaced with test_v2_tool_activate_surface.py for the new
tool_activate / Activatable Integrations contract.

The Web E2E Full job is skipped on PR-level CI but runs in the merge
queue, so the bad path filter dequeued nearai#3197 and nearai#3203 with
"file or directory not found: test_v2_kernel_auth_preflight.py".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: ci CI/CD workflows size: XS < 10 changed lines (excluding docs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants