fix(reborn): close foundation fail-closed gaps - #2997
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two fail-closed foundation issues surfaced from downstream PR review feedback:
HostApiErrorinstead of risking stack overflow.Changes
ironclaw_host_apicanonical_json(...)returnResult<serde_json::Value, HostApiError>.MAX_CANONICAL_JSON_DEPTHguard.ironclaw_resourcesResourceError::InvalidEstimate.estimate.usd >= 0inreserve_with_id(...)before acquiring/mutating reservation state.Verification
cargo test -p ironclaw_host_api -p ironclaw_resources cargo clippy -p ironclaw_host_api -p ironclaw_resources --all-targets -- -D warnings cargo fmt --check git diff --check