fix: incorrect ironclaw version in staging - #2981
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the workspace’s root ironclaw package version metadata to match the intended release line so downstream consumers (e.g., image/version detection in ironclaw-dind) report the correct version.
Changes:
- Bump root package version from
0.25.0→0.26.0inCargo.toml. - Reflect the root package version bump in
Cargo.lock.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updates the root package version to 0.26.0 for consistent build/--version reporting. |
| Cargo.lock | Updates the lockfile entry for the root ironclaw package to 0.26.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [package] | ||
| name = "ironclaw" | ||
| version = "0.25.0" | ||
| version = "0.26.0" | ||
| edition = "2024" | ||
| rust-version = "1.92" |
There was a problem hiding this comment.
PR description says this aligns to the latest release line (v0.26.0), but the repo changelog currently only lists releases up through 0.25.0. If 0.26.0 is intended, consider updating CHANGELOG/release notes (or clarifying in the PR description why the changelog is intentionally unchanged) to avoid conflicting release metadata for downstream consumers.
|
@serrrfirat @henrypark133 Can we make sure the version in |
There was a problem hiding this comment.
Code Review
This pull request updates the ironclaw package version from 0.25.0 to 0.26.0 in both Cargo.toml and Cargo.lock. Feedback was provided regarding the missing update to the CHANGELOG.md file, which should be updated to include a new section for this version to maintain an accurate release history.
| [package] | ||
| name = "ironclaw" | ||
| version = "0.25.0" | ||
| version = "0.26.0" |
There was a problem hiding this comment.
The package version has been updated to 0.26.0, but the CHANGELOG.md does not contain an entry for this version. It is important to update the changelog to reflect the new version and move any relevant changes from the [Unreleased] section to a new [0.26.0] section to maintain a clear and accurate release history.
Summary
ironclawfrom0.25.0to0.26.0in bothCargo.tomlandCargo.lock.ironclaw-dindCI summary/version detection) to report stale0.25.0.--versionreporting match the intended release line.Change Type
Linked Issue
Related: version mismatch between released IronClaw line and workspace manifest version (no formal issue linked).
Validation
cargo fmt --all -- --checkcargo clippy --all --benches --tests --examples --all-features -- -D warningscargo buildcargo test --features integrationif database-backed or integration behavior changedversion = "0.26.0"in bothCargo.tomlandCargo.lockreview-prorpr-shepherd --fixwas run before requesting reviewSecurity Impact
None.
Database Impact
None.
Blast Radius
Low. Touches only release/version metadata for the root
ironclawpackage. Main risk is release automation or version-gating logic that depends on this value (intended behavior).Rollback Plan
Revert this commit to restore
0.25.0inCargo.tomlandCargo.lockif any downstream release process unexpectedly depends on the previous value.Review Follow-Through
Please confirm this aligns with the expected release source of truth (
v0.26.0) and that downstream image/version pipelines should consume this updated manifest version.Review track: A