Repository navigation
ci: drop duplicate matrix legs and consolidate caches #2614
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: Install cargo-component | ||
| description: Install cargo-component using a precompiled binary (taiki-e/install-action). | ||
|
|
||
| # Replaces ad-hoc `cargo install cargo-component --locked || true` calls. The | ||
| # precompiled-binary path takes a few seconds vs. several minutes for a source | ||
| # install, and we no longer swallow install failures. | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Install cargo-component | ||
| uses: taiki-e/install-action@62b0f2dec647a8e604c6a0fda0e38530180dce20 # v2 | ||
| with: | ||
| tool: cargo-component | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,13 +1,39 @@ | ||||||
| name: Code Style | ||||||
| on: | ||||||
| pull_request: | ||||||
| paths-ignore: | ||||||
| - 'README.md' | ||||||
| - 'CHANGELOG.md' | ||||||
| - 'CONTRIBUTING.md' | ||||||
| - 'CLAUDE.md' | ||||||
| - 'AGENTS.md' | ||||||
| - 'COVERAGE_PLAN.md' | ||||||
| - 'FEATURE_PARITY.md' | ||||||
| - 'LICENSE-*' | ||||||
| - '*.png' | ||||||
| - '.github/ISSUE_TEMPLATE/**' | ||||||
| - '.github/PULL_REQUEST_TEMPLATE.md' | ||||||
| - 'docs/**' | ||||||
| # Pushes to main/staging refresh the rust-cache entries that PR jobs | ||||||
| # restore from. PR jobs themselves are restore-only (see `save-if` | ||||||
| # on the rust-cache steps below). | ||||||
| push: | ||||||
| branches: | ||||||
| - main | ||||||
| - staging | ||||||
| paths-ignore: | ||||||
| - 'README.md' | ||||||
| - 'CHANGELOG.md' | ||||||
| - 'CONTRIBUTING.md' | ||||||
| - 'CLAUDE.md' | ||||||
| - 'AGENTS.md' | ||||||
| - 'COVERAGE_PLAN.md' | ||||||
| - 'FEATURE_PARITY.md' | ||||||
| - 'LICENSE-*' | ||||||
| - '*.png' | ||||||
| - '.github/ISSUE_TEMPLATE/**' | ||||||
| - '.github/PULL_REQUEST_TEMPLATE.md' | ||||||
| - 'docs/**' | ||||||
|
|
||||||
| permissions: | ||||||
| contents: read | ||||||
|
|
@@ -94,7 +120,13 @@ jobs: | |||||
|
|
||||||
| clippy-windows: | ||||||
| name: Clippy Windows (${{ matrix.name }}) | ||||||
| # Mirror the Linux clippy gating: PR to main runs the full matrix for | ||||||
| # Windows-specific feature coverage, push to main/staging runs only the | ||||||
| # all-features leg to warm the shared cache (which `windows-build` | ||||||
| # used to fill before it was removed from test.yml). | ||||||
| if: > | ||||||
| (github.event_name == 'pull_request' && github.base_ref == 'main') || | ||||||
| (github.event_name == 'push' && matrix.name == 'all-features') | ||||||
| runs-on: windows-latest | ||||||
| strategy: | ||||||
| fail-fast: false | ||||||
|
|
@@ -117,11 +149,11 @@ jobs: | |||||
| components: clippy | ||||||
| - uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2 | ||||||
| with: | ||||||
| # Single shared slot for all three Windows clippy legs. Mirrors the | ||||||
| # Linux clippy `shared-key: clippy` pattern: --all-features is a | ||||||
| # superset, so restoring from whichever variant saved last beats | ||||||
| # storing three near-duplicate Windows target/ caches. | ||||||
| shared-key: clippy-windows | ||||||
| save-if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/staging') }} | ||||||
|
There was a problem hiding this comment.
Suggested change
Member
Author
There was a problem hiding this comment. |
||||||
| - name: Check lints | ||||||
| run: cargo clippy --all --benches --tests --examples ${{ matrix.flags }} -- -D warnings | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,9 +9,35 @@ on: | |
| pull_request: | ||
| branches: | ||
| - main | ||
| paths-ignore: | ||
| - 'README.md' | ||
| - 'CHANGELOG.md' | ||
| - 'CONTRIBUTING.md' | ||
| - 'CLAUDE.md' | ||
| - 'AGENTS.md' | ||
| - 'COVERAGE_PLAN.md' | ||
| - 'FEATURE_PARITY.md' | ||
| - 'LICENSE-*' | ||
| - '*.png' | ||
| - '.github/ISSUE_TEMPLATE/**' | ||
| - '.github/PULL_REQUEST_TEMPLATE.md' | ||
| - 'docs/**' | ||
| push: | ||
| branches: | ||
| - main | ||
| paths-ignore: | ||
| - 'README.md' | ||
| - 'CHANGELOG.md' | ||
| - 'CONTRIBUTING.md' | ||
| - 'CLAUDE.md' | ||
| - 'AGENTS.md' | ||
| - 'COVERAGE_PLAN.md' | ||
| - 'FEATURE_PARITY.md' | ||
| - 'LICENSE-*' | ||
| - '*.png' | ||
| - '.github/ISSUE_TEMPLATE/**' | ||
| - '.github/PULL_REQUEST_TEMPLATE.md' | ||
| - 'docs/**' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
@@ -49,7 +75,7 @@ jobs: | |
| key: ${{ matrix.name }} | ||
| save-if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/staging') }} | ||
| - name: Install cargo-component | ||
| uses: ./.github/actions/install-cargo-component | ||
| - name: Build WASM channels (for integration tests) | ||
| run: ./scripts/build-wasm-extensions.sh --channels | ||
| - name: Run Tests | ||
|
|
@@ -109,37 +135,6 @@ jobs: | |
| timeout --signal=INT --kill-after=30s 10m \ | ||
| cargo test --manifest-path channels-src/telegram/Cargo.toml -- --nocapture | ||
|
|
||
| wasm-wit-compat: | ||
| name: WASM WIT Compatibility | ||
| if: > | ||
|
|
@@ -162,7 +157,7 @@ jobs: | |
| key: wasm-extensions | ||
| save-if: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/staging') }} | ||
| - name: Install cargo-component | ||
| uses: ./.github/actions/install-cargo-component | ||
| - name: Build all WASM extensions against current WIT | ||
| run: ./scripts/build-wasm-extensions.sh | ||
| - name: Instantiation test (host linker compatibility) | ||
|
|
@@ -224,7 +219,10 @@ jobs: | |
| name: Run Tests | ||
| runs-on: ubuntu-latest | ||
| if: always() | ||
| # Windows compilation is covered by the clippy-windows job in | ||
| # code_style.yml (clippy implies cargo check), so no Windows job is needed | ||
| # here. | ||
| needs: [tests, heavy-integration-tests, telegram-tests, wasm-wit-compat, docker-build, version-check, bench-compile] | ||
|
Comment on lines
+222
to
+225
There was a problem hiding this comment. This workflow drops
Member
Author
There was a problem hiding this comment. |
||
| steps: | ||
| - run: | | ||
| # Unit tests must always pass | ||
|
|
@@ -237,12 +235,11 @@ jobs: | |
| exit 1 | ||
| fi | ||
| # Gated jobs: must pass on promotion PRs / push, skipped on developer PRs | ||
| for job in telegram-tests wasm-wit-compat docker-build version-check bench-compile; do | ||
| case "$job" in | ||
| telegram-tests) result="${{ needs.telegram-tests.result }}" ;; | ||
| wasm-wit-compat) result="${{ needs.wasm-wit-compat.result }}" ;; | ||
| docker-build) result="${{ needs.docker-build.result }}" ;; | ||
| version-check) result="${{ needs.version-check.result }}" ;; | ||
| bench-compile) result="${{ needs.bench-compile.result }}" ;; | ||
| esac | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure build reproducibility and avoid unexpected CI failures when a new version of
cargo-componentis released, consider pinning the tool to a specific version (e.g.,cargo-component@0.20.0). This aligns with the project's practice of using--lockedfor deterministic builds, as seen in the local setup scripts. Without a version specifier,install-actionwill fetch the latest available version, which may introduce non-deterministic behavior in the build process.References
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in #2566 — the composite action now pins to
cargo-component@0.21.1(latest stable as of 2026-04-07) and includes a comment about bump cadence via dependabot'scargo-component*group. Commit: 86d4419. (This PR is being closed in favor of #2566 — see PR description.)