-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(gateway): resolve assistant thread for threadless broadcasts #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serrrfirat
merged 5 commits into
nearai:staging
from
standardtoaster:fix/mission-broadcast-thread-id
Apr 15, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
19d935a
fix(gateway): resolve assistant thread for threadless broadcasts
standardtoaster 6dd311b
fix: don't leak owner thread_id to notify_user in mission broadcasts
standardtoaster 48ba2b5
test: verify broadcast thread_id resolution and cross-user guard
standardtoaster 8a9ee07
style: fix rustfmt in cross-user guard tests
serrrfirat aab3e67
chore: ignore RUSTSEC-2026-0098 and bump rustls-webpki 0.103.12
serrrfirat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Medium Severity — No test for the cross-user thread_id guard
The
if broadcast_user == notif.user_idcondition is a security-sensitive guard that prevents leaking the owner's mission thread_id to a different recipient. Per.claude/rules/testing.md("Test Through the Caller"), when a predicate gates a side effect with computed inputs, a caller-level test is required.Suggestion: Add an integration test that exercises
handle_mission_notification(or the broadcast path) with aMissionNotificationwherenotify_user = Some("other-user"), and verify the response sent to the channel does NOT carry the owner's thread_id. Separately test thenotify_user == Nonecase to verify thread_id IS attached.