Skip to content

chore: promote staging to staging-promote/3f6149c5-24326488764 (2026-04-13 08:39 UTC) - #2393

Merged
henrypark133 merged 1 commit into
mainfrom
staging-promote/625cd85a-24333948714
Apr 18, 2026
Merged

henrypark133 merged 1 commit into
mainfrom
staging-promote/625cd85a-24333948714

Conversation

@ironclaw-ci

@ironclaw-ci ironclaw-ci Bot commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Auto-promotion from staging CI

Batch range: a53eac5c2dec6b6cd5c08189086093fde64aa9cb..625cd85a91587aea0f4915385065278420e63089
Promotion branch: staging-promote/625cd85a-24333948714
Base: staging-promote/3f6149c5-24326488764
Triggered by: Staging CI batch at 2026-04-13 08:39 UTC

Commits in this batch (16):

Current commits in this promotion (1)

Current base: staging-promote/3f6149c5-24326488764
Current head: staging-promote/625cd85a-24333948714
Current range: origin/staging-promote/3f6149c5-24326488764..origin/staging-promote/625cd85a-24333948714

Auto-updated by staging promotion metadata workflow

Waiting for gates:

  • Tests: pending
  • E2E: pending
  • Claude Code review: pending (will post comments on this PR)

Auto-created by staging-ci workflow

…2388)

`models set-provider` intentionally writes to both config.toml and .env
for immediate effect. This caused the config resolver to always emit a
warning about DB (config.toml) overriding the env var, even though both
values are identical. Skip the warning when the values match, since there
is no silent override happening.

Co-authored-by: iyen <iyen@iyens-Mac-mini.local>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added size: XS < 10 changed lines (excluding docs) risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Apr 13, 2026
@claude

claude Bot commented Apr 13, 2026

Copy link
Copy Markdown

Code review

Found 1 issue:

  1. [HIGH:75] Case-sensitive backend comparison in warning suppression condition. The PR adds && env_val != backend at line 101 to suppress the warning when both values are identical. However, the comparison is case-sensitive, while the rest of the code normalizes backend names to lowercase (line 112). If a user has LLM_BACKEND=Nearai in .env and llm_backend="nearai" in config.toml, the condition evaluates to true and the warning incorrectly fires despite both referring to the same backend. The fix should compare lowercase values: && env_val.to_ascii_lowercase() != backend.to_ascii_lowercase().

https://github.com/anthropics/ironclaw/blob/121b82efa82f8a9d3c6dd8b0bfc2b34f5de59bae/src/config/llm.rs#L98-L109

   // Warn operators when a DB-persisted value silently overrides LLM_BACKEND.
   // Skip the warning when both values are identical — this is the normal
   // state after `ironclaw models set-provider`, which intentionally writes
   // to both config.toml and .env for immediate effect.
   if backend_source == "db:llm_backend"
       && let Ok(env_val) = std::env::var("LLM_BACKEND")
       && !env_val.is_empty()
       && env_val != backend  // ← case-sensitive comparison
   {
       tracing::warn!(

Base automatically changed from staging-promote/3f6149c5-24326488764 to main April 18, 2026 00:59
@henrypark133
henrypark133 merged commit 625cd85 into main Apr 18, 2026
37 of 45 checks passed
@henrypark133
henrypark133 deleted the staging-promote/625cd85a-24333948714 branch April 18, 2026 01:00

This branch had an error being deployed

1 failed and 3 inactive deployments
humble-cat / staging-cameron — 625cd85a Deployed Apr 13, 2026 by railway-app[bot]
cosmose-ironclaw / production — 625cd85a Deployed Apr 13, 2026 by railway-app[bot]
ironclaw-nearai / production — 625cd85a Deployed Apr 13, 2026 by railway-app[bot]
venice-ironclaw / production — 625cd85a Deployed Apr 13, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules size: XS < 10 changed lines (excluding docs) staging-promotion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants