-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(gateway): add attachment flows, v2 skill install coverage, and e2e stabilization #2385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+6,311
−802
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1007223
feat(gateway): add attachment flows and slash-skill coverage
ilblackdragon 886eca5
feat(v2): persist project attachments across channels
ilblackdragon a1c6808
feat(skills): install GitHub skill bundles
ilblackdragon 49bb04b
feat(v2): cover live skill install and setup flow
ilblackdragon 2e4ab90
test(e2e): stabilize gateway and auth coverage
ilblackdragon 7f21f8e
Merge remote-tracking branch 'origin/staging' into gateway-attachment…
ilblackdragon efe7240
test(e2e): stabilize post-merge warnings and browser flows
ilblackdragon 1a89812
Merge origin/staging and address PR review feedback
ilblackdragon 6acfb23
fix(review): address follow-up PR feedback
ilblackdragon b2eb5e5
fix(review): address remaining attachment and skill install comments
ilblackdragon 5fb520b
Merge remote-tracking branch 'origin/staging' into gateway-attachment…
ilblackdragon aa5bcb6
Address remaining attachment review comments
ilblackdragon adc1576
Merge origin/staging into gateway-attachments-slash-v2
ilblackdragon 5f23ee6
Merge origin/staging into gateway-attachments-slash-v2
ilblackdragon 4de4cf4
fix(ci): allowlist ws.rs → server::inline_attachments_to_incoming
ilblackdragon 0b85145
Merge origin/staging into gateway-attachments-slash-v2
ilblackdragon 627e400
fix(e2e): attachment persistence path and Slack activate signature
ilblackdragon 2164e54
fix(engine-v2): auth-prompt surfacing, bundle_path injection, attachm…
ilblackdragon 401dade
fix(e2e): switch approval/auth-prompt probes to pending_gate
ilblackdragon 795f550
fix(e2e): google-oauth _wait_for_auth_prompt / _wait_for_response use…
ilblackdragon d2e904e
fix(e2e): relax a few stale v2-surface assertions
ilblackdragon 03fdf32
Merge origin/staging into gateway-attachments-slash-v2
ilblackdragon 1141d2e
fix(review): address attachment index note correctness
ilblackdragon 006edf4
fix(e2e): cancel_during_auth asserts pending_gate clears, not chat text
ilblackdragon edeaab6
fix(e2e): pairing approve test tolerates ExtensionName boundary reject
ilblackdragon 71393f0
fix(review): preserve image bytes through LLM call + document drive m…
ilblackdragon 0a22782
Merge remote-tracking branch 'origin/staging' into gateway-attachment…
ilblackdragon 85d3c5a
fix(review): address remaining Copilot feedback on PR 2385
ilblackdragon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createMessageElementstrips a trailing<attachments>…</attachments>block from any user message whenparseUserMessageContentis available. This will also strip legitimate user text that happens to contain that markup at the end of their message. Consider adding an unambiguous sentinel (e.g. a non-printable prefix) around the backend-appended block or changing the history API to return attachments in a dedicated field instead of overloadinguser_input.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in
85d3c5ab:parseUserMessageContentnow only strips the trailing<attachments>…</attachments>block when at least one<attachment …>tag is parsed out of it. If the inner regex finds no attachments (e.g. a user happens to type literal<attachments></attachments>at the end of a message), the originalcontentis returned untouched. Splitting the protocol into a dedicated history field is still a worthwhile follow-up but this closes the immediate text-loss path.