Skip to content

chore: promote staging to staging-promote/66ccafb9-24321596712 (2026-04-13 03:02 UTC) #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrypark133 merged 1 commit into from
Apr 18, 2026
+321 −26
Merged

chore: promote staging to staging-promote/66ccafb9-24321596712 (2026-04-13 03:02 UTC) #2384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions crates/ironclaw_engine/orchestrator/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ def run_loop(context, goal, actions, state, config):
max_consecutive_errors = config.get("max_consecutive_errors", 5)
consecutive_nudges = 0
consecutive_errors = 0
consecutive_action_errors = 0
step_count = config.get("step_count", 0)
if not isinstance(state, dict):
state = {}
Expand Down Expand Up @@ -611,6 +612,7 @@ def run_loop(context, goal, actions, state, config):
__save_checkpoint__(state, {
"nudge_count": consecutive_nudges,
"consecutive_errors": consecutive_errors,
"consecutive_action_errors": consecutive_action_errors,
"compaction_count": state.get("compaction_count", 0),
})
__transition_to__("waiting", "gate paused: " + gate.get("gate_name", "unknown"))
Expand All @@ -630,6 +632,7 @@ def run_loop(context, goal, actions, state, config):
__save_checkpoint__(state, {
"nudge_count": consecutive_nudges,
"consecutive_errors": consecutive_errors,
"consecutive_action_errors": consecutive_action_errors,
"compaction_count": state.get("compaction_count", 0),
})
if approval.get("need_authentication"):
Expand Down Expand Up @@ -667,6 +670,7 @@ def run_loop(context, goal, actions, state, config):
__save_checkpoint__(state, {
"nudge_count": consecutive_nudges,
"consecutive_errors": consecutive_errors,
"consecutive_action_errors": consecutive_action_errors,
"compaction_count": state.get("compaction_count", 0),
})

Expand Down Expand Up @@ -725,6 +729,8 @@ def run_loop(context, goal, actions, state, config):
# "No tool output found for function call <id>". Iterate over
# executable_calls (not results) so we cover calls that the Rust
# batch handler skipped (e.g. RequireApproval early return).
batch_error_count = 0
batch_success_count = 0
for idx in range(len(executable_calls)):
call = executable_calls[idx]
call_id = call.get("call_id", "")
Expand All @@ -733,9 +739,15 @@ def run_loop(context, goal, actions, state, config):
action_name = r.get("action_name", call.get("name", ""))
output = r.get("output")
output_str = str(output) if output is not None else "[no output]"
if r.get("is_error"):
output_str = "[ACTION FAILED] " + output_str
batch_error_count += 1
else:
batch_success_count += 1
else:
action_name = call.get("name", "unknown")
output_str = "[execution skipped]"
batch_error_count += 1
append_message(
working_messages,
"ActionResult",
Expand All @@ -754,6 +766,7 @@ def run_loop(context, goal, actions, state, config):
__save_checkpoint__(state, {
"nudge_count": consecutive_nudges,
"consecutive_errors": consecutive_errors,
"consecutive_action_errors": consecutive_action_errors,
"compaction_count": state.get("compaction_count", 0),
})
gate = r
Expand All @@ -774,6 +787,7 @@ def run_loop(context, goal, actions, state, config):
__save_checkpoint__(state, {
"nudge_count": consecutive_nudges,
"consecutive_errors": consecutive_errors,
"consecutive_action_errors": consecutive_action_errors,
"compaction_count": state.get("compaction_count", 0),
})
__transition_to__("waiting", "authentication needed")
Expand All @@ -790,6 +804,7 @@ def run_loop(context, goal, actions, state, config):
__save_checkpoint__(state, {
"nudge_count": consecutive_nudges,
"consecutive_errors": consecutive_errors,
"consecutive_action_errors": consecutive_action_errors,
"compaction_count": state.get("compaction_count", 0),
})
__transition_to__("waiting", "approval needed")
Expand Down Expand Up @@ -843,9 +858,36 @@ def run_loop(context, goal, actions, state, config):
__transition_to__("completed", "FINAL via tool_calls")
return complete_result(state, "completed", str(answer))

# Track consecutive action errors (separate from code errors).
# Partial batch failures: increment only if ALL actions failed,
# reset if ANY succeeded.
if batch_success_count > 0:
consecutive_action_errors = 0
elif batch_error_count > 0:
consecutive_action_errors += 1

if consecutive_action_errors > 0 and consecutive_action_errors >= max_consecutive_errors + 2:
__transition_to__("failed", "too many consecutive action errors")
return complete_result(
state,
"failed",
error=str(consecutive_action_errors) + " consecutive action errors — all recent tool calls failed",
)
elif consecutive_action_errors > 0 and consecutive_action_errors >= max_consecutive_errors:
append_message(
working_messages,
"User",
"[SYSTEM] Your last " + str(consecutive_action_errors) +
" action calls have all failed. You appear to be stuck in a loop. "
"Try a completely different approach: use different tools, different "
"parameters, or break the problem down differently. If you cannot "
"make progress, call FINAL() with an honest explanation of what failed.",
)

__save_checkpoint__(state, {
"nudge_count": consecutive_nudges,
"consecutive_errors": consecutive_errors,
"consecutive_action_errors": consecutive_action_errors,
"compaction_count": state.get("compaction_count", 0),
})

Expand Down
Loading
Loading