fix(ci): bump 5 channel versions + fix lifetime desync in panics check by henrypark133 · Pull Request #2300 · nearai/ironclaw

henrypark133 · 2026-04-10T23:36:17Z

Summary

Bump registry versions for 5 WASM channels whose source changed but versions weren't updated
Fix a bug in scripts/check_no_panics.py where Rust lifetime annotations ('static, 'a) caused false positive panic violations

Addresses CI failures from #1893 (tracked in this comment).

Change Type

Bug fix
CI/Infrastructure

Linked Issue

Fixes CI failures from #1893

Version Bumps

Channel	Old	New	Reason
discord	0.2.2	0.2.3	Pairing message UX improvement
feishu	0.1.4	0.2.0	Pairing flow refactor + multi-tenancy
slack	0.2.2	0.3.0	New broadcast feature (`on_broadcast()`)
telegram	0.2.6	0.2.8	Webhook dedup + configurable polling
whatsapp	0.2.0	0.2.2	Pairing message UX improvement

Panics Check Fix

Root cause: The sanitize_line() lexer in check_no_panics.py treated Rust lifetime annotations ('static, 'a) as char literal openings. This blanked the rest of the line — including any { — causing the brace-depth tracker to desync across the entire file. In server.rs (6500+ lines), the mod tests block at line 3829 appeared to "close" at line 4501 due to a missing { on fn set_env_var(key: &'static str), making lines 4502-6568 falsely classified as production code.

Fix: Distinguish lifetimes from char literals by peeking past the identifier: if no closing ' follows, it's a lifetime (skip the apostrophe); if a closing ' is found, it's a char literal (enter char mode as before).

Regression test added: test_lifetime_annotations_do_not_desync_braces

Validation

python3 scripts/check_no_panics.py --self-test — 5/5 tests pass
Verified server.rs:6378-6387 and http_security.rs:253-275 now correctly detected as test context

Security Impact

None

Database Impact

None

Blast Radius

Registry JSON metadata only (no code changes)
CI script fix (Python, not Rust)

Rollback Plan

Revert the commit.

Review track: A (CI/chore)

🤖 Generated with Claude Code

Version bumps for channels with source changes: - discord 0.2.2 -> 0.2.3 (pairing message UX) - feishu 0.1.4 -> 0.2.0 (pairing flow refactor + multi-tenancy) - slack 0.2.2 -> 0.3.0 (broadcast feature implementation) - telegram 0.2.6 -> 0.2.8 (webhook dedup + configurable polling) - whatsapp 0.2.0 -> 0.2.2 (pairing message UX) Fix check_no_panics.py: Rust lifetime annotations ('static, 'a) were parsed as char literal openings, blanking the rest of the line including any opening brace. This caused the brace-depth tracker to desync in large test modules, producing false positives (e.g. server.rs:6378). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR addresses CI failures by (1) correcting the check_no_panics.py lexer so Rust lifetime annotations don’t desync brace tracking, and (2) bumping registry manifest versions for five WASM channel entries.

Changes:

Fix scripts/check_no_panics.py lifetime-vs-char-literal handling and add a regression test to prevent brace-depth desynchronization.
Bump version fields for 5 channel registry manifests (discord/feishu/slack/telegram/whatsapp).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
scripts/check_no_panics.py	Lexer fix for Rust lifetime annotations + new unit test to prevent brace-depth desync.
registry/channels/discord.json	Bumps channel manifest version.
registry/channels/feishu.json	Bumps channel manifest version.
registry/channels/slack.json	Bumps channel manifest version.
registry/channels/telegram.json	Bumps channel manifest version.
registry/channels/whatsapp.json	Bumps channel manifest version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-10T23:40:04Z

  "kind": "channel",
-  "version": "0.2.2",
+  "version": "0.2.3",
  "wit_version": "0.3.0",


The manifest version was bumped, but the artifacts.wasm32-wasip2.url (and sha256) still points to a binary whose filename encodes the old version (0.2.2). This will cause installs-from-artifact to fetch the old binary while reporting/recording the new version. Update the artifact URL+sha256 to the 0.2.3 release artifact, or set the artifact URL/sha256 to null until the new artifact is published (so source-build/fallback is used).

Copilot · 2026-04-10T23:40:05Z

  "kind": "channel",
-  "version": "0.1.4",
+  "version": "0.2.0",
  "wit_version": "0.3.0",


The manifest version was bumped to 0.2.0, but the artifacts.wasm32-wasip2.url still references an asset with the old version (0.1.4). This can lead to installing the older binary while the registry/UI reports 0.2.0. Either update the artifact URL+sha256 to the 0.2.0 artifact, or null out the artifact URL/sha256 until the new artifact is available.

Copilot · 2026-04-10T23:40:05Z

  "kind": "channel",
-  "version": "0.2.2",
+  "version": "0.3.0",
  "wit_version": "0.3.0",


The manifest version is now 0.3.0, but the artifacts.wasm32-wasip2.url still points to channel-slack-0.2.2-.... This makes installs-from-artifact inconsistent (old binary, new reported version). Update the artifact URL+sha256 to the 0.3.0 artifact, or set URL/sha256 to null until the 0.3.0 artifact is published.

Copilot · 2026-04-10T23:40:05Z

  "kind": "channel",
-  "version": "0.2.6",
+  "version": "0.2.8",
  "wit_version": "0.3.0",


The manifest version was bumped to 0.2.8, but the artifacts.wasm32-wasip2.url still references an older asset (channel-telegram-0.2.5-...). That can install an older binary while reporting/recording 0.2.8. Please update the artifact URL+sha256 to the 0.2.8 artifact, or null out the artifact URL/sha256 until a matching artifact is available.

Copilot · 2026-04-10T23:40:05Z

  "kind": "channel",
-  "version": "0.2.0",
+  "version": "0.2.2",
  "wit_version": "0.3.0",


The manifest version is now 0.2.2, but the artifact URL still points to whatsapp-0.2.0-.... This can lead to downloading/installing an older binary while the system reports 0.2.2. Update the artifact URL+sha256 to the 0.2.2 artifact, or temporarily set URL/sha256 to null until the new artifact is published.

Copilot · 2026-04-10T23:40:06Z

+            # blanks the rest of the line, hiding braces and causing the
+            # brace-depth tracker to desync across the whole file.
+            if nxt and (nxt.isalpha() or nxt == "_"):
+                # Peek past the identifier to see if it's 'x' (char) or 'ident (lifetime).


Small typo in this comment: it reads "'ident (lifetime)" but is missing the closing quote after ident. Consider changing it to "'ident' (lifetime)" for clarity.

Suggested change

# Peek past the identifier to see if it's 'x' (char) or 'ident (lifetime).

# Peek past the identifier to see if it's 'x' (char) or 'ident' (lifetime).

nearai#2300) Version bumps for channels with source changes: - discord 0.2.2 -> 0.2.3 (pairing message UX) - feishu 0.1.4 -> 0.2.0 (pairing flow refactor + multi-tenancy) - slack 0.2.2 -> 0.3.0 (broadcast feature implementation) - telegram 0.2.6 -> 0.2.8 (webhook dedup + configurable polling) - whatsapp 0.2.0 -> 0.2.2 (pairing message UX) Fix check_no_panics.py: Rust lifetime annotations ('static, 'a) were parsed as char literal openings, blanking the rest of the line including any opening brace. This caused the brace-depth tracker to desync in large test modules, producing false positives (e.g. server.rs:6378). Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings April 10, 2026 23:36

github-actions Bot added size: M 50-199 changed lines risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Apr 10, 2026

Copilot started reviewing on behalf of henrypark133 April 10, 2026 23:36 View session

nickpismenkov approved these changes Apr 10, 2026

View reviewed changes

henrypark133 merged commit a53eac5 into staging Apr 10, 2026
15 of 16 checks passed

henrypark133 deleted the fix/ci-version-bumps-and-panics branch April 10, 2026 23:37

ironclaw-ci Bot mentioned this pull request Apr 10, 2026

chore: promote staging to main (2026-04-10 23:37 UTC) #2301

Merged

Copilot AI reviewed Apr 10, 2026

View reviewed changes

ironclaw-ci Bot mentioned this pull request Apr 10, 2026

chore: release #2075

Merged

ironclaw-ci Bot mentioned this pull request Apr 18, 2026

chore: release #2606

Merged

Navigation Menu

fix(ci): bump 5 channel versions + fix lifetime desync in panics check - #2300

fix(ci): bump 5 channel versions + fix lifetime desync in panics check#2300
henrypark133 merged 1 commit into
stagingfrom
fix/ci-version-bumps-and-panics

henrypark133 commented Apr 10, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

Copilot AI Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	# Peek past the identifier to see if it's 'x' (char) or 'ident (lifetime).
	# Peek past the identifier to see if it's 'x' (char) or 'ident' (lifetime).

Conversation

henrypark133 commented Apr 10, 2026

Summary

Change Type

Linked Issue

Version Bumps

Panics Check Fix

Validation

Security Impact

Database Impact

Blast Radius

Rollback Plan

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants