fix(docs): explain in more details activation block & installation steps for skills - #2216
Merged
Merged
Conversation
github-actions
Bot
added
scope: docs
denbite
changed the title
activation block & installation steps for skillsactivation block & installation steps for skills
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for skill scoring and installation in docs/capabilities/skills.mdx. The reviewer identified an inaccuracy regarding the default value for the max_context_tokens field, noting that it defaults to 2000 rather than 1 when omitted, and provided a correction for the documentation table.
| | `patterns` | Regex patterns. Each match adds significant weight — use for intent-specific phrases. | | ||
| | `tags` | Short labels for broad domain matching (e.g. `blockchain`, `cli`). | | ||
| | `exclude_keywords` | Veto list — if any appear in the message, the skill scores zero regardless of other matches. | | ||
| | `max_context_tokens` | Token budget this skill may consume per turn. Omitting it leaves the skill with a 1-token budget, effectively excluding it. | |
Contributor
There was a problem hiding this comment.
The description for max_context_tokens appears to be incorrect. According to the default_max_context_tokens function in crates/ironclaw_skills/src/types.rs, omitting this field causes it to default to 2000, not 1.
Please update the documentation to reflect the correct default value.
| `max_context_tokens` | Token budget this skill may consume per turn. If omitted, this defaults to 2000. |
gagdiez
reviewed
Apr 10, 2026
gagdiez
approved these changes
Apr 10, 2026
This was referenced Apr 10, 2026
This was referenced Apr 10, 2026
Merged
Merged
theredspoon
pushed a commit
to theredspoon/ironclaw
that referenced
this pull request
Jun 21, 2026
…steps for skills (nearai#2216) * fix: explain in more details`activation` block & installation steps for skills * chore: apply review from gemini --------- Co-authored-by: Guille <gagdiez.c@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The skills doc was missing concrete installation instructions (correct path and how to verify) and an explanation of why the
activationblock is required for the agent to ever pick up a skill.Change Type
Linked Issue
Validation
cargo fmt --all -- --checkcargo clippy --all --benches --tests --examples --all-features -- -D warningscargo buildcargo test --features integrationif database-backed or integration behavior changedreview-prorpr-shepherd --fixwas run before requesting reviewSecurity Impact
Database Impact
Blast Radius
Rollback Plan
Review Follow-Through
Review track: