Repository navigation
fix(ci): resolve 3 staging test failures - #2207
Merged
Merged
Conversation
- Add V21-V23 checksums to migrations/checksums.lock (missed in #2049) - Guard telegram token URL test with ENV_MUTEX to prevent env var race - Call setAuthFlowPending before early return in handleAuthRequired Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
size: S
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes three staging CI failures by updating the migration checksum lockfile, hardening a flaky Telegram env-var test against cross-test races, and ensuring the web UI correctly marks auth as pending when a configure overlay is already open.
Changes:
- Add missing V21–V23 entries to
migrations/checksums.lockto satisfy the released-migrations immutability guard. - Serialize/clear the Telegram test override env var in
test_telegram_token_colon_preserved_in_validation_url()to avoid concurrent test interference. - Set
authFlowPendingbefore early-returning inhandleAuthRequired()when a configure overlay exists (fixing E2E expectations).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/extensions/manager.rs |
Adds env-mutex guard and clears Telegram test override env var in a regression test. |
src/channels/web/static/app.js |
Ensures auth flow is marked pending when returning early due to an existing configure overlay. |
migrations/checksums.lock |
Pins checksums for new migrations V21–V23 to satisfy the checksum guard test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
Replaces bare unsafe remove_var with ScopedEnvVar::set("") which
holds ENV_MUTEX and restores the previous value on drop, avoiding
state leakage into subsequent tests.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
size: XS
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nickpismenkov
approved these changes
Apr 10, 2026
This was referenced Apr 10, 2026
This was referenced Apr 10, 2026
Merged
Merged
6 tasks
theredspoon
pushed a commit
to theredspoon/ironclaw
that referenced
this pull request
Jun 21, 2026
* fix(ci): resolve 3 staging test failures - Add V21-V23 checksums to migrations/checksums.lock (missed in nearai#2049) - Guard telegram token URL test with ENV_MUTEX to prevent env var race - Call setAuthFlowPending before early return in handleAuthRequired Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(test): use ScopedEnvVar for env cleanup in telegram token test Replaces bare unsafe remove_var with ScopedEnvVar::set("") which holds ENV_MUTEX and restores the previous value on drop, avoiding state leakage into subsequent tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lock_env()+ clear env var to prevent race with concurrent async test settingIRONCLAW_TEST_TELEGRAM_API_BASE_URLsetAuthFlowPending(true, data.instructions)before early return when configure overlay exists, fixing E2E assertionFixes failures from staging CI run https://github.com/nearai/ironclaw/actions/runs/24198673070
Test plan
cargo test -- db::migration_fixup::tests::released_migrations_are_immutablepassescargo test -- extensions::manager::tests::test_telegram_token_colon_preserved_in_validation_urlpassescargo clippyclean🤖 Generated with Claude Code