Repository navigation
fix(test): use canonical extension name in setup submit test - #2158
Merged
Merged
Conversation
The test used a hyphenated channel name ("test-failing-channel") but
canonicalize_extension_name() converts hyphens to underscores. This
caused configure() to look for "test_failing_channel.capabilities.json"
which didn't exist, returning an early Err before reaching the
activation code path the test was designed to exercise.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
scope: channel/web
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a failing web channel setup submission test by aligning the test channel name with the extension-name canonicalization rules used by the runtime (hyphens are converted to underscores), ensuring the test reaches the intended activation-failure path.
Changes:
- Update the test channel name from a hyphenated form to an underscored form so the generated
*.capabilities.jsonfilename matches whatconfigure()looks for.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
nickpismenkov
approved these changes
Apr 8, 2026
Code reviewNo issues found. |
This was referenced Apr 9, 2026
Merged
Merged
theredspoon
pushed a commit
to theredspoon/ironclaw
that referenced
this pull request
Jun 21, 2026
…2158) The test used a hyphenated channel name ("test-failing-channel") but canonicalize_extension_name() converts hyphens to underscores. This caused configure() to look for "test_failing_channel.capabilities.json" which didn't exist, returning an early Err before reaching the activation code path the test was designed to exercise. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_extensions_setup_submit_returns_failure_when_not_activatedby using an underscored channel name (test_failing_channel) instead of hyphenated (test-failing-channel)canonicalize_extension_name()converts hyphens to underscores, soconfigure()was looking fortest_failing_channel.capabilities.jsonwhich didn't exist, causing an earlyErrbefore reaching the activation path the test exercisesTest plan
cargo test --lib channels::web::server::tests::test_extensions_setup_submit_returns_failure_when_not_activatedpasses🤖 Generated with Claude Code