chore: promote staging to staging-promote/9cf37364-24039632441 (2026-04-06 17:15 UTC)

[ironclaw-ci]

Auto-promotion from staging CI

Batch range: a55aff980a4e235590c3af57ded2542512e2f9f6..8b6298513d1ab21b96071e1645de9e2d98bf0840
Promotion branch: staging-promote/8b629851-24041939370
Base: staging-promote/9cf37364-24039632441
Triggered by: Staging CI batch at 2026-04-06 17:15 UTC

Commits in this batch (36):

• 5435b38 feat(workspace): metadata-driven indexing/hygiene, document versioning, and patch (feat(workspace): metadata-driven indexing/hygiene, document versioning, and patch #1723)
• d12b8bd feat: Add ACP (Agent Client Protocol) job mode for delegating to any compatible coding agent (feat: Add ACP (Agent Client Protocol) job mode for delegating to any compatible coding agent #1600)
• db5903f fix(routines): add bounded retry for transient lightweight failures (fix(routines): add bounded retry for transient lightweight failures #1471)
• 5c35b58 feat(auth): direct OAuth/social login with Google, GitHub, Apple, and NEAR wallet (feat(auth): direct OAuth/social login with Google, GitHub, Apple, and NEAR wallet #1798)
• a683580 fix(db): resolve V15 migration numbering conflict (fix(db): resolve V15 migration numbering conflict #1923)
• 3974163 fix(db): keep V15=conversation_source_channel to match production PG (fix(db): align V15 migration with production PostgreSQL #1928)
• a3cf7b4 Only tag :latest/:version on release, allow :staging via manual dispatch [skip-regression-check] (Docker: only tag :latest on release, allow :staging via dispatch #1925)
• d789a5d fix(db): swap V16/V17 to match production PG (document_versions before user_identities) (fix(db): swap V16/V17 to match production PG ordering #1931)
• 2b6f22f fix(docker): switch to glibc to fix libSQL segfault on DB reopen (fix(docker): switch to glibc to fix libSQL segfault on restart #1930)
• 4c9a985 feat(engine): Unified Thread-Capability-CodeAct execution engine (v2 architecture) (feat(engine): Unified Thread-Capability-CodeAct execution engine (v2 architecture) #1557)
• aa59ca0 Fix bootstrap paths and webhook defaults
• 37a7de4 [codex] Move safety benches into ironclaw_safety crate ([codex] Move safety benches into ironclaw_safety crate #1954)
• fd7dd6c fix: update CLI help snapshots for --auto-approve and acp command (fix: update CLI help snapshots for --auto-approve and acp #1966)
• 1e2d335 fix(llm): add sanitize_tool_messages to OpenAiCodexProvider (fix(llm): add sanitize_tool_messages to OpenAiCodexProvider #1971)
• b91bdbd feat(tools): persistent per-user tool permission system (feat(tools): persistent per-user tool permission system #1911)
• 994f960 Publish ironclaw-worker image from Dockerfile.worker (Publish ironclaw-worker image from Dockerfile.worker #1979)
• 3004583 feat(ownership): centralized ownership model with typed identities, DB-backed pairing, and OwnershipCache (feat(ownership): centralized ownership model with typed identities, DB-backed pairing, and OwnershipCache #1898)
• e7c8901 Fix turn cost footer and per-turn usage accounting (Fix turn cost footer and per-turn usage accounting #1951)
• 0588dd1 fix(llm): invert reasoning default — unknown models skip think/final tags (fix(llm): invert reasoning default — unknown models skip think/final tags #1952)
• 5451977 fix: unblock bootstrap ownership on dynamic_tools (fix: unblock bootstrap ownership on dynamic_tools #2005)
• 833dd32 feat: add AWS Bedrock embeddings provider (feat: add AWS Bedrock embeddings provider #1568)
• f303638 fix(security): safety layer bypass via output truncation [HIGH] (fix(security): safety layer bypass via output truncation [HIGH] #1851)
• e169591 test(workspace): add direct regression tests for scoped_to_user rebinding (Add direct tests for Workspace scoped-to-user rebinding #1652) (test(workspace): add direct regression tests for scoped_to_user rebinding (#1652) #1875)
• 42cbe5f fix(self-repair): skip built-in tools in broken tool detection and repair (fix(self-repair): skip built-in tools in broken tool detection and repair #1991)
• 733678d Ignore default model override and empty WASM polls (fix:ignore default model override and empty WASM polls #1914)
• 1c2d2f2 feat(test): dual-mode live/replay test harness with LLM judge (feat(test): dual-mode live/replay test harness with LLM judge #2039)
• 5083aed fix(agent): prevent self-repair notification spam for stuck jobs (fix(agent): prevent self-repair notification spam for stuck jobs #1867)
• 13852ff fix(docker): ensure ironclaw runtime home exists (fix(docker): ensure ironclaw runtime home exists #1918)
• 98f4471 fix(bridge): sanitize orphaned tool results in v2 adapter (fix(bridge): sanitize orphaned tool results in v2 adapter #1975)
• 792357b (fix) WASM channel HTTP SSRF protections ((fix) WASM channel HTTP SSRF protections #1976)
• f073eb6 fix: honor auto-approve tools in engine v2 ([codex] Fix ENGINE_V2 auto-approve tool behavior #2013)
• f9ed815 test: add Telegram E2E tests and Rust integration tests (test: add Telegram E2E tests and Rust integration tests #2037)
• d0096df feat: NEAR AI MCP server (feat: NEAR AI MCP server #2009)
• 9cf3736 fix(staging): repair broken test build and macOS-incompatible SSRF tests (fix(staging): repair broken test build and macOS-incompatible SSRF tests #2064)
• 508b526 test(e2e): expand SSE resilience coverage (test(e2e): expand SSE resilience coverage #1897)
• 8b62985 feat(i18n): add Korean translation, fix zh-CN drift, and prevent future drift via pre-commit hook (feat(i18n): add Korean translation, fix zh-CN drift, and prevent future drift via pre-commit hook #2065)

Current commits in this promotion (2)

Current base: staging-promote/9cf37364-24039632441
Current head: staging-promote/8b629851-24041939370
Current range: origin/staging-promote/9cf37364-24039632441..origin/staging-promote/8b629851-24041939370

• 508b526 test(e2e): expand SSE resilience coverage (test(e2e): expand SSE resilience coverage #1897)
• 8b62985 feat(i18n): add Korean translation, fix zh-CN drift, and prevent future drift via pre-commit hook (feat(i18n): add Korean translation, fix zh-CN drift, and prevent future drift via pre-commit hook #2065)

Auto-updated by staging promotion metadata workflow

Waiting for gates:

• Tests: pending
• E2E: pending
• Claude Code review: pending (will post comments on this PR)

---

Auto-created by staging-ci workflow

[claude]

Code review

Found 5 issues:

1. [HIGH:75] Potential race condition in SSE event ID monotonicity with Ordering::Relaxed

Event sequence counter uses Ordering::Relaxed which lacks sequential consistency guarantees. In high-concurrency scenarios with many simultaneous broadcasts, sequence numbers could be out-of-order, causing dedup failures for reconnected SSE clients.

https://github.com/anthropics/ironclaw/blob/8b6298513d1ab21b96071e1645de9e2d98bf0840/src/channels/web/sse.rs#L97-L104

    fn next_scoped_event(&self, user_id: Option<String>, event: AppEvent) -> ScopedEvent {
        let seq = self.next_event_id.fetch_add(1, Ordering::Relaxed);
        ScopedEvent {
            id: format!("{}:{seq}", self.boot_id),

2. [MEDIUM:85] SSE Last-Event-ID reconnection logic lacks clarity on edge cases

The is_event_after() function silently returns true for invalid/unparseable event IDs. This permissive-by-design behavior is correct but not documented, which could mislead future maintainers about the intent.

https://github.com/anthropics/ironclaw/blob/8b6298513d1ab21b96071e1645de9e2d98bf0840/src/channels/web/sse.rs#L150-L180

3. [MEDIUM:80] Unbounded string allocation in hot path for event IDs

Each SSE event triggers a format!() call creating a new string. With 256-event broadcast buffer, this creates ~57 bytes per event (36-char UUID + ':' + u64), totaling ~14KB+ in flight during peak throughput. Minor but adds GC pressure.

https://github.com/anthropics/ironclaw/blob/8b6298513d1ab21b96071e1645de9e2d98bf0840/src/channels/web/sse.rs#L97-L104

4. [MEDIUM:75] Unquoted shell variables in i18n parity check script

Variables $dups, $missing, $extra used unquoted in printf statements. While format string risk is mitigated because translation keys are developer-controlled, unquoted variables can cause word splitting with special characters.

https://github.com/anthropics/ironclaw/blob/8b6298513d1ab21b96071e1645de9e2d98bf0840/scripts/check-i18n-parity.sh#L59

printf '  %s\n' $dups >&2        # Line 59
printf '  %s\n' $missing >&2     # Line 88
printf '  %s\n' $extra >&2       # Line 91

5. [MEDIUM:70] Shell script glob expansion with potential special characters

The pre-commit hook checks $STAGED correctly, but scripts with unquoted variables can fail on translation keys containing spaces or special characters (e.g., keys with emoji in comments).

https://github.com/anthropics/ironclaw/blob/8b6298513d1ab21b96071e1645de9e2d98bf0840/.githooks/pre-commit#L27-L29

Recommend: Quote all shell variables ("$dups" instead of $dups) and upgrade Ordering::Relaxed to Ordering::AcqRel on the event ID counter.