test: fix gateway workflow webhook integration cooldown - #1889
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests in tests/gateway_workflow_integration.rs by setting cooldown_secs to 0 for a specific routine. This change ensures that the cooldown mechanism does not suppress events when the routine is triggered consecutively via event_emit and the webhook endpoint during the test execution. I have no feedback to provide.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the gateway workflow integration test to avoid routine cooldown suppressing a second, immediate trigger, while leaving production cooldown behavior unchanged.
Changes:
- Set the test-created
system_eventroutine’scooldown_secsto0to allow back-to-back triggers. - Added an inline comment documenting that the test intentionally triggers the same routine via
event_emitand the webhook endpoint sequentially.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nickpismenkov
approved these changes
Apr 1, 2026
This was referenced Apr 1, 2026
serrrfirat
pushed a commit
that referenced
this pull request
Apr 5, 2026
drchirag1991
pushed a commit
to drchirag1991/ironclaw
that referenced
this pull request
Apr 8, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The test created a system_event routine, fired it once via , then immediately asserted that the webhook path would fire it again. With the routine_create default , the second trigger was correctly suppressed, so the test expectation was stale.
Verification