fix(relay): route async Slack messages to correct channel instead of DMs by PierreLeGuen · Pull Request #1845 · nearai/ironclaw

PierreLeGuen · 2026-03-31T23:43:57Z

Summary

routing_target_from_metadata now extracts channel_id from Slack relay metadata, so proactive broadcast() calls target the originating channel (e.g. C088K6C3SQZ) instead of falling back to sender_id (user's DM U07PQGFUDQV)
Lightweight routine JobContext carries notify_channel/notify_user/owner_id in metadata — previously ..Default::default() left it null, losing all delivery routing
Routine creation auto-captures source channel/target from ctx.metadata when the LLM omits delivery.channel/delivery.user
Message tool parameter descriptions clarified: channel = transport name (slack-relay), target = Slack channel/user ID
IronClaw proxy_provider now checks Slack ok=false and surfaces errors (e.g. invalid_thread_ts) instead of silently succeeding

Evidence from relay logs

target_channel="U07PQGFUDQV"  ← wrong: user ID, not channel
slack_channel="D07Q6306AN5"    ← delivered to DM
slack_error="invalid_thread_ts" ← routine notification silently failed

After this fix, routing_target returns C088K6C3SQZ (the Slack channel) and routine creation captures it as notify.user.

Test plan

8 regression tests added (routing_target, routine metadata, delivery defaults)
3970 unit tests pass
Zero clippy warnings
Deploy and verify Ping routine sends to correct channel
Verify cross-channel message(channel: "slack-relay", target: "C088K6C3SQZ") works

🤖 Generated with Claude Code

Fixes three bugs causing async/cross-channel Slack messages to land in DMs or fail silently: 1. routing_target_from_metadata now extracts channel_id for Slack relay messages, so proactive broadcasts target the originating channel instead of falling back to sender_id (user's DM) 2. Lightweight routine JobContext carries notify metadata (owner_id, notify_channel, notify_user) so the message tool can resolve the correct delivery target — previously ..Default::default() left metadata as null 3. Routine creation auto-captures source channel/target from ctx.metadata when the LLM omits delivery params, so routines created from a Slack channel know where to send results Also: - Clarified message tool channel/target parameter descriptions to prevent LLM confusion between transport names and Slack channel IDs - IronClaw proxy_provider now checks Slack ok=false and surfaces errors instead of silently succeeding Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

gemini-code-assist

Code Review

This pull request improves notification routing and error handling for routines and Slack integrations. Key updates include passing notification metadata into lightweight routine contexts, adding channel_id to routing target extraction, and implementing explicit Slack API error handling in the relay client. The RoutineCreateTool now correctly falls back to context metadata for delivery configuration when parameters are omitted. Feedback was provided to use a more idiomatic approach for checking the Slack API response status.

gemini-code-assist · 2026-03-31T23:48:52Z

+
+        // Slack API always returns HTTP 200 but signals errors via {"ok": false}.
+        // Surface these as relay errors so callers get actionable feedback.
+        if json.get("ok") == Some(&serde_json::Value::Bool(false)) {


The check for the ok field in the Slack API response can be written more idiomatically using .as_bool().

Suggested change

if json.get("ok") == Some(&serde_json::Value::Bool(false)) {

if json["ok"].as_bool() == Some(false) {

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…DMs (nearai#1845) * fix(relay): route async Slack messages to correct channel instead of DMs Fixes three bugs causing async/cross-channel Slack messages to land in DMs or fail silently: 1. routing_target_from_metadata now extracts channel_id for Slack relay messages, so proactive broadcasts target the originating channel instead of falling back to sender_id (user's DM) 2. Lightweight routine JobContext carries notify metadata (owner_id, notify_channel, notify_user) so the message tool can resolve the correct delivery target — previously ..Default::default() left metadata as null 3. Routine creation auto-captures source channel/target from ctx.metadata when the LLM omits delivery params, so routines created from a Slack channel know where to send results Also: - Clarified message tool channel/target parameter descriptions to prevent LLM confusion between transport names and Slack channel IDs - IronClaw proxy_provider now checks Slack ok=false and surfaces errors instead of silently succeeding Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * style: apply cargo fmt Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…DMs (#1845) * fix(relay): route async Slack messages to correct channel instead of DMs Fixes three bugs causing async/cross-channel Slack messages to land in DMs or fail silently: 1. routing_target_from_metadata now extracts channel_id for Slack relay messages, so proactive broadcasts target the originating channel instead of falling back to sender_id (user's DM) 2. Lightweight routine JobContext carries notify metadata (owner_id, notify_channel, notify_user) so the message tool can resolve the correct delivery target — previously ..Default::default() left metadata as null 3. Routine creation auto-captures source channel/target from ctx.metadata when the LLM omits delivery params, so routines created from a Slack channel know where to send results Also: - Clarified message tool channel/target parameter descriptions to prevent LLM confusion between transport names and Slack channel IDs - IronClaw proxy_provider now checks Slack ok=false and surfaces errors instead of silently succeeding Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * style: apply cargo fmt Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…DMs (nearai#1845) * fix(relay): route async Slack messages to correct channel instead of DMs Fixes three bugs causing async/cross-channel Slack messages to land in DMs or fail silently: 1. routing_target_from_metadata now extracts channel_id for Slack relay messages, so proactive broadcasts target the originating channel instead of falling back to sender_id (user's DM) 2. Lightweight routine JobContext carries notify metadata (owner_id, notify_channel, notify_user) so the message tool can resolve the correct delivery target — previously ..Default::default() left metadata as null 3. Routine creation auto-captures source channel/target from ctx.metadata when the LLM omits delivery params, so routines created from a Slack channel know where to send results Also: - Clarified message tool channel/target parameter descriptions to prevent LLM confusion between transport names and Slack channel IDs - IronClaw proxy_provider now checks Slack ok=false and surfaces errors instead of silently succeeding Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * style: apply cargo fmt Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

PierreLeGuen requested a review from henrypark133 March 31, 2026 23:47

gemini-code-assist Bot reviewed Mar 31, 2026

View reviewed changes

style: apply cargo fmt

6a63dbf

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

henrypark133 approved these changes Mar 31, 2026

View reviewed changes

PierreLeGuen merged commit f441d78 into staging Mar 31, 2026
14 checks passed

PierreLeGuen deleted the fix/slack-async-message-routing branch March 31, 2026 23:55

ironclaw-ci Bot mentioned this pull request Apr 1, 2026

chore: promote staging to staging-promote/b6b3ffa1-23819569437 (2026-04-01 00:16 UTC) #1847

Merged

This was referenced Apr 1, 2026

chore: promote staging to staging-promote/78e448df-23807837438 (2026-03-31 21:10 UTC) #1843

Merged

chore: promote staging to main (2026-03-31 04:47 UTC) #1809

Merged

ironclaw-ci Bot mentioned this pull request Apr 8, 2026

chore: release #2075

Merged

ironclaw-ci Bot mentioned this pull request Apr 18, 2026

chore: release #2606

Merged

Navigation Menu

fix(relay): route async Slack messages to correct channel instead of DMs - #1845

fix(relay): route async Slack messages to correct channel instead of DMs#1845
PierreLeGuen merged 2 commits into
stagingfrom
fix/slack-async-message-routing

PierreLeGuen commented Mar 31, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if json.get("ok") == Some(&serde_json::Value::Bool(false)) {
	if json["ok"].as_bool() == Some(false) {

Conversation

PierreLeGuen commented Mar 31, 2026

Summary

Evidence from relay logs

Test plan

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants