fix(wasm): use typed WASM schema as advertised schema when available - #1699
Merged
Merged
Conversation
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
zmanian
approved these changes
Mar 27, 2026
zmanian
left a comment
Collaborator
There was a problem hiding this comment.
Approve. Fallback logic is correct: required/enum props -> typed props -> permissive {}. The schema_is_typed_property helper is comprehensive. Good test coverage. Minor suggestion: add a test for mixed typed/untyped properties in the fallback path.
This was referenced Mar 28, 2026
DougAnderson444
pushed a commit
to DougAnderson444/ironclaw
that referenced
this pull request
Mar 29, 2026
This was referenced Mar 29, 2026
drchirag1991
pushed a commit
to drchirag1991/ironclaw
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a WASM tool exports a typed schema with properties, use it as the advertised schema instead of always falling back to permissive
{}. This lets the LLM see the correct parameter requirements and avoids repeated calls with empty params.wrapper.rs:WasmToolSchemas::new()now checks if the extracted schema has typed properties and uses it as the advertised schemaloader.rs: updated the misleading "missing parameters" warning to account for WASM-exported schemasFixes #1303
Test plan
cargo check/cargo check --no-default-features --features libsql/cargo check --all-featurescargo clippy --all --tests— zero warnings