Repository navigation
fix: downgrade excessive debug logging in hot path - #1694
Merged
Merged
Conversation
PR nearai#1681 introduced 23 debug-level log statements across relay client, web server handlers, and extension manager functions. Many of these fire on every HTTP request or in loops (e.g. has_stored_team_id called per extension in list_installed). Downgrade them to trace level to reduce noise at the default debug log level while preserving warn/info logs for actionable diagnostics. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
scope: channel/web
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
ilblackdragon
approved these changes
Mar 27, 2026
zmanian
approved these changes
Mar 27, 2026
zmanian
left a comment
zmanian
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Clean debug! -> trace! downgrade across 23 call sites. Hot paths correctly identified (extension manager loops, relay HTTP round-trips, handler entry logging). No diagnostic info lost -- all messages remain at RUST_LOG=trace. Error-level logs on actual failures untouched. Ship it.
DougAnderson444
pushed a commit
to DougAnderson444/ironclaw
that referenced
this pull request
Mar 29, 2026
… (nearai#1694) PR nearai#1681 introduced 23 debug-level log statements across relay client, web server handlers, and extension manager functions. Many of these fire on every HTTP request or in loops (e.g. has_stored_team_id called per extension in list_installed). Downgrade them to trace level to reduce noise at the default debug log level while preserving warn/info logs for actionable diagnostics. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
drchirag1991
pushed a commit
to drchirag1991/ironclaw
that referenced
this pull request
Apr 8, 2026
… (nearai#1694) PR nearai#1681 introduced 23 debug-level log statements across relay client, web server handlers, and extension manager functions. Many of these fire on every HTTP request or in loops (e.g. has_stored_team_id called per extension in list_installed). Downgrade them to trace level to reduce noise at the default debug log level while preserving warn/info logs for actionable diagnostics. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracing::debug!statements introduced by PR fix(extensions): channel-relay auth dead-end, observability, and URL override #1681 totracing::trace!across three files:src/channels/relay/client.rs(5 sites): HTTP request/response logging ininitiate_oauth,proxy_provider,get_signing_secretsrc/channels/web/server.rs(3 sites): handler entry/retry logging inextensions_activate_handlersrc/extensions/manager.rs(15 sites): step-by-step logging inhas_stored_team_id(called per-extension in list loop),effective_relay_url,auth_channel_relay,activate_channel_relaywarn!andinfo!level logs are preserved for actionable diagnosticsCloses #1686
Test plan
cargo checkpassescargo clippy --all --testspasses with zero warningsRUST_LOG=ironclaw=debugand verify relay activation no longer floods logsRUST_LOG=ironclaw=traceand verify all downgraded messages still appear🤖 Generated with Claude Code