Skip to content

Fix MCP lifecycle trace user scope #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrypark133 merged 7 commits into from
Mar 25, 2026
Merged

Fix MCP lifecycle trace user scope #1646

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a0f61b3
Fix REPL single-message hang and cap CI test duration
henrypark133 Mar 25, 2026
c3343aa
Fix Clippy nested-if lint in REPL startup
henrypark133 Mar 25, 2026
f0bd4f5
Fix single-message approval flow
henrypark133 Mar 25, 2026
815416c
Handle empty single-message REPL exits
henrypark133 Mar 25, 2026
911e057
Wait for one-shot event routines before exit
henrypark133 Mar 25, 2026
6bc26cf
Fix MCP lifecycle trace user scope
henrypark133 Mar 25, 2026
1e3814c
Merge branch 'staging' into codex/fix-ci-test-hangs
henrypark133 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/e2e_advanced_traces.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@ mod advanced {
async fn mcp_extension_lifecycle() {
use crate::support::mock_mcp_server::{MockToolResponse, start_mock_mcp_server};
use ironclaw::extensions::{AuthHint, ExtensionKind, ExtensionSource, RegistryEntry};
const TEST_USER_ID: &str = "test-user";

// 1. Start mock MCP server with pre-configured tool responses.
let mock_server = start_mock_mcp_server(vec![
Expand Down Expand Up @@ -654,14 +655,14 @@ mod advanced {
ext_mgr
.secrets()
.create(
"default",
TEST_USER_ID,
ironclaw::secrets::CreateSecretParams::new(secret_name, "mock-access-token")
.with_provider("mcp:mock-notion".to_string()),
)
.await
.expect("failed to inject test token");

let activate_result = ext_mgr.activate("mock-notion", "default").await;
let activate_result = ext_mgr.activate("mock-notion", TEST_USER_ID).await;
assert!(
activate_result.is_ok(),
"activation failed: {:?}",
Expand Down
Loading