fix: staging CI triage — consolidate retry parsing, fix flaky tests, add docs

[henrypark133]

Summary

Fixes from staging CI review triage (batch processing of 50 open staging-ci-review issues):

• Consolidate retry-after parsing ([HIGH] DRY violation — retry-after parsing logic duplicated across 3 modules (anthrop #1288): Extract shared parse_retry_after() into src/llm/retry.rs supporting both delay-seconds and RFC2822 formats, replacing duplicated inline parsing in anthropic_oauth.rs, nearai_chat.rs, and embeddings.rs
• Fix flaky OAuth tests (Flaky OAuth wildcard callback tests race on OAUTH_CALLBACK_HOST in CI #1280): Add tokio::sync::Mutex to bind_rejects_wildcard_* tests in oauth_helpers.rs to serialize env var access, matching the ENV_MUTEX pattern in oauth_defaults.rs
• Document CLI_ENABLED=false ([MEDIUM] Configuration semantics unclear — The PR doesn't document why `CLI_ENABLED=fal #990): Add comments in launchd/systemd service templates explaining why interactive CLI is disabled in daemon mode

Triage summary

Of the 50 open staging-ci-review issues:

• 45 closed (false positives, stale/already-fixed, duplicates, or too-large architectural concerns)
• 3 fixed in this PR ([HIGH] DRY violation — retry-after parsing logic duplicated across 3 modules (anthrop #1288, Flaky OAuth wildcard callback tests race on OAUTH_CALLBACK_HOST in CI #1280, [MEDIUM] Configuration semantics unclear — The PR doesn't document why `CLI_ENABLED=fal #990)
• 2 left open with triage comments ([HIGH] Hardcoded channel-specific logic violates CLAUDE.md architecture #1248, [HIGH] Telegram-specific business logic bloats ExtensionManager #1249, [MEDIUM] Channel-specific configuration mappings lack extensibility #1251 — Telegram extraction refactor, too large for quick fix)

Test plan

• cargo check passes
• cargo clippy --all --all-features — zero warnings
• New parse_retry_after_* unit tests pass
• bind_rejects_wildcard_* tests pass with mutex serialization
• CI green

🤖 Generated with Claude Code

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses several issues identified during a recent staging CI review triage. It focuses on improving code robustness and maintainability by centralizing Retry-After header parsing logic, enhancing test reliability by fixing flaky OAuth tests, and clarifying daemon mode configuration through updated documentation. These changes contribute to a more stable and understandable codebase by reducing redundancy and improving test determinism.

Highlights

• Retry-After Parsing Consolidation: The logic for parsing the 'Retry-After' HTTP header has been centralized into a new utility function, supporting both delay-seconds and HTTP-date formats. This change removes duplicated parsing implementations across multiple LLM providers.
• Flaky OAuth Test Fixes: Flaky OAuth wildcard callback tests were stabilized by introducing a tokio::sync::Mutex to serialize environment variable access, preventing race conditions during parallel test execution.
• Daemon Mode Documentation: Comments were added to launchd and systemd service templates to clarify the purpose of setting CLI_ENABLED=false, explaining that it disables interactive CLI/REPL in daemon mode to prevent blocking on stdin.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the Retry-After header parsing logic into a new shared utility function, parse_retry_after, in src/llm/retry.rs, which is then used across anthropic_oauth.rs, nearai_chat.rs, and workspace/embeddings.rs to reduce code duplication. It also improves test stability in oauth_helpers.rs by serializing environment-mutating tests with a tokio::sync::Mutex and ensuring proper environment variable restoration. Additionally, #[cfg(test)] attributes were added to cap_retry_after imports to restrict them to test builds, and new unit tests were added for the parse_retry_after function. A new documentation file for CI triage was added, and comments were updated in src/service.rs to clarify daemon mode configuration. Review comments suggest improving readability by moving #[cfg(test)] attributes above use statements and simplifying code by leveraging the parse_retry_after function's built-in handling of missing or unparseable headers.

[Copilot]

Pull request overview

This PR addresses several staging CI triage items by consolidating duplicated Retry-After parsing logic, hardening env-var-sensitive OAuth tests against parallel execution races, and documenting why the interactive CLI is disabled in daemonized service templates.

Changes:

• Extract shared parse_retry_after() into src/llm/retry.rs and switch multiple providers to use it.
• Serialize env-mutating OAuth callback tests to reduce CI flakiness.
• Add inline comments in launchd/systemd templates explaining CLI_ENABLED=false in daemon mode.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/llm/retry.rs	Adds shared Retry-After parsing helper and unit tests.
src/workspace/embeddings.rs	Uses shared retry-after parsing for embedding providers.
src/llm/nearai_chat.rs	Replaces inline retry-after parsing with shared helper.
src/llm/anthropic_oauth.rs	Replaces inline retry-after parsing with shared helper.
src/llm/oauth_helpers.rs	Adds a mutex to serialize env-mutating wildcard bind tests.
src/service.rs	Documents why CLI_ENABLED=false is set in daemon service definitions.
docs/plans/2026-03-18-staging-ci-triage.md	Adds triage plan/notes documenting the staging CI review cleanup.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.