Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(wasm): advertise typed schemas by default #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(wasm): advertise typed schemas by default #1352
Changes from all commits
c3a4a98File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a WASM extension's
schema()export is only partially valid (for example, it has one typed property but also an array property withoutitemsor an orphanedrequiredkey), this branch now publishes that raw schema to the LLM/provider becauseWasmToolSchemas::new()only checkstyped_property_count()and size. Unlike sidecar schemas insrc/tools/wasm/loader.rs, exported schemas never go throughvalidate_tool_schema(), and the provider-side normalizer insrc/llm/rig_adapter.rsonly adds strict-mode fields; it does not repair those structural errors. Before this change we fell back to the permissive{}schema, so malformed exports did not break function-calling for the tool.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.