Skip to content

fix: align release-plz publish config for ironclaw_safety - #1286

Merged
henrypark133 merged 1 commit into
mainfrom
codex/fix-release-plz-publish
Mar 17, 2026
Merged

henrypark133 merged 1 commit into
mainfrom
codex/fix-release-plz-publish

Conversation

@henrypark133

Copy link
Copy Markdown
Collaborator

Summary

  • mark ironclaw_safety as publish = false in release-plz.toml
  • align release-plz config with crates/ironclaw_safety/Cargo.toml
  • unblock the failed chore: release v0.19.0 (chore: release v0.19.0 #973) release workflow

Why
The Release-plz release workflow failed on commit 1ad1335 because ironclaw_safety is publish = false in Cargo metadata, but release-plz still treated it as publishable.

Verification

  • reproduced the original failure from GitHub Actions logs
  • local release-plz dry-run no longer hit the ironclaw_safety publish-config mismatch after this change

Copilot AI review requested due to automatic review settings March 17, 2026 04:51
@github-actions github-actions Bot added the size: XS < 10 changed lines (excluding docs) label Mar 17, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue in the release workflow by correcting a configuration mismatch for the ironclaw_safety package. It ensures that the release-plz.toml file accurately reflects the intended non-publishable status of the package, which was previously causing release failures. The change synchronizes the build system's understanding of the package's publishability, allowing the automated release process to proceed without errors.

Highlights

  • Release Configuration Alignment: Marked the ironclaw_safety package with publish = false in release-plz.toml to align its configuration with the Cargo.toml metadata.
  • Release Workflow Unblock: Resolved a discrepancy that was causing the chore: release v0.19.0 workflow to fail, thereby unblocking future releases.
Changelog
  • release-plz.toml
    • Added publish = false to the [[package]] section for ironclaw_safety.
Activity
  • The original failure of the Release-plz workflow was reproduced from GitHub Actions logs.
  • A local release-plz dry-run was performed, confirming that the ironclaw_safety publish-config mismatch no longer occurred after the changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions github-actions Bot added risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Mar 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly aligns the release-plz.toml configuration for the ironclaw_safety package by setting publish = false. This change is consistent with the package's Cargo.toml and resolves a failure in the release workflow. The change is accurate and I have no further feedback.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns release-plz publishing behavior with the Rust crate metadata for ironclaw_safety, preventing the release workflow from attempting to publish a crate that is explicitly non-publishable.

Changes:

  • Mark ironclaw_safety as publish = false in release-plz.toml to match crates/ironclaw_safety/Cargo.toml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules size: XS < 10 changed lines (excluding docs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants