Repository navigation
fix: align release-plz publish config for ironclaw_safety - #1286
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue in the release workflow by correcting a configuration mismatch for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly aligns the release-plz.toml configuration for the ironclaw_safety package by setting publish = false. This change is consistent with the package's Cargo.toml and resolves a failure in the release workflow. The change is accurate and I have no further feedback.
There was a problem hiding this comment.
Pull request overview
Aligns release-plz publishing behavior with the Rust crate metadata for ironclaw_safety, preventing the release workflow from attempting to publish a crate that is explicitly non-publishable.
Changes:
- Mark
ironclaw_safetyaspublish = falseinrelease-plz.tomlto matchcrates/ironclaw_safety/Cargo.toml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Why
The Release-plz release workflow failed on commit 1ad1335 because ironclaw_safety is publish = false in Cargo metadata, but release-plz still treated it as publishable.
Verification