chore: promote staging to staging-promote/bc672520-23062088162 (2026-03-13 18:08 UTC)

[ironclaw-ci]

Auto-promotion from staging CI

Batch range: bc6725205ada24f26ed30fd042dc4aa6b546cb93..f53c1bb10beba3f6bb1f127c34371a6c0bf6f510
Promotion branch: staging-promote/f53c1bb1-23064256940
Base: staging-promote/bc672520-23062088162
Triggered by: Staging CI batch at 2026-03-13 18:08 UTC

Commits in this batch (1):

• f53c1bb fix(mcp): address 14 audit findings across MCP module (fix(mcp): address 14 audit findings across MCP module #1094)

Current commits in this promotion (19)

Current base: staging-promote/bc672520-23062088162
Current head: staging-promote/f53c1bb1-23064256940
Current range: origin/staging-promote/bc672520-23062088162..origin/staging-promote/f53c1bb1-23064256940

• f53c1bb fix(mcp): address 14 audit findings across MCP module (fix(mcp): address 14 audit findings across MCP module #1094)
• 1bc10fe test: add event-trigger routine e2e coverage (test: add event-trigger routine e2e coverage #1088)
• 7d745d5 tools: improve routine schema guidance (tools: improve routine schema guidance #1089)
• 2b625ef fix(registry): bump versions for github, web-search, and discord extensions (fix(registry): bump versions for github, web-search, and discord #1106)
• f9b880c fix(ci): exclude ironclaw_safety from release automation (fix(ci): exclude ironclaw_safety from release automation #1146)
• 757d24b feat(web): add follow-up suggestion chips and ghost text (feat(web): add follow-up suggestion chips and ghost text #1156)
• c916069 refactor(registry): move MCP servers from code to JSON manifests (refactor(registry): move MCP servers from code to JSON manifests #1144)
• 8fb2f70 fix: HTTP webhook secret transmitted in request body rather than via header, docs inconsistency and security concern (fix: HTTP webhook secret transmitted in request body rather than via … #1162)
• 1770663 fix: Google Sheets returns 403 PERMISSION_DENIED after completing OAuth (fix: Google Sheets returns 403 PERMISSION_DENIED after completing OAuth #1164)
• 579c4fd chore: remove pycache from repo and add to .gitignore (chore: remove __pycache__ from repo and add to .gitignore #1177)
• 7c017ea chore(registry): align manifest versions with published artifacts (chore(registry): align manifest versions with published artifact URLs #1169)
• 8dfad33 fix(webhook): avoid lock-held awaits in server lifecycle paths (fix(webhook): avoid lock-held awaits in server lifecycle paths #1168)
• 3f2796b fix: Non-transactional multi-step context updates between metadata/to… (fix: Non-transactional multi-step context updates between metadata/to… #1161)
• 5f0ed66 perf(routines): avoid full message history clone each tool iteration (perf(routines): avoid full message history clone each tool iteration #1172)
• cc52a04 fix(channels): use live owner binding during wasm hot activation (fix(channels): use live owner binding during wasm hot activation #1171)
• ffe384b fix(llm): add stop_sequences parity for tool completions (fix(llm): add stop_sequences parity for tool completions #1170)
• 994a0b1 fix: N+1 query pattern in event trigger loop (routine_engine) (fix: N+1 query pattern in event trigger loop (routine_engine) #1163)
• e291d3b feat(routines): human-readable cron schedule summaries in web UI (feat(routines): human-readable cron schedule summaries in web UI #1154)
• 71b1a67 fix(deps): update yanked uds_windows 1.2.0 -> 1.2.1 (fix(deps): update yanked uds_windows 1.2.0 -> 1.2.1 #1183)

Auto-updated by staging promotion metadata workflow

Waiting for gates:

• Tests: pending
• E2E: pending
• Claude Code review: pending (will post comments on this PR)

---

Auto-created by staging-ci workflow

[claude]

Code review

Found 5 issues:

1. [HIGH:75] oauth_http_client() stores errors as String in static, not AuthError: In auth.rs, the static stores Result<Client, String> but returns Result<&'static Client, AuthError>. This violates CLAUDE.md's error type guidance—errors should be stored as proper types, not strings.

https://github.com/anthropics/ironclaw/blob/9f6c62c/src/tools/mcp/auth.rs#L15-L23

fn oauth_http_client() -> Result<&'static reqwest::Client, AuthError> {
    static CLIENT: std::sync::OnceLock<Result<reqwest::Client, String>> =
        std::sync::OnceLock::new();
    CLIENT
        .get_or_init(|| {
            reqwest::Client::builder()
                .timeout(Duration::from_secs(30))

2. [HIGH:75] O(n²) string allocations in hot SSE parsing path: In http_transport.rs, the buffer accumulates with buffer.push_str(&String::from_utf8_lossy(&chunk)) and truncates with buffer[remaining_start..].to_string(). For large SSE responses, this creates quadratic behavior. Should pre-allocate capacity and use more efficient string operations.

https://github.com/anthropics/ironclaw/blob/9f6c62c/src/tools/mcp/http_transport.rs#L188-L220

buffer.push_str(&String::from_utf8_lossy(&chunk));
...
buffer = buffer[remaining_start..].to_string();

3. [MEDIUM:70] OnceCell clone resets initialization state, breaking singleton semantics: In client.rs, cloning an McpClient creates a fresh OnceCell::new() instead of sharing the initialization guard. This breaks the design intent—a cloned client will re-initialize even if the source already did, potentially re-sending handshakes or missing cached state.

https://github.com/anthropics/ironclaw/blob/9f6c62c/src/tools/mcp/client.rs#L505-L510

impl Clone for McpClient {
    fn clone(&self) -> Self {
        Self {
            ...
            initialized: tokio::sync::OnceCell::new(),  // Should share with source?

4. [MEDIUM:65] Multiple sequential mutex lock acquisitions for single timeout operation: In transport.rs, stream_transport_send() acquires the writer/pending mutex 3-4 times sequentially (register, write, cleanup). Under contention, this creates lock-wait cycles. Should consolidate into a single critical section where possible.

https://github.com/anthropics/ironclaw/blob/9f6c62c/src/tools/mcp/transport.rs#L870-L933

let mut w = writer.lock().await;  // Lock 1
...
let mut map = pending.lock().await;  // Lock 2
...
let mut w = writer.lock().await;  // Lock 3
...
let mut map = pending.lock().await;  // Lock 4

5. [MEDIUM:60] DRY violation: identical error mapping duplicated in factory.rs: Lines 678-682 and 686-690 duplicate the same error conversion. Extract into a helper function or consolidate branches.

https://github.com/anthropics/ironclaw/blob/9f6c62c/src/tools/mcp/factory.rs#L678-L691

Ok(McpClient::new_with_config(server)
    .map_err(|e| McpFactoryError::InvalidConfig { ... })?
    ...
)
...
Ok(McpClient::new_with_config(server)
    .map_err(|e| McpFactoryError::InvalidConfig { ... })?
    ...
)

🤖 Generated with Claude Code