Skip to content

fix(ci): discord missing attachments field + Dockerfile crates/ copy - #1100

Merged
henrypark133 merged 1 commit into
stagingfrom
fix/staging-ci-discord-docker
Mar 13, 2026
Merged

henrypark133 merged 1 commit into
stagingfrom
fix/staging-ci-discord-docker

Conversation

@henrypark133

Copy link
Copy Markdown
Collaborator

Summary

  • Add missing attachments: vec![] field to EmittedMessage in discord channel (channels-src/discord/src/lib.rs) — the other two call sites already had it
  • Add COPY crates/ crates/ to Dockerfile and Dockerfile.test so the extracted ironclaw_safety crate is available during Docker builds

Fixes staging CI run #23035039465 (5 failing jobs).

Test plan

  • cargo clippy --all --benches --tests --examples --all-features — zero warnings
  • cargo test — all tests pass
  • CI passes on this PR

🤖 Generated with Claude Code

The discord channel's poll_channel_mentions emit_message call was missing
the required `attachments: vec![]` field, causing WASM compilation failure.
Both Dockerfiles were also missing `COPY crates/ crates/` needed for the
extracted ironclaw_safety crate.

[skip-regression-check]

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 13, 2026 04:09
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions Bot added scope: sandbox Docker sandbox size: XS < 10 changed lines (excluding docs) risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Mar 13, 2026
@henrypark133
henrypark133 requested a review from zmanian March 13, 2026 04:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes CI/build breakages by aligning the Discord channel’s emitted message struct initialization with the current EmittedMessage shape and ensuring Docker builds include the workspace crates/ directory needed for path dependencies.

Changes:

  • Add missing attachments: vec![] when emitting a Discord “mention” message.
  • Update channels-src/discord/Cargo.lock to reflect the discord-channel crate version bump to 0.2.0.
  • Include crates/ in Dockerfile and Dockerfile.test build contexts to satisfy workspace path deps during Docker builds.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
channels-src/discord/src/lib.rs Adds missing attachments field to EmittedMessage initialization in the mention polling path.
channels-src/discord/Cargo.lock Updates lockfile entry to match discord-channel version 0.2.0.
Dockerfile.test Copies crates/ into the image to support workspace path dependency resolution during test builds.
Dockerfile Copies crates/ into the image to support workspace path dependency resolution during production builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@henrypark133
henrypark133 merged commit c47237b into staging Mar 13, 2026
16 checks passed
@henrypark133
henrypark133 deleted the fix/staging-ci-discord-docker branch March 13, 2026 04:13
@claude

claude Bot commented Mar 13, 2026

Copy link
Copy Markdown

Code review

No issues found.

@ironclaw-ci ironclaw-ci Bot mentioned this pull request Mar 12, 2026
ilblackdragon pushed a commit that referenced this pull request Mar 14, 2026
…#1100)

The discord channel's poll_channel_mentions emit_message call was missing
the required `attachments: vec![]` field, causing WASM compilation failure.
Both Dockerfiles were also missing `COPY crates/ crates/` needed for the
extracted ironclaw_safety crate.

[skip-regression-check]

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
bkutasi pushed a commit to bkutasi/ironclaw that referenced this pull request Mar 28, 2026
…nearai#1100)

The discord channel's poll_channel_mentions emit_message call was missing
the required `attachments: vec![]` field, causing WASM compilation failure.
Both Dockerfiles were also missing `COPY crates/ crates/` needed for the
extracted ironclaw_safety crate.

[skip-regression-check]

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
drchirag1991 pushed a commit to drchirag1991/ironclaw that referenced this pull request Apr 8, 2026
…nearai#1100)

The discord channel's poll_channel_mentions emit_message call was missing
the required `attachments: vec![]` field, causing WASM compilation failure.
Both Dockerfiles were also missing `COPY crates/ crates/` needed for the
extracted ironclaw_safety crate.

[skip-regression-check]

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules scope: sandbox Docker sandbox size: XS < 10 changed lines (excluding docs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants