feat: mark Ollama + OpenAI-compatible as implemented - #102
Conversation
Summary of ChangesHello @BroccoliFin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's feature parity documentation to accurately reflect the current state of Ollama integration. It specifically marks the local Ollama provider as fully implemented, ensuring that the documentation aligns with the existing codebase capabilities. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the feature parity documentation to mark Ollama support as implemented. The change itself is correct, but I've noted an inconsistency it introduces within the FEATURE_PARITY.md file where another section has not been updated to reflect this change.
| | Google Gemini | ✅ | ❌ | P3 | | | ||
| | OpenRouter | ✅ | ❌ | P3 | | | ||
| | Ollama (local) | ✅ | ❌ | P2 | Local models | | ||
| | Ollama (local) | ✅ | ✅ | - | via `rig::providers::ollama` (full support) | |
There was a problem hiding this comment.
While this update to the feature matrix is correct, it introduces an inconsistency within the document. The 'Implementation Priorities' section on line 431 still lists 'Ollama/local model support' as not implemented (❌).
Please update that section to reflect that this feature is now complete, for example by moving it to the 'P0 - Core (Already Done)' list.
Co-authored-by: BroccoliFin <mikhailsadovoy@MacBook-Air-MacMike.local>
Co-authored-by: BroccoliFin <mikhailsadovoy@MacBook-Air-MacMike.local>
No description provided.