fix: skip credential validation for Bedrock backend - #1011
Merged
ilblackdragon merged 3 commits intoMar 20, 2026
Merged
Conversation
Bedrock uses IAM credentials (instance roles, env vars, SSO) resolved by the AWS SDK at call time, so `provider` is never set during startup. Exclude it from the post-init validation that checks for missing API keys. Closes nearai#1009
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
github-actions
Bot
added
size: XS
ilblackdragon
approved these changes
Mar 20, 2026
This was referenced Mar 20, 2026
zmanian
pushed a commit
that referenced
this pull request
Mar 21, 2026
Bedrock uses IAM credentials (instance roles, env vars, SSO) resolved by the AWS SDK at call time, so `provider` is never set during startup. Exclude it from the post-init validation that checks for missing API keys. Closes #1009 Co-authored-by: brajul <brajul@amazon.com> Co-authored-by: Illia Polosukhin <ilblackdragon@gmail.com>
zmanian
pushed a commit
that referenced
this pull request
Mar 21, 2026
Bedrock uses IAM credentials (instance roles, env vars, SSO) resolved by the AWS SDK at call time, so `provider` is never set during startup. Exclude it from the post-init validation that checks for missing API keys. Closes #1009 Co-authored-by: brajul <brajul@amazon.com> Co-authored-by: Illia Polosukhin <ilblackdragon@gmail.com>
This was referenced Mar 23, 2026
This was referenced Mar 25, 2026
Merged
bkutasi
pushed a commit
to bkutasi/ironclaw
that referenced
this pull request
Mar 28, 2026
Bedrock uses IAM credentials (instance roles, env vars, SSO) resolved by the AWS SDK at call time, so `provider` is never set during startup. Exclude it from the post-init validation that checks for missing API keys. Closes nearai#1009 Co-authored-by: brajul <brajul@amazon.com> Co-authored-by: Illia Polosukhin <ilblackdragon@gmail.com>
drchirag1991
pushed a commit
to drchirag1991/ironclaw
that referenced
this pull request
Apr 8, 2026
Bedrock uses IAM credentials (instance roles, env vars, SSO) resolved by the AWS SDK at call time, so `provider` is never set during startup. Exclude it from the post-init validation that checks for missing API keys. Closes nearai#1009 Co-authored-by: brajul <brajul@amazon.com> Co-authored-by: Illia Polosukhin <ilblackdragon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provideris never populated during startupAppBuilder::build()incorrectly rejects Bedrock as missing credentialsbackend != "bedrock"exclusion to the check, matching the existingnearaiexclusionCloses #1009
Test plan
cargo check— compiles cleanlycargo clippy— no warningscargo fmt --check— formattedcargo test --lib— 157 tests passcargo test --test config_round_trip— 6 tests passLLM_BACKEND=bedrockwith AWS API keys, verify startup succeedsLLM_BACKEND=bedrockwith AWS profiles, verify startup succeeds