Repository navigation
Isolation arm: keep the DSA indexer split, drop r2 back to chunk 8192 #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pranavraja99
wants to merge
1
commit into
main
Choose a base branch
from
pranavraja99/glm53-qsplit-only-c8192
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file modified
BIN
+518 Bytes
(100%)
scripts/__pycache__/prepare_glm53_w4afp8_long_context.cpython-314.pyc
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+744 Bytes
(100%)
scripts/__pycache__/test_glm53_w4afp8_long_context.cpython-314.pyc
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replacement's tail (the unchanged continuation lines right below, ending "...restores 9.3-9.5 GB, which is what makes r2's 16384 admissible") was not updated along with the new text and now contradicts both this replacement and the rest of the generated header: r2 no longer runs chunk 16384 (the engine command is --chunked-prefill-size 8192, and the new isolation-arm paragraph explicitly says not to read the file as an endorsement of either setting). The committed YAML still emits this stale sentence (header lines "16384 was rejected then because / it fell to 0.04 GiB free; the indexer split shrinks that scratch by TP and restores / 9.3-9.5 GB, which is what makes r2's 16384 admissible"), and since prod/GLM-5.3-Flash-SGL-TP4-W4AFP8-LongContext.yaml is generated and marked "Do not hand-edit this file", every regeneration will re-emit the contradiction. Rephrase the tail here (e.g. tie the split-restored headroom to the one-directional pairing gate rather than to r2 running 16384) and regenerate the YAML in the same change.
Suggestion: