collect signatures directly in the right collection #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids creating a Vec to then recreate an Arc with the same information. In practice, this saves 10% of the time in an example taken from nearcore-private#4
nagisa
approved these changes
Oct 10, 2022
This was referenced Nov 10, 2022
bors bot
added a commit
to wasmerio/wasmer
that referenced
this pull request
Nov 21, 2022
3296: Use the right collection when parsing type section r=ptitSeb a=ptitSeb # Description Use the right collection when parsing type section based on near/wasmer#144 For #3305 Co-authored-by: ptitSeb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids creating a Vec to then recreate an Arc with the same information.
In practice, this saves 10% of the time in an example taken from near/nearcore-private#4
The only way in which these variables are only ever used are by converting them into Arcs anyway.