-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add neth #520
add neth #520
Conversation
Hi @mattlockyer , I'm experiencing issues when trying to use NETH, so I hope you can help me with. When I try to connect with Similar goes when I'm using wallet-selector from If I missed something, wouldn't mind some pointers. Thanks! |
Sorry you didn't miss anything. I have the Aurora network added and I think there were some changes in the errors thrown by @metamask/detect-provider I have updated the live install site and the code here to reflect and catch the correct error and prompt a network switch in MetaMask. Please try again. Thanks. |
Hi @DamirSQA were you able to install NETH yet and test this implementation? |
Hi @mattlockyer thanks for the updates. In the wallet list, NETH is missing, and colleague of mine is missing it from the live examples so you might want to investigate that. |
Thanks @mattlockyer, that did the trick. In regard to Neth missing from a list, below is the case of the example page when the wallet extension is missing. You can check out some other wallets, so that in a same way when metamask is missing, users can be aware of and directed to the metamask download page. On localhost, NETH is missing from the list regardless if wallet extension is present or not, so it would be great if that can be addressed. |
Great feedback. Let me work on this case and I'll request a review tomorrow. |
@DamirSQA the visibility of NETH and prompt to install should be working now. Thanks for pointing this out. Not often am I browsing without a Web3 wallet 😄 |
Hi @mattlockyer , I'm afraid that we still have the same issue. Might be that the commit is missing, nevertheless I've recorded a short example for you, so you can check it out on link below. |
https://github.com/NearDeFi/wallet-selector/blob/neth/packages/neth/src/lib/neth-lib.js#L735-L749 |
Thanks for the video. I understood the problem. There was an issue with the gh-pages not picking up the new build. I manually triggered another build and it seems to be working now. Please try again @DamirSQA |
This is to protect against injections and swapping of receiver_id / account_id in known standards patterns |
Thanks @mattlockyer, looking great on gh-pages, only PR left to be updated. |
Is this the update you're referring to? |
However, as sometimes we do need a receiver_id in ft_transfer_call args, is there any ways to let my receiver_id or account_id to take effect, because I found any time in this functioncall, it is replaced by your maker. |
I've recorded video with You should add this in
and then you can Also is it possible to convert |
Hi @mattlockyer , looks like the merge isn't correct in
In signAndSendTransaction inside the action you can pass the gas property on the dApp side. What the "gas" amount is being used for in the setupNeth? |
Please see this explanation: The default gas for all NETH transactions (if multiple are bundled) is 200 Tgas (plenty for most apps) If the app wants to override this global gas amount they can pass that in to setupNeth. NETH can perform multiple transactions in a single NEAR transaction, otherwise the user must sign multiple times, once for each transaction. I may have to add a configuration option that prevents NETH from bundling transactions into a single NEAR transactions since there seems to be use cases where signing individually is advantageous. |
Hey @mattlockyer , thanks for the updates. Regarding root readme you can check it out here What's left is to adapt Other than mentioned, is there anything else you might want to change? |
@DamirSQA fixed the angular example, please try it out. Bundle logic was updated this morning to allow the user to sign everything first and then attempt to process all transactions once signatures are all confirmed by user. This fits the model that most dapp developers are used to when they call signAndSendTransactions The user accepts all transactions by signing everything, or none at all. |
Hey @mattlockyer , we're planning a release next week, so in order for neth to be included, it would be great if you can address the rest of the issues ( TS, depricated, readme ). After release if you make additional changes, new PR can be raised. Also when you're finished with the changes, you can merge dev to your branch and fix conflicts if needed. |
@DamirSQA we should be good for the major release. Have been testing with some apps and cross contract calls to Aurora. |
Hey, @mattlockyer. We have been testing Wallet Selector with the latest version of The easiest way to reproduce this is to clone/fork the wallet-selector project and update the version of |
Will have a look in the morning. It's likely something small re: client side preparation of the transactions. I'll take care of it ASAP! Thank you for flagging! |
@kujtimprenkuSQA changes have been made.
NETH repo for development, docs and NETH install page:
https://github.com/NearDeFi/neth/
neth.app live NETH installation page.