Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rabby wallet #1172

Closed
wants to merge 2 commits into from
Closed

Conversation

rabbyweb3team001
Copy link

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Pavel Ivanov and others added 2 commits August 8, 2024 12:12
@pivanov
Copy link
Contributor

pivanov commented Aug 21, 2024

Please make sure this PR is against dev branch.

@rabbyweb3team001 rabbyweb3team001 changed the base branch from main to dev August 22, 2024 09:46
@rabbyweb3team001
Copy link
Author

Please make sure this PR is against dev branch.

Processed

@gagdiez
Copy link

gagdiez commented Jan 28, 2025

I tested this package as a standalone, and the wallet selector kept telling me that I needed to install rabby

Screenshot 2025-01-28 at 19 48 15

However, Rabby works perfectly as part of the Ethereum Wallets(near-wallet-selector/ethereum-wallets)

Screenshot 2025-01-28 at 19 48 32

I will close this PR, but if the Rabby team would like to have it as a standalone wallet (i.e. outside of the Ethereums wallet bundle) I would recommend them to check how the Ethereum wallets have been implemented and then re-open the PR

@gagdiez gagdiez closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

3 participants