-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update nearcore version to 2.3.0 #368
Conversation
@race-of-sloths please, include my PR in the Race |
@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 2! We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of changes related to the shardlayout, protocol config, redis client calls, future joins and other places. Please, reflect the important ones in changelog and extend the PR description, because right now the number of changes doesn't correspond a simple "upgrade nearcore". Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one
🥁 Score it! @khorolets, please score the PR with |
Supported Nearcore Version
What's Changed
shard_layout
for indexers. Main idea to avoid requestprotocol_config
via RPC,protocol_config
could be changed with new nearcore release and we should support old and new versions ofprotocol_config
.this function depends on never type fallback being '()'
. For now, it is a warning but for the future version, it will be necessary to specify the types explicitly. For more information, see issue #123748 Tracking Issue for Rust 2024: Make!
fall back to!
rust-lang/rust#123748