Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nearcore version to 2.3.0 #368

Merged
merged 2 commits into from
Oct 31, 2024
Merged

update nearcore version to 2.3.0 #368

merged 2 commits into from
Oct 31, 2024

Conversation

kobayurii
Copy link
Member

@kobayurii kobayurii commented Oct 31, 2024

Supported Nearcore Version

  • nearcore v2.3.0
  • rust v1.81.0

What's Changed

  • Change logic to get shard_layout for indexers. Main idea to avoid request protocol_config via RPC, protocol_config could be changed with new nearcore release and we should support old and new versions of protocol_config.
  • After update rust to version 1.81.0 we got a lot of warnings: this function depends on never type fallback being '()'. For now, it is a warning but for the future version, it will be necessary to specify the types explicitly. For more information, see issue #123748 Tracking Issue for Rust 2024: Make ! fall back to ! rust-lang/rust#123748

@kobayurii kobayurii requested a review from khorolets October 31, 2024 11:39
@kobayurii kobayurii self-assigned this Oct 31, 2024
@kobayurii kobayurii marked this pull request as ready for review October 31, 2024 11:40
@kobayurii
Copy link
Member Author

@race-of-sloths please, include my PR in the Race

@race-of-sloths
Copy link

race-of-sloths commented Oct 31, 2024

@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 2

Your contribution is much appreciated with a final score of 2!
You have received 21 (20 base + 5% lifetime bonus) Sloth points for this contribution

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of changes related to the shardlayout, protocol config, redis client calls, future joins and other places. Please, reflect the important ones in changelog and extend the PR description, because right now the number of changes doesn't correspond a simple "upgrade nearcore". Thank you!

logic-state-indexer/src/configs.rs Show resolved Hide resolved
@kobayurii kobayurii requested a review from khorolets October 31, 2024 12:03
Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@kobayurii kobayurii merged commit 17db12a into develop Oct 31, 2024
3 checks passed
@race-of-sloths
Copy link

🥁 Score it!

@khorolets, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants