Extend runtime tests to run on testnet nodes #874
Conversation
bowenwang1996
requested review from
MaksymZavershynskyi,
ilblackdragon and
mikhailOK
| assert_eq!(account_names[0], alice_account()); | ||
| let mut nodes: Vec<_> = nodes | ||
| .drain(..) | ||
| .map(|cfg| match cfg { |
There was a problem hiding this comment.
.map(Node::new)
There was a problem hiding this comment.
That will return Node instead of ThreadNode
There was a problem hiding this comment.
All tests written below accept Node anyway. There is nothing specific in this code that requires ThreadNode. We just need to modify them to accept Box<dyn Node> instead of impl Node.
| assert_eq!(account_names[0], alice_account()); | ||
| let mut nodes: Vec<_> = nodes | ||
| .drain(..) | ||
| .map(|cfg| match cfg { |
There was a problem hiding this comment.
All tests written below accept Node anyway. There is nothing specific in this code that requires ThreadNode. We just need to modify them to accept Box<dyn Node> instead of impl Node.
|
|
We should change them so that they take |
Actually, I take it back. Using |
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=========================================
Coverage ? 72.61%
=========================================
Files ? 78
Lines ? 9779
Branches ? 0
=========================================
Hits ? 7101
Misses ? 2678
Partials ? 0
Continue to review full report at Codecov.
|
No description provided.