please ignore #5397
Closed
please ignore #5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matklad @bowenwang1996 @nearmax @mm-near What do you think? |
|
Extra note: "Add a guide on how to efficiently use GIT for rebasing. Splitting changes, etc." |
|
That's a very good idea - thank you for writing it down. As you mentioned, the git guide will be very helpful, as many people can get lost in managing the 'pending/in-review' PRs - and that's partially a reason why they avoid doing it. |
mm-near
approved these changes
Nov 20, 2021
There was a problem hiding this comment.
@matklad does it make sense for this to be in the same file?
pmnoxx
force-pushed
the
piotr-code-guidelines
branch
from
b15e335 to
cd575e5
Compare
Absolutely! It's the second thing we talk about in rust-analyzer's style.md: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.